From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, lersek@redhat.com, kwolf@redhat.com,
mreitz@redhat.com, qemu-block@nongnu.org, qemu-ppc@nongnu.org,
philmd@redhat.com, balaton@eik.bme.hu
Subject: [Qemu-devel] [PATCH v3 10/14] hw/mips/malta: Remove fl_sectors variable
Date: Thu, 7 Mar 2019 14:03:19 +0100 [thread overview]
Message-ID: <20190307130323.9353-11-armbru@redhat.com> (raw)
In-Reply-To: <20190307130323.9353-1-armbru@redhat.com>
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Variable fl_sectors is used just twice. Since
fl_sectors = bios_size >> 16 and bios_size = FLASH_SIZE there,
we can simply use FLASH_SIZE >> 16, and eliminate variable.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/mips/mips_malta.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index 639ccefa98..750ea86b63 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -1210,7 +1210,6 @@ void mips_malta_init(MachineState *machine)
DriveInfo *dinfo;
DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS];
int fl_idx = 0;
- int fl_sectors = bios_size >> 16;
int be;
DeviceState *dev = qdev_create(NULL, TYPE_MIPS_MALTA);
@@ -1273,13 +1272,13 @@ void mips_malta_init(MachineState *machine)
printf("Register parallel flash %d size " TARGET_FMT_lx " at "
"addr %08llx '%s' %x\n",
fl_idx, blk_getlength(pflash_blk), FLASH_ADDRESS,
- blk_name(pflash_blk), fl_sectors);
+ blk_name(pflash_blk), FLASH_SIZE >> 16);
#endif
}
fl = pflash_cfi01_register(FLASH_ADDRESS, NULL, "mips_malta.bios",
BIOS_SIZE,
pflash_blk,
- 65536, fl_sectors,
+ 65536, FLASH_SIZE >> 16,
4, 0x0000, 0x0000, 0x0000, 0x0000, be);
bios = pflash_cfi01_get_memory(fl);
fl_idx++;
--
2.17.2
next prev parent reply other threads:[~2019-03-07 13:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 13:03 [Qemu-devel] [PATCH v3 00/14] pflash: Fixes and cleanups Markus Armbruster
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 01/14] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02 Markus Armbruster
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 02/14] pflash_cfi01: Do not exit() on guest aborting "write to buffer" Markus Armbruster
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 03/14] pflash_cfi01: Log use of flawed " Markus Armbruster
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 04/14] pflash: Rename *CFI_PFLASH* to *PFLASH_CFI* Markus Armbruster
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 05/14] hw: Use PFLASH_CFI0{1, 2} and TYPE_PFLASH_CFI0{1, 2} Markus Armbruster
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 06/14] sam460ex: Don't size flash memory to match backing image Markus Armbruster
2019-03-08 14:04 ` Philippe Mathieu-Daudé
2019-03-08 14:27 ` Markus Armbruster
2019-03-08 14:34 ` Philippe Mathieu-Daudé
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 07/14] ppc405_boards: " Markus Armbruster
2019-03-08 0:10 ` David Gibson
2019-03-08 7:24 ` Markus Armbruster
2019-03-08 11:09 ` David Gibson
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 08/14] r2d: Fix flash memory size, sector size, width, device ID Markus Armbruster
2019-03-07 13:51 ` Philippe Mathieu-Daudé
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 09/14] hw/mips/malta: Fix the DEBUG_BOARD_INIT code Markus Armbruster
2019-03-07 13:03 ` Markus Armbruster [this message]
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 11/14] hw/mips/malta: Restrict 'bios_size' variable scope Markus Armbruster
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 12/14] mips_malta: Clean up definition of flash memory size somewhat Markus Armbruster
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 13/14] pflash: Clean up after commit 368a354f02b, part 1 Markus Armbruster
2019-03-07 13:03 ` [Qemu-devel] [PATCH v3 14/14] pflash: Clean up after commit 368a354f02b, part 2 Markus Armbruster
2019-03-08 14:05 ` Philippe Mathieu-Daudé
2019-03-09 13:27 ` [Qemu-devel] [PATCH v3 00/14] pflash: Fixes and cleanups no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307130323.9353-11-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).