From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PATCH v3 04/12] decodetree: Ensure build_tree does not include values outside insnmask
Date: Thu, 7 Mar 2019 10:56:14 -0800 [thread overview]
Message-ID: <20190307185622.29026-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20190307185622.29026-1-richard.henderson@linaro.org>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reproduced with "scripts/decodetree.py /dev/null".
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
scripts/decodetree.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 33e32ee87f..e26d8253f2 100755
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -784,7 +784,7 @@ class Tree:
def build_tree(pats, outerbits, outermask):
# Find the intersection of all remaining fixedmask.
- innermask = ~outermask
+ innermask = ~outermask & insnmask
for i in pats:
innermask &= i.fixedmask
--
2.17.2
next prev parent reply other threads:[~2019-03-07 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 18:56 [Qemu-devel] [PATCH v3 00/12] decodetree enhacements Richard Henderson
2019-03-07 18:56 ` [Qemu-devel] [PATCH v3 01/12] MAINTAINERS: Add scripts/decodetree.py to the TCG section Richard Henderson
2019-03-07 18:56 ` [Qemu-devel] [PATCH v3 02/12] decodetree: Move documentation to docs/devel/decodetree.rst Richard Henderson
2019-03-07 18:56 ` [Qemu-devel] [PATCH v3 03/12] decodetree: Document the usefulness of argument sets Richard Henderson
2019-03-07 18:56 ` Richard Henderson [this message]
2019-03-07 18:56 ` [Qemu-devel] [PATCH v3 05/12] decodetree: Do not unconditionaly return from Pattern.output_code Richard Henderson
2019-03-07 18:56 ` [Qemu-devel] [PATCH v3 06/12] decodetree: Allow grouping of overlapping patterns Richard Henderson
2019-03-07 18:56 ` [Qemu-devel] [PATCH v3 07/12] test/decode: Add tests for PatternGroups Richard Henderson
2019-03-07 18:56 ` [Qemu-devel] [PATCH v3 08/12] decodetree: Add --static-decode option Richard Henderson
2019-03-07 18:56 ` [Qemu-devel] [PATCH v3 09/12] decodetree: Produce clean output for an empty input file Richard Henderson
2019-03-07 18:56 ` [Qemu-devel] [PATCH v3 10/12] decodetree: Allow +- to begin a number initializing a field Richard Henderson
2019-03-07 18:56 ` [Qemu-devel] [PATCH v3 11/12] decodetree: Prefix extract function names with decode_function Richard Henderson
2019-03-07 18:56 ` [Qemu-devel] [PATCH v3 12/12] decodetree: Properly diagnose fields overflowing an insn Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307185622.29026-5-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).