qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 1/2] target/arm: Put system registers in "system" group
Date: Thu,  7 Mar 2019 12:12:43 -0800	[thread overview]
Message-ID: <20190307201244.8971-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20190307201244.8971-1-richard.henderson@linaro.org>

The system group is predefined within gdb.  While the spec
seems to allow arbitrary group names, that seems to mess up
the addition of all registers to any groups.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/gdbstub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c
index 0c64c0292e..67c8874b3b 100644
--- a/target/arm/gdbstub.c
+++ b/target/arm/gdbstub.c
@@ -113,7 +113,7 @@ static void arm_gen_one_xml_reg_tag(GString *s, DynamicGDBXMLInfo *dyn_xml,
 {
     g_string_append_printf(s, "<reg name=\"%s\"", ri->name);
     g_string_append_printf(s, " bitsize=\"%d\"", bitsize);
-    g_string_append_printf(s, " group=\"cp_regs\"/>");
+    g_string_append_printf(s, " group=\"system\"/>");
     dyn_xml->num_cpregs++;
     dyn_xml->cpregs_keys[dyn_xml->num_cpregs - 1] = ri_key;
 }
-- 
2.17.2

  reply	other threads:[~2019-03-07 20:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07 20:12 [Qemu-devel] [PATCH 0/2] target/arm: gdbstub system registers refinement Richard Henderson
2019-03-07 20:12 ` Richard Henderson [this message]
2019-03-07 20:12 ` [Qemu-devel] [PATCH 2/2] target/arm: Don't add system-registers.xml for user-only Richard Henderson
2019-03-08 15:59 ` [Qemu-devel] [PATCH 0/2] target/arm: gdbstub system registers refinement Peter Maydell
2019-03-08 16:11   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190307201244.8971-2-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).