From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 2/2] target/arm: Don't add system-registers.xml for user-only
Date: Thu, 7 Mar 2019 12:12:44 -0800 [thread overview]
Message-ID: <20190307201244.8971-3-richard.henderson@linaro.org> (raw)
In-Reply-To: <20190307201244.8971-1-richard.henderson@linaro.org>
The system registers aren't that interesting for debugging
user binaries. Avoid adding them in this case.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/helper.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 2607d39ad1..ca5632d26f 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -221,6 +221,7 @@ static void write_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri,
}
}
+#ifndef CONFIG_USER_ONLY
static int arm_gdb_get_sysreg(CPUARMState *env, uint8_t *buf, int reg)
{
ARMCPU *cpu = arm_env_get_cpu(env);
@@ -243,6 +244,7 @@ static int arm_gdb_set_sysreg(CPUARMState *env, uint8_t *buf, int reg)
{
return 0;
}
+#endif
static bool raw_accessors_invalid(const ARMCPRegInfo *ri)
{
@@ -6694,9 +6696,11 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *cpu)
gdb_register_coprocessor(cs, vfp_gdb_get_reg, vfp_gdb_set_reg,
19, "arm-vfp.xml", 0);
}
+#ifndef CONFIG_USER_ONLY
gdb_register_coprocessor(cs, arm_gdb_get_sysreg, arm_gdb_set_sysreg,
arm_gen_dynamic_xml(cs),
"system-registers.xml", 0);
+#endif
}
/* Sort alphabetically by type name, except for "any". */
--
2.17.2
next prev parent reply other threads:[~2019-03-07 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 20:12 [Qemu-devel] [PATCH 0/2] target/arm: gdbstub system registers refinement Richard Henderson
2019-03-07 20:12 ` [Qemu-devel] [PATCH 1/2] target/arm: Put system registers in "system" group Richard Henderson
2019-03-07 20:12 ` Richard Henderson [this message]
2019-03-08 15:59 ` [Qemu-devel] [PATCH 0/2] target/arm: gdbstub system registers refinement Peter Maydell
2019-03-08 16:11 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307201244.8971-3-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).