Re: [Qemu-devel] [PATCH] spapr: Use CamelCase properly

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2224 bytes --]

On Thu, Mar 07, 2019 at 04:38:28PM +1100, Alexey Kardashevskiy wrote:
> 
> 
> On 07/03/2019 16:21, David Gibson wrote:
> > The qemu coding standard is to use CamelCase for type and structure names,
> > and the pseries code follows that... sort of.  There are quite a lot of
> > places where we bend the rules in order to preserve the capitalization of
> > internal acronyms like "PHB", "TCE", "DIMM" and most commonly "sPAPR".
> > 
> > That was a bad idea - it frequently leads to names ending up with hard to
> > read clusters of capital letters, and means they don't catch the eye as
> > type identifiers, which is kind of the point of the CamelCase convention in
> > the first place.
> > 
> > In short, keeping type identifiers look like CamelCase is more important
> > than preserving standard capitalization of internal "words".  So, this
> > patch renames a heap of spapr internal type names to a more standard
> > CamelCase.
> > 
> > In addition to case changes, we also make some other identifier renames:
> >   VIOsPAPR* -> SpaprVio*
> >     The reverse word ordering was only ever used to mitigate the capital
> >     cluster, so revert to the natural ordering.
> >   VIOsPAPRVTYDevice -> SpaprVioVty
> >   VIOsPAPRVLANDevice -> SpaprVioVlan
> >     Brevity, since the "Device" didn't add useful information
> >   sPAPRDRConnector -> SpaprDrc
> >   sPAPRDRConnectorClass -> SpaprDrcClass
> >     Brevity, and makes it clearer this is the same thing as a "DRC"
> >     mentioned in many other places in the code
> > 
> > This is 100% a mechanical search-and-replace patch. It will, however,
> > conflict with essentially any and all outstanding patches touching the
> > spapr code.
> 
> 
> so it would be nice to have the script to fix those outstanding patches
> before reposting.

Sorry, I don't have a script for this.

The patch is equivalent to a scripted replacement, but I didn't
actually make it with a script - I built it up interactively using the
"regexxer" tool.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]