* [Qemu-devel] [PULL 1/2] tricore: fixed RCR_CADD instruction
2019-03-08 9:54 [Qemu-devel] [PULL 0/2] tricore patches Bastian Koppelmann
@ 2019-03-08 9:54 ` Bastian Koppelmann
2019-03-08 9:54 ` [Qemu-devel] [PULL 2/2] tricore: fixed RCR_CADDN instruction Bastian Koppelmann
2019-03-09 14:05 ` [Qemu-devel] [PULL 0/2] tricore patches Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Bastian Koppelmann @ 2019-03-08 9:54 UTC (permalink / raw)
To: qemu-devel
Cc: david.brenken, christian.richter, georg.hofstetter, robert.rasche,
lars.biermanski
From: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Christian Richter <christian.richter@efs-auto.de>
Signed-off-by: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
Signed-off-by: Robert Rasche <robert.rasche@efs-auto.de>
Signed-off-by: Lars Biermanski <lars.biermanski@efs-auto.de>
Message-Id: <20190207073928.4048-2-david.brenken@efs-auto.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
target/tricore/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 14f0ddfa1e..5846f95316 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -5867,8 +5867,8 @@ static void decode_rcr_cond_select(CPUTriCoreState *env, DisasContext *ctx)
switch (op2) {
case OPC2_32_RCR_CADD:
- gen_condi_add(TCG_COND_NE, cpu_gpr_d[r1], const9, cpu_gpr_d[r3],
- cpu_gpr_d[r4]);
+ gen_condi_add(TCG_COND_NE, cpu_gpr_d[r1], const9, cpu_gpr_d[r4],
+ cpu_gpr_d[r3]);
break;
case OPC2_32_RCR_CADDN:
gen_condi_add(TCG_COND_EQ, cpu_gpr_d[r1], const9, cpu_gpr_d[r3],
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Qemu-devel] [PULL 2/2] tricore: fixed RCR_CADDN instruction
2019-03-08 9:54 [Qemu-devel] [PULL 0/2] tricore patches Bastian Koppelmann
2019-03-08 9:54 ` [Qemu-devel] [PULL 1/2] tricore: fixed RCR_CADD instruction Bastian Koppelmann
@ 2019-03-08 9:54 ` Bastian Koppelmann
2019-03-09 14:05 ` [Qemu-devel] [PULL 0/2] tricore patches Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Bastian Koppelmann @ 2019-03-08 9:54 UTC (permalink / raw)
To: qemu-devel
Cc: david.brenken, christian.richter, georg.hofstetter, robert.rasche,
lars.biermanski
From: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Christian Richter <christian.richter@efs-auto.de>
Signed-off-by: David Brenken <david.brenken@efs-auto.de>
Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
Signed-off-by: Robert Rasche <robert.rasche@efs-auto.de>
Signed-off-by: Lars Biermanski <lars.biermanski@efs-auto.de>
Message-Id: <20190207073928.4048-3-david.brenken@efs-auto.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
target/tricore/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 5846f95316..b12c391be5 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -5871,8 +5871,8 @@ static void decode_rcr_cond_select(CPUTriCoreState *env, DisasContext *ctx)
cpu_gpr_d[r3]);
break;
case OPC2_32_RCR_CADDN:
- gen_condi_add(TCG_COND_EQ, cpu_gpr_d[r1], const9, cpu_gpr_d[r3],
- cpu_gpr_d[r4]);
+ gen_condi_add(TCG_COND_EQ, cpu_gpr_d[r1], const9, cpu_gpr_d[r4],
+ cpu_gpr_d[r3]);
break;
case OPC2_32_RCR_SEL:
temp = tcg_const_i32(0);
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PULL 0/2] tricore patches
2019-03-08 9:54 [Qemu-devel] [PULL 0/2] tricore patches Bastian Koppelmann
2019-03-08 9:54 ` [Qemu-devel] [PULL 1/2] tricore: fixed RCR_CADD instruction Bastian Koppelmann
2019-03-08 9:54 ` [Qemu-devel] [PULL 2/2] tricore: fixed RCR_CADDN instruction Bastian Koppelmann
@ 2019-03-09 14:05 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2019-03-09 14:05 UTC (permalink / raw)
To: Bastian Koppelmann
Cc: QEMU Developers, david.brenken, robert.rasche, georg.hofstetter,
christian.richter, lars.biermanski
On Fri, 8 Mar 2019 at 09:59, Bastian Koppelmann
<kbastian@mail.uni-paderborn.de> wrote:
>
> The following changes since commit 6cb4f6db4f4367faa33da85b15f75bbbd2bed2a6:
>
> Merge remote-tracking branch 'remotes/cleber/tags/python-next-pull-request' into staging (2019-03-07 16:16:02 +0000)
>
> are available in the Git repository at:
>
> https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore-2019-03-08
>
> for you to fetch changes up to d1c1d88ce6fd768cb98cd7af81b1b23ac9fe168d:
>
> tricore: fixed RCR_CADDN instruction (2019-03-08 10:00:59 +0100)
>
> ----------------------------------------------------------------
> Fixes mixed up operands in CADDN and CADD
>
> ----------------------------------------------------------------
> David Brenken (2):
> tricore: fixed RCR_CADD instruction
> tricore: fixed RCR_CADDN instruction
>
> target/tricore/translate.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> --
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread