From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:50543)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1h2CTX-0005qv-Q7
	for qemu-devel@nongnu.org; Fri, 08 Mar 2019 05:11:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1h2CTX-00051L-0d
	for qemu-devel@nongnu.org; Fri, 08 Mar 2019 05:11:35 -0500
Date: Fri, 8 Mar 2019 11:11:23 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20190308101123.GC5339@localhost.localdomain>
References: <20190307145839.13128-1-philmd@redhat.com>
	<20190307145839.13128-3-philmd@redhat.com>
	<27fba8af-670c-e425-54f4-620019466f58@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <27fba8af-670c-e425-54f4-620019466f58@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 2/4] tests/bios-tables: Improve
 portability by searching bash in the $PATH
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= <philmd@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>, Max Reitz <mreitz@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Kamil Rytarowski <n54@gmx.com>, Brad Smith <brad@comstyle.com>

Am 07.03.2019 um 20:50 hat Thomas Huth geschrieben:
> On 07/03/2019 15.58, Philippe Mathieu-Daud=E9 wrote:
> > Bash is not always installed as /bin/bash. In particular on OpenBSD,
> > the package installs it in /usr/local/bin.
> > Use the 'env' shebang to search bash in the $PATH.
> >=20
> > Reviewed-by: Kamil Rytarowski <n54@gmx.com>
> > Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Philippe Mathieu-Daud=E9 <philmd@redhat.com>
> > ---
> >  tests/data/acpi/rebuild-expected-aml.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/acp=
i/rebuild-expected-aml.sh
> > index bf9ba242ad..abdff70a0d 100755
> > --- a/tests/data/acpi/rebuild-expected-aml.sh
> > +++ b/tests/data/acpi/rebuild-expected-aml.sh
> > @@ -1,4 +1,4 @@
> > -#! /bin/bash
> > +#!/usr/bin/env bash
> > =20
> >  #
> >  # Rebuild expected AML files for acpi unit-test
> >=20
>=20
> In case Kevin wants to pick this up, too:
>=20
> Acked-by: Thomas Huth <thuth@redhat.com>
>=20
> Otherwise, I can take this one also through the qtest tree.

Thanks! I already queued it yesterday, but having your Ack is better.

Kevin