qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, lersek@redhat.com, kwolf@redhat.com,
	mreitz@redhat.com, qemu-block@nongnu.org, pkrempa@redhat.com,
	mst@redhat.com, marcel.apfelbaum@gmail.com,
	marcandre.lureau@redhat.com, philmd@redhat.com
Subject: [Qemu-devel] [PATCH v3 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash
Date: Fri,  8 Mar 2019 14:14:45 +0100	[thread overview]
Message-ID: <20190308131445.17502-13-armbru@redhat.com> (raw)
In-Reply-To: <20190308131445.17502-1-armbru@redhat.com>

The previous commit added a way to configure firmware with -blockdev
rather than -drive if=pflash.  Document it as the preferred way.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 docs/interop/firmware.json | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
index 28f9bc1591..ff8c2ce5f2 100644
--- a/docs/interop/firmware.json
+++ b/docs/interop/firmware.json
@@ -212,9 +212,13 @@
 #
 # @executable: Identifies the firmware executable. The firmware
 #              executable may be shared by multiple virtual machine
-#              definitions. The corresponding QEMU command line option
-#              is "-drive
-#              if=pflash,unit=0,readonly=on,file=@executable.@filename,format=@executable.@format".
+#              definitions. The preferred corresponding QEMU command
+#              line options are
+#                  -drive if=none,id=pflash0,readonly=on,file=@executable.@filename,format=@executable.@format
+#                  -machine pflash0=pflash0
+#              or equivalent -blockdev instead of -drive.
+#              With QEMU versions older than 4.0, you have to use
+#                  -drive if=pflash,unit=0,readonly=on,file=@executable.@filename,format=@executable.@format
 #
 # @nvram-template: Identifies the NVRAM template compatible with
 #                  @executable. Management software instantiates an
@@ -225,9 +229,13 @@
 #                  individual copies of it are. An NVRAM file is
 #                  typically used for persistently storing the
 #                  non-volatile UEFI variables of a virtual machine
-#                  definition. The corresponding QEMU command line
-#                  option is "-drive
-#                  if=pflash,unit=1,readonly=off,file=FILENAME_OF_PRIVATE_NVRAM_FILE,format=@nvram-template.@format".
+#                  definition. The preferred corresponding QEMU
+#                  command line options are
+#                      -drive if=none,id=pflash1,readonly=off,file=FILENAME_OF_PRIVATE_NVRAM_FILE,format=@nvram-template.@format
+#                      -machine pflash1=pflash1
+#                  or equivalent -blockdev instead of -drive.
+#                  With QEMU versions older than 4.0, you have to use
+#                      -drive if=pflash,unit=1,readonly=off,file=FILENAME_OF_PRIVATE_NVRAM_FILE,format=@nvram-template.@format
 #
 # Since: 3.0
 ##
-- 
2.17.2

  parent reply	other threads:[~2019-03-08 13:15 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08 13:14 [Qemu-devel] [PATCH v3 00/12] pc: Support firmware configuration with -blockdev Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 01/12] qdev: Fix latent bug with compat_props and onboard devices Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 02/12] qom: Move compat_props machinery from qdev to QOM Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 03/12] vl: Fix latent bug with -global and onboard devices Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 04/12] sysbus: Fix latent bug with " Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 05/12] vl: Improve legibility of BlockdevOptions queue Markus Armbruster
2019-03-08 14:48   ` Philippe Mathieu-Daudé
2019-03-11 14:17   ` Paolo Bonzini
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 06/12] vl: Factor configure_blockdev() out of main() Markus Armbruster
2019-03-11 14:18   ` Paolo Bonzini
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 07/12] vl: Create block backends before setting machine properties Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 08/12] pflash_cfi01: Add pflash_cfi01_get_blk() helper Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 09/12] pc_sysfw: Remove unused PcSysFwDevice Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 10/12] pc_sysfw: Pass PCMachineState to pc_system_firmware_init() Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 11/12] pc: Support firmware configuration with -blockdev Markus Armbruster
2019-03-11 14:30   ` Paolo Bonzini
2019-03-11 15:42     ` Markus Armbruster
2019-03-11 17:08       ` Paolo Bonzini
2019-03-11 17:18       ` Philippe Mathieu-Daudé
2019-03-12  6:52         ` Markus Armbruster
2019-03-08 13:14 ` Markus Armbruster [this message]
2019-03-08 13:38   ` [Qemu-devel] [PATCH v3 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash Laszlo Ersek
2019-03-08 13:41 ` [Qemu-devel] [PATCH v3 00/12] pc: Support firmware configuration with -blockdev Michael S. Tsirkin
2019-03-08 14:39   ` Markus Armbruster
2019-03-11 17:39 ` [Qemu-devel] [PATCH v4 11/12] " Markus Armbruster
2019-03-11 17:42   ` Markus Armbruster
2019-03-11 17:45     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190308131445.17502-13-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).