Re: [Qemu-devel] [PATCH v4 1/2] qapi: move to QOM path for x-block-latency-histogram-set

[Kevin Wolf <kwolf@redhat.com>]

Am 05.03.2019 um 13:53 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  qapi/block-core.json |  4 ++--
>  blockdev.c           | 12 ++++++------
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 2b8afbb924..8187de0836 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -541,7 +541,7 @@
>  # If only @device parameter is specified, remove all present latency histograms

@device doesn't exist any more, so this should become @id.

The examples below need to be changed, too.

>  # for the device. Otherwise, add/reset some of (or all) latency histograms.
>  #
> -# @device: device name to set latency histogram for.
> +# @id: The name or QOM path of the guest device.
>  #
>  # @boundaries: list of interval boundary values (see description in
>  #              BlockLatencyHistogramInfo definition). If specified, all
> @@ -599,7 +599,7 @@
>  # <- { "return": {} }
>  ##
>  { 'command': 'x-block-latency-histogram-set',
> -  'data': {'device': 'str',
> +  'data': {'id': 'str',
>             '*boundaries': ['uint64'],
>             '*boundaries-read': ['uint64'],
>             '*boundaries-write': ['uint64'],

The rest of the series looks good to me.

Kevin