From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>, Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Laurent Vivier <lvivier@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 3/8] multifd: Create new next_packet_size field
Date: Fri, 8 Mar 2019 19:28:30 +0000 [thread overview]
Message-ID: <20190308192829.GL2834@work-vm> (raw)
In-Reply-To: <87o96m3m2o.fsf@trasno.org>
* Juan Quintela (quintela@redhat.com) wrote:
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> > * Juan Quintela (quintela@redhat.com) wrote:
> >> We need to send this field when we add compression support. As we are
> >> still on x- stage, we can do this kind of changes.
> >>
> >> Signed-off-by: Juan Quintela <quintela@redhat.com>
> >
> > OK, so that kind of makes sense - in that what you want to do is read
> > the whole compressed chunk in one go.
> >
> > Consider it might be a good idea to add some spare entries here;
> > say a uint64_t dummy[4] so that if you need any more fields in the
> > future it'll be easy to add them without breaking compatibility.
>
> We have a version field, so ... we can handle it relatively gratiously,
> but I see your point.
>
> How many?
<rolls dice>
4
Now don't use them all at once!
Dave
> Later, Juan.
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-03-08 19:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 11:08 [Qemu-devel] [PATCH v3 0/8] migration: Mark multifd not experimental Juan Quintela
2019-02-27 11:08 ` [Qemu-devel] [PATCH v3 1/8] multifd: Only send pages when packet are not empty Juan Quintela
2019-02-27 11:08 ` [Qemu-devel] [PATCH v3 2/8] multifd: Rename "size" member to pages_alloc Juan Quintela
2019-02-27 11:08 ` [Qemu-devel] [PATCH v3 3/8] multifd: Create new next_packet_size field Juan Quintela
2019-03-06 15:28 ` Dr. David Alan Gilbert
2019-03-07 12:28 ` Juan Quintela
2019-03-07 17:01 ` Eric Blake
2019-03-08 19:28 ` Dr. David Alan Gilbert [this message]
2019-02-27 11:08 ` [Qemu-devel] [PATCH v3 4/8] multifd: Drop x-multifd-page-count parameter Juan Quintela
2019-03-09 17:09 ` Markus Armbruster
2019-02-27 11:08 ` [Qemu-devel] [PATCH v3 5/8] multifd: Be flexible about packet size Juan Quintela
2019-02-27 11:08 ` [Qemu-devel] [PATCH v3 6/8] multifd: Change default " Juan Quintela
2019-02-27 11:08 ` [Qemu-devel] [PATCH v3 7/8] multifd: Drop x- Juan Quintela
2019-03-09 17:11 ` Markus Armbruster
2019-02-27 11:08 ` [Qemu-devel] [PATCH v3 8/8] tests: Add migration multifd test Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308192829.GL2834@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).