From: Sven Schnelle <svens@stackframe.org>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>,
deller@gmx.de
Subject: Re: [Qemu-devel] [PATCH 1/2] lsi: 810/895A are always little endian
Date: Fri, 8 Mar 2019 20:40:16 +0100 [thread overview]
Message-ID: <20190308194016.GA8169@t470p.stackframe.org> (raw)
In-Reply-To: <20190218175529.11237-1-svens@stackframe.org>
Hi Paolo,
can you please also queue this patch? This is the last one required to get HP-UX
10.20 running in QEMU. It still needs -d nochain, but that's a different story...
Thanks
Sven
On Mon, Feb 18, 2019 at 06:55:28PM +0100, Sven Schnelle wrote:
> Signed-off-by: Sven Schnelle <svens@stackframe.org>
> ---
> hw/scsi/lsi53c895a.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
> index bcff859bac..c493e3c4c7 100644
> --- a/hw/scsi/lsi53c895a.c
> +++ b/hw/scsi/lsi53c895a.c
> @@ -2061,14 +2061,13 @@ static uint64_t lsi_mmio_read(void *opaque, hwaddr addr,
> unsigned size)
> {
> LSIState *s = opaque;
> -
> return lsi_reg_readb(s, addr & 0xff);
> }
>
> static const MemoryRegionOps lsi_mmio_ops = {
> .read = lsi_mmio_read,
> .write = lsi_mmio_write,
> - .endianness = DEVICE_NATIVE_ENDIAN,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> .impl = {
> .min_access_size = 1,
> .max_access_size = 1,
> @@ -2107,7 +2106,7 @@ static uint64_t lsi_ram_read(void *opaque, hwaddr addr,
> static const MemoryRegionOps lsi_ram_ops = {
> .read = lsi_ram_read,
> .write = lsi_ram_write,
> - .endianness = DEVICE_NATIVE_ENDIAN,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> };
>
> static uint64_t lsi_io_read(void *opaque, hwaddr addr,
> @@ -2127,7 +2126,7 @@ static void lsi_io_write(void *opaque, hwaddr addr,
> static const MemoryRegionOps lsi_io_ops = {
> .read = lsi_io_read,
> .write = lsi_io_write,
> - .endianness = DEVICE_NATIVE_ENDIAN,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> .impl = {
> .min_access_size = 1,
> .max_access_size = 1,
> --
> 2.20.1
>
>
prev parent reply other threads:[~2019-03-08 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 17:55 [Qemu-devel] [PATCH 1/2] lsi: 810/895A are always little endian Sven Schnelle
2019-02-18 17:55 ` [Qemu-devel] [PATCH 2/2] lsi: use ldn_le_p()/stn_le_p() Sven Schnelle
2019-02-18 21:39 ` Philippe Mathieu-Daudé
2019-02-18 21:46 ` Peter Maydell
2019-02-19 7:38 ` Sven Schnelle
2019-03-08 19:40 ` Sven Schnelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308194016.GA8169@t470p.stackframe.org \
--to=svens@stackframe.org \
--cc=deller@gmx.de \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).