qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yuval Shaia <yuval.shaia@oracle.com>
To: dgilbert@redhat.com, yuval.shaia@oracle.com,
	marcel.apfelbaum@gmail.com, armbru@redhat.com,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v5 00/10] Misc fixes to pvrdma device
Date: Sun, 10 Mar 2019 10:46:00 +0200	[thread overview]
Message-ID: <20190310084610.23077-1-yuval.shaia@oracle.com> (raw)

Hi,
Please review the following patch-set which consist of cosmetics fixes to
device's user interface (traces, error_report and monitor) and some bug
fixes.

Thanks Markus, Eric, Marcel and David for your review

Review is needed for patch #4 - "hw/pvrdma: Collect debugging statistics"

v0 -> v1:
    * Explain why device attributes are exposed only in HMP interface.
    * Squash the 3 patches related to HMP interface into one.
    * Make monitor dump function simple.
    * Make HMP interface available only if pvrdma is included (detected by
      build robot).
    * Remove patch 03/10 ("Warn when too many consecutive poll CQ triggered
      on an empty CQ) and add the two counters to patch 0/7 (monitor).
    * Add Marcel's R-Bs.
    * Add mutex protection to cqe_ctx list.
    * Add two new patches.

v1 -> v2:
    * Rename locked-lists to protected-lists in patch 2 and patch 6.
    * Add Marcel's R-Bs.

v2 -> v3:
    * Address some 32 bit host compilation issues.

v3 -> v4:
    * Per suggestion from Markus rebase HMP report on
      object_child_foreach_recursive().
    * Strip off David's r-b from HMP patch (#4) because of the above.

v4 -> v5:
    * Accept comments from Marcus and David
        * Rename RDMA device interface
        * Split patch #4 into 2 patches
        * Add some more counters
    * Add Marcus and David ack-by to hmp patch

Yuval Shaia (10):
  hw/rdma: Switch to generic error reporting way
  hw/rdma: Introduce protected qlist
  hw/rdma: Protect against concurrent execution of poll_cq
  hw/pvrdma: Collect debugging statistics
  {hmp, hw/pvrdma}: Expose device internals via monitor interface
  hw/rdma: Free all MAD receive buffers when device is closed
  hw/rdma: Free all receive buffers when QP is destroyed
  hw/pvrdma: Delete unneeded function argument
  hw/pvrdma: Delete pvrdma_exit function
  hw/pvrdma: Unregister from shutdown notifier when device goes down

 hmp-commands-info.hx          |  14 +
 hmp.c                         |  27 ++
 hmp.h                         |   1 +
 hw/rdma/Makefile.objs         |   2 +-
 hw/rdma/rdma.c                |  30 +++
 hw/rdma/rdma_backend.c        | 483 +++++++++++++++++-----------------
 hw/rdma/rdma_backend.h        |   3 +-
 hw/rdma/rdma_backend_defs.h   |  10 +-
 hw/rdma/rdma_rm.c             | 193 ++++++++------
 hw/rdma/rdma_rm.h             |   7 +-
 hw/rdma/rdma_rm_defs.h        |  28 +-
 hw/rdma/rdma_utils.c          |  83 +++++-
 hw/rdma/rdma_utils.h          |  61 ++---
 hw/rdma/trace-events          |  32 ++-
 hw/rdma/vmw/pvrdma.h          |  12 +-
 hw/rdma/vmw/pvrdma_cmd.c      | 115 +++-----
 hw/rdma/vmw/pvrdma_dev_ring.c |  26 +-
 hw/rdma/vmw/pvrdma_main.c     | 168 ++++++------
 hw/rdma/vmw/pvrdma_qp_ops.c   |  52 +---
 hw/rdma/vmw/trace-events      |  16 +-
 include/hw/rdma/rdma.h        |  40 +++
 21 files changed, 796 insertions(+), 607 deletions(-)
 create mode 100644 hw/rdma/rdma.c
 create mode 100644 include/hw/rdma/rdma.h

-- 
2.17.2

             reply	other threads:[~2019-03-10  8:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-10  8:46 Yuval Shaia [this message]
2019-03-10  8:46 ` [Qemu-devel] [PATCH v5 01/10] hw/rdma: Switch to generic error reporting way Yuval Shaia
2019-03-10  8:46 ` [Qemu-devel] [PATCH v5 02/10] hw/rdma: Introduce protected qlist Yuval Shaia
2019-03-10  8:46 ` [Qemu-devel] [PATCH v5 03/10] hw/rdma: Protect against concurrent execution of poll_cq Yuval Shaia
2019-03-10  8:46 ` [Qemu-devel] [PATCH v5 04/10] hw/pvrdma: Collect debugging statistics Yuval Shaia
2019-03-10  8:46 ` [Qemu-devel] [PATCH v5 05/10] {hmp, hw/pvrdma}: Expose device internals via monitor interface Yuval Shaia
2019-03-10  8:46 ` [Qemu-devel] [PATCH v5 06/10] hw/rdma: Free all MAD receive buffers when device is closed Yuval Shaia
2019-03-10  8:46 ` [Qemu-devel] [PATCH v5 07/10] hw/rdma: Free all receive buffers when QP is destroyed Yuval Shaia
2020-03-23 10:30   ` Peter Maydell
2020-03-24  9:56     ` Yuval Shaia
2020-03-24 10:04       ` Yuval Shaia
2019-03-10  8:46 ` [Qemu-devel] [PATCH v5 08/10] hw/pvrdma: Delete unneeded function argument Yuval Shaia
2019-03-10  8:46 ` [Qemu-devel] [PATCH v5 09/10] hw/pvrdma: Delete pvrdma_exit function Yuval Shaia
2019-03-10  8:46 ` [Qemu-devel] [PATCH v5 10/10] hw/pvrdma: Unregister from shutdown notifier when device goes down Yuval Shaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190310084610.23077-1-yuval.shaia@oracle.com \
    --to=yuval.shaia@oracle.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).