From: Li Qiang <liq3ea@163.com>
To: pbonzini@redhat.com, e.emanuelegiuseppe@gmail.com
Cc: qemu-devel@nongnu.org, liq3ea@gmail.com, Li Qiang <liq3ea@163.com>
Subject: [Qemu-devel] [PATCH] tests: test-qgraph: fix a memory leak
Date: Sun, 10 Mar 2019 09:02:27 -0700 [thread overview]
Message-ID: <20190310160227.103090-1-liq3ea@163.com> (raw)
Spotted by ASAN when 'make check'.
Signed-off-by: Li Qiang <liq3ea@163.com>
---
tests/test-qgraph.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/test-qgraph.c b/tests/test-qgraph.c
index f6a6565e31..5c7e457075 100644
--- a/tests/test-qgraph.c
+++ b/tests/test-qgraph.c
@@ -122,7 +122,7 @@ static void check_driver(const char *driver)
static void check_test(const char *test, const char *interface)
{
QOSGraphEdge *edge;
- const char *full_name = g_strdup_printf("%s-tests/%s", interface, test);
+ char *full_name = g_strdup_printf("%s-tests/%s", interface, test);
qos_add_test(test, interface, testfunct, NULL);
g_assert_cmpint(qos_graph_has_machine(test), ==, FALSE);
@@ -138,6 +138,7 @@ static void check_test(const char *test, const char *interface)
g_assert_cmpint(qos_graph_get_node_availability(full_name), ==, TRUE);
qos_graph_node_set_availability(full_name, FALSE);
g_assert_cmpint(qos_graph_get_node_availability(full_name), ==, FALSE);
+ g_free(full_name);
}
static void count_each_test(QOSGraphNode *path, int len)
--
2.17.1
next reply other threads:[~2019-03-10 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 16:02 Li Qiang [this message]
2019-03-11 8:48 ` [Qemu-devel] [PATCH] tests: test-qgraph: fix a memory leak Thomas Huth
2019-03-11 10:09 ` Philippe Mathieu-Daudé
2019-03-11 15:33 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190310160227.103090-1-liq3ea@163.com \
--to=liq3ea@163.com \
--cc=e.emanuelegiuseppe@gmail.com \
--cc=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).