From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Laszlo Ersek" <lersek@redhat.com>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
"Michal Prívozník" <mprivozn@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PATCH 2/5] roms/edk2: Avoid bashism in script
Date: Mon, 11 Mar 2019 01:30:49 +0100 [thread overview]
Message-ID: <20190311003052.13778-3-philmd@redhat.com> (raw)
In-Reply-To: <20190311003052.13778-1-philmd@redhat.com>
Use the POSIX '=' to evaluate equality.
This fixes building the roms with a dash shell:
$ make -C roms efi
[...]
cp edk2/Build/ArmVirtQemu-ARM/DEBUG_GCC5/FV/QEMU_EFI.fd \
../pc-bios/edk2-arm-code.fd
truncate --size=64M ../pc-bios/edk2-arm-code.fd
/bin/sh: 111: [: i686: unexpected operator
/bin/sh: 112: [: i686: unexpected operator
/bin/sh: 116: [: i686: unexpected operator
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
roms/edk2-funcs.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/roms/edk2-funcs.sh b/roms/edk2-funcs.sh
index 7fc62f074c..402fc126fb 100644
--- a/roms/edk2-funcs.sh
+++ b/roms/edk2-funcs.sh
@@ -108,8 +108,8 @@ qemu_edk2_get_cross_prefix()
host_arch=$(uname -m)
- if [ "$gcc_arch" == "$host_arch" ] ||
- ( [ "$gcc_arch" == i686 ] && [ "$host_arch" == x86_64 ] ); then
+ if [ "$gcc_arch" = "$host_arch" ] ||
+ ( [ "$gcc_arch" = i686 ] && [ "$host_arch" = x86_64 ] ); then
# no cross-compiler needed
:
else
--
2.20.1
next prev parent reply other threads:[~2019-03-11 0:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 0:30 [Qemu-devel] [PATCH 0/5] travis-ci: Build EDK2 roms Philippe Mathieu-Daudé
2019-03-11 0:30 ` [Qemu-devel] [PATCH 1/5] roms/edk2: Avoid bashism in Makefile 'shell' function Philippe Mathieu-Daudé
2019-03-11 0:30 ` Philippe Mathieu-Daudé [this message]
2019-03-11 0:30 ` [Qemu-devel] [PATCH 3/5] roms/edk2: Pass extra arguments to the build script via EDK2_BUILD_OPTIONS Philippe Mathieu-Daudé
2019-03-11 0:30 ` [Qemu-devel] [PATCH 4/5] NOTFORMERGE roms/edk2: Use arm-linux-gnueabihf-gcc on Debian based distribs Philippe Mathieu-Daudé
2019-03-11 0:30 ` [Qemu-devel] [PATCH 5/5] .travis.yml: Build and install EDK2 roms Philippe Mathieu-Daudé
[not found] ` <ecd8aaf1-f75e-abd0-48b1-e80a227f01c3@redhat.com>
2019-06-13 16:59 ` Philippe Mathieu-Daudé
2019-06-14 18:31 ` Laszlo Ersek
2019-06-14 18:44 ` Alex Bennée
2019-09-21 9:14 ` Philippe Mathieu-Daudé
2019-06-14 18:32 ` [Qemu-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311003052.13778-3-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=mprivozn@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).