From: Helge Deller <deller@gmx.de>
To: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: [Qemu-devel] [PATCH] pcnet: Avoid warning when switching back to 16bit mode
Date: Mon, 11 Mar 2019 08:47:52 +0100 [thread overview]
Message-ID: <20190311074752.GA17747@ls3530.dellerweb.de> (raw)
When Linux is shutting down, the pcnet32 driver switches the pcnet card
back to 16bit mode to "avoid problems with dumb DOS packet driver after
a warm reboot".
This triggers the following warning in the qemu pcnet32 emulation:
Bad SWSTYLE=0x04
Avoid this qemu warning by allowing the switch-back to 16bit mode.
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
index d9ba04bdfc..14eb2fa1b0 100644
--- a/hw/net/pcnet.c
+++ b/hw/net/pcnet.c
@@ -1496,8 +1496,9 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap, uint32_t val)
case 1:
val |= 0x0100;
break;
- case 2:
+ case 2: /* 32bit mode */
case 3:
+ case 4: /* 16bit mode */
val |= 0x0300;
break;
default:
next reply other threads:[~2019-03-11 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 7:47 Helge Deller [this message]
2019-03-11 10:11 ` [Qemu-devel] [PATCH] pcnet: Avoid warning when switching back to 16bit mode Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311074752.GA17747@ls3530.dellerweb.de \
--to=deller@gmx.de \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).