From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3I9r-0005rF-Oe for qemu-devel@nongnu.org; Mon, 11 Mar 2019 06:27:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3I6Q-0006Cn-LZ for qemu-devel@nongnu.org; Mon, 11 Mar 2019 06:24:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39120) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3I6Q-0006CY-C5 for qemu-devel@nongnu.org; Mon, 11 Mar 2019 06:24:14 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6DCDC308219F for ; Mon, 11 Mar 2019 10:24:13 +0000 (UTC) Date: Mon, 11 Mar 2019 10:23:59 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20190311102359.GL12393@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20190309004826.9027-1-lersek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal =?utf-8?B?UHLDrXZvem7DrWs=?= Cc: Laszlo Ersek , imammedo@redhat.com, kraxel@redhat.com, mst@redhat.com, philmd@redhat.com, qemu-devel@nongnu.org On Sat, Mar 09, 2019 at 02:10:17PM +0100, Michal Pr=C3=ADvozn=C3=ADk wrot= e: > On 3/9/19 1:48 AM, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/qemu.git > > Branch: edk2_build > >=20 > > This series advances the roms/edk2 submodule to the "edk2-stable20190= 3" > > release, and builds and captures platform firmware binaries from that > > release. At this point they are meant to be used by both end-users an= d > > by Igor's ACPI unit tests in qtest ("make check"). > >=20 > > Previous discussion: > >=20 > > [Qemu-devel] bundling edk2 platform firmware images with QEMU > > http://mid.mail-archive.com/80f0bae3-e79a-bb68-04c4-1c9c684d95b8@re= dhat.com > > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02601.html > >=20 > > Note that the series was formatted with "--no-binary" (affecting patc= h > > #8), therefore it cannot be applied with "git-am". See the remote > > repo/branch reference near the top instead. > >=20 > > Thanks, > > Laszlo > >=20 > > Laszlo Ersek (10): > > roms: lift "edk2-funcs.sh" from "tests/uefi-test-tools/build.sh" > > roms/edk2-funcs.sh: require gcc-4.8+ for building i386 and x86_64 > > tests/uefi-test-tools/build.sh: work around TianoCore#1607 > > roms/edk2: advance to tag edk2-stable201903 > > roms/edk2-funcs.sh: add the qemu_edk2_get_thread_count() function > > roms/Makefile: replace the $(EFIROM) target with "edk2-basetools" > > roms: build edk2 firmware binaries and variable store templates > > pc-bios: add edk2 firmware binaries and variable store templates > > pc-bios: document the edk2 firmware images; add firmware descriptor= s > > Makefile: install the edk2 firmware images and their descriptors > >=20 > > Makefile | 17 +- > > pc-bios/README | 11 + > > pc-bios/descriptors/50-edk2-i386-secure.json | 34 +++ > > pc-bios/descriptors/50-edk2-x86_64-secure.json | 35 +++ > > pc-bios/descriptors/60-edk2-aarch64.json | 31 +++ > > pc-bios/descriptors/60-edk2-arm.json | 31 +++ > > pc-bios/descriptors/60-edk2-i386.json | 33 +++ > > pc-bios/descriptors/60-edk2-x86_64.json | 34 +++ > > pc-bios/edk2-aarch64-code.fd | Bin 0 -> 67108864 b= ytes > > pc-bios/edk2-arm-code.fd | Bin 0 -> 67108864 b= ytes > > pc-bios/edk2-arm-vars.fd | Bin 0 -> 67108864 b= ytes > > pc-bios/edk2-i386-code.fd | Bin 0 -> 3653632 by= tes > > pc-bios/edk2-i386-secure-code.fd | Bin 0 -> 3653632 by= tes > > pc-bios/edk2-i386-vars.fd | Bin 0 -> 540672 byt= es > > pc-bios/edk2-licenses.txt | 209 +++++++++++++++= + > > pc-bios/edk2-x86_64-code.fd | Bin 0 -> 3653632 by= tes > > pc-bios/edk2-x86_64-secure-code.fd | Bin 0 -> 3653632 by= tes > > roms/Makefile | 9 +- > > roms/Makefile.edk2 | 138 +++++++++++ > > roms/edk2 | 2 +- > > roms/edk2-build.sh | 55 +++++ > > roms/edk2-funcs.sh | 253 +++++++++++++++= +++++ > > tests/uefi-test-tools/build.sh | 100 +------- > > 23 files changed, 897 insertions(+), 95 deletions(-) > > create mode 100644 pc-bios/descriptors/50-edk2-i386-secure.json > > create mode 100644 pc-bios/descriptors/50-edk2-x86_64-secure.json > > create mode 100644 pc-bios/descriptors/60-edk2-aarch64.json > > create mode 100644 pc-bios/descriptors/60-edk2-arm.json > > create mode 100644 pc-bios/descriptors/60-edk2-i386.json > > create mode 100644 pc-bios/descriptors/60-edk2-x86_64.json > > create mode 100644 pc-bios/edk2-aarch64-code.fd > > create mode 100644 pc-bios/edk2-arm-code.fd > > create mode 100644 pc-bios/edk2-arm-vars.fd > > create mode 100644 pc-bios/edk2-i386-code.fd > > create mode 100644 pc-bios/edk2-i386-secure-code.fd > > create mode 100644 pc-bios/edk2-i386-vars.fd > > create mode 100644 pc-bios/edk2-licenses.txt > > create mode 100644 pc-bios/edk2-x86_64-code.fd > > create mode 100644 pc-bios/edk2-x86_64-secure-code.fd > > create mode 100644 roms/Makefile.edk2 > > create mode 100755 roms/edk2-build.sh > > create mode 100644 roms/edk2-funcs.sh > >=20 >=20 > Unsure whether my ACK is worth anything on this list, but you have it. > > Reviewed-by: Michal Privoznik Anyone on the QEMU mailing list is welcome, and indeed encouraged to review patches & add R-b acks if they feel comfortable with the code they are looking at. As with most projects, QEMU suffers from a not having enough reviewers to look at the volume of patches sent.... Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|