qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Unai Martinez-Corral <unai.martinezcorral@ehu.eus>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, riku.voipio@iki.fi, eblake@redhat.com
Subject: [Qemu-devel] [PATCH v4 5/10] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options
Date: Mon, 11 Mar 2019 10:28:41 +0000	[thread overview]
Message-ID: <20190311102841.GD16@765644dd90e5> (raw)
In-Reply-To: <20190311101428.GA11@765644dd90e5>

This breaks backward compatibility.

Options 'qemu-path' and 'qemu-suffix' have the 'qemu-' prefix, which is
not present in other option names ('debian', 'systemd', 'persistent',
'credential'...). In order to keep consistency, the prefix is removed.

Signed-off-by: Unai Martinez-Corral <unai.martinezcorral@ehu.eus>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
 scripts/qemu-binfmt-conf.sh | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
index 489d7d2326..0918f7fba6 100755
--- a/scripts/qemu-binfmt-conf.sh
+++ b/scripts/qemu-binfmt-conf.sh
@@ -167,6 +167,7 @@ qemu_get_family() {

 usage() {
     cat <<EOF
+
 Usage: qemu-binfmt-conf.sh [options]

 Configure binfmt_misc to use qemu interpreter
@@ -175,8 +176,8 @@ Options and associated environment variables:

 Argument             Env-variable     Description
 -h|--help                             display this usage
--Q|--qemu-path PATH: QEMU_PATH        set path to qemu interpreter
--F|--qemu-suffix SUFFIX:              add a suffix to the default interpreter name
+-Q|--path PATH:      QEMU_PATH        set path to qemu interpreter(s)
+-F|--suffix SUFFIX:                   add a suffix to the default interpreter name
 -d|--debian:                          don't write into /proc, generate update-binfmts templates
 -s|--systemd CPU:                     don't write into /proc, generate file for
                                       systemd-binfmt.service for the given CPU; if CPU is "ALL",
@@ -324,7 +325,7 @@ QEMU_PERSISTENT="${QEMU_PERSISTENT:-no}"

 QEMU_SUFFIX=""

-options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@")
+options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@")
 eval set -- "$options"

 while true ; do
@@ -356,11 +357,11 @@ while true ; do
             fi
         fi
         ;;
-    -Q|--qemu-path)
+    -Q|--path)
         shift
         QEMU_PATH="$1"
         ;;
-    -F|--qemu-suffix)
+    -F|--suffix)
         shift
         QEMU_SUFFIX="$1"
         ;;
--
2.21.0

  parent reply	other threads:[~2019-03-11 10:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 10:14 [Qemu-devel] [PATCH v4 0/10] qemu-binfmt-conf.sh Unai Martinez-Corral
2019-03-11 10:22 ` [Qemu-devel] [PATCH v4 1/10] qemu-binfmt-conf.sh: enforce safe style consistency Unai Martinez-Corral
2019-03-11 10:25 ` [Qemu-devel] [PATCH v4 2/10] qemu-binfmt-conf.sh: make opts -p and -c boolean Unai Martinez-Corral
2019-03-11 10:26 ` [Qemu-devel] [PATCH v4 3/10] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT Unai Martinez-Corral
2019-03-11 10:40   ` Laurent Vivier
2019-03-11 10:27 ` [Qemu-devel] [PATCH v4 4/10] qemu-binfmt-conf.sh: use the same presentation format as for qemu-* Unai Martinez-Corral
2019-03-11 11:22   ` Laurent Vivier
2019-03-11 10:28 ` Unai Martinez-Corral [this message]
2019-03-11 10:29 ` [Qemu-devel] [PATCH v4 6/10] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX Unai Martinez-Corral
2019-03-11 11:23   ` Laurent Vivier
2019-03-11 10:30 ` [Qemu-devel] [PATCH v4 7/10] qemu-binfmt-conf.sh: generalize CPU to positional TARGETS Unai Martinez-Corral
2019-03-11 11:14   ` Laurent Vivier
2019-03-11 13:29     ` Unai Martinez Corral
2019-03-11 13:36       ` Laurent Vivier
2019-03-11 19:23         ` Unai Martinez Corral
2019-03-11 19:26           ` Laurent Vivier
2019-03-11 10:31 ` [Qemu-devel] [PATCH v4 8/10] qemu-binfmt-conf.sh: add option --clear Unai Martinez-Corral
2019-03-11 11:04   ` Laurent Vivier
2019-03-11 13:19     ` Unai Martinez Corral
2019-03-11 13:30       ` Laurent Vivier
2019-03-11 10:31 ` [Qemu-devel] [PATCH v4 9/10] qemu-binfmt-conf.sh: update usage() Unai Martinez-Corral
2019-03-11 10:32 ` [Qemu-devel] [PATCH v4 10/10] qemu-binfmt-conf.sh: add --test|--dry-run Unai Martinez-Corral
2019-03-11 10:45   ` Laurent Vivier
2019-03-11 13:04     ` Unai Martinez Corral
2019-03-11 11:00 ` [Qemu-devel] [PATCH v4 0/10] qemu-binfmt-conf.sh no-reply
2019-03-11 11:30 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190311102841.GD16@765644dd90e5 \
    --to=unai.martinezcorral@ehu.eus \
    --cc=eblake@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).