From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:45576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3RPR-0003Iq-K2 for qemu-devel@nongnu.org; Mon, 11 Mar 2019 16:20:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3RNn-0000bf-J5 for qemu-devel@nongnu.org; Mon, 11 Mar 2019 16:18:48 -0400 Received: from smtp.lg.ehu.es ([158.227.0.66]:26109 helo=smtp.ehu.eus) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3RNn-0000Y1-8e for qemu-devel@nongnu.org; Mon, 11 Mar 2019 16:18:47 -0400 Date: Mon, 11 Mar 2019 20:18:48 +0000 From: Unai Martinez-Corral Message-ID: <20190311201848.GB9@59ca1d9b7985> References: <20190311201532.GA6@59ca1d9b7985> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190311201532.GA6@59ca1d9b7985> Subject: [Qemu-devel] [PATCH v5 2/9] qemu-binfmt-conf.sh: make opts -p and -c boolean List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: laurent@vivier.eu, riku.voipio@iki.fi, eblake@redhat.com This patch breaks backward compatibility. Both '--persistent' and '--credential' default to 'no'. Hence, '-p no' or '-c no' are reduntant. Overall, accepting an argument might be misleading because options are, indeed, boolean. This patch makes both options boolean in getopt, so if any of them is provided the corresponding variable is set to true. Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 0009385be2..ca15ff8092 100755 --- a/scripts/qemu-binfmt-conf.sh +++ b/scripts/qemu-binfmt-conf.sh @@ -168,8 +168,8 @@ qemu_get_family() { usage() { cat <