From: Stefan Hajnoczi <stefanha@gmail.com>
To: n.alekseev2104@gmail.com
Cc: qemu-devel@nongnu.org, jusual@mail.ru, kwolf@redhat.com,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Add coroutine_fn to bdrv_check_co_entry
Date: Mon, 1 Apr 2019 10:15:21 +0100 [thread overview]
Message-ID: <20190401091521.GC643@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190331083917.32176-1-n.alekseev2104@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
On Sun, Mar 31, 2019 at 11:39:17AM +0300, n.alekseev2104@gmail.com wrote:
> From: nickaleks <n.alekseev2104@gmail.com>
Hi Nikita,
Thanks for the patch! Do you want to adjust your email From field
("nickaleks") so it matches your full name and Signed-off-by ("Nikita
Alekseev")?
Stefan
>
> bdrv_check_co_entry calls bdrv_co_check, which is a coroutine function.
> Thus, it also needs to be marked as a coroutine.
>
> Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index 0a93ee9ac8..776c43f177 100644
> --- a/block.c
> +++ b/block.c
> @@ -4121,7 +4121,7 @@ typedef struct CheckCo {
> int ret;
> } CheckCo;
>
> -static void bdrv_check_co_entry(void *opaque)
> +static void coroutine_fn bdrv_check_co_entry(void *opaque)
> {
> CheckCo *cco = opaque;
> cco->ret = bdrv_co_check(cco->bs, cco->res, cco->fix);
> --
> 2.21.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next parent reply other threads:[~2019-04-01 10:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190331083917.32176-1-n.alekseev2104@gmail.com>
2019-04-01 9:15 ` Stefan Hajnoczi [this message]
2019-04-01 11:31 ` [Qemu-devel] [PATCH] Add coroutine_fn to bdrv_check_co_entry Nikita
2019-04-01 9:30 n.alekseev2104
2019-04-03 12:05 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401091521.GC643@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=jusual@mail.ru \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=n.alekseev2104@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).