qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	qemu-s390x@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>
Subject: [Qemu-devel] [PATCH v3 3/5] configure: qemu-ga is only needed with softmmu targets
Date: Mon,  1 Apr 2019 16:12:20 +0200	[thread overview]
Message-ID: <20190401141222.30034-4-lvivier@redhat.com> (raw)
In-Reply-To: <20190401141222.30034-1-lvivier@redhat.com>

Remove it from the list of tools if --disable-system
and --disable-tools are used as we don't need it for
linux-user targets.

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
[lv: I also disable it with disable-tools, not only with disable-system]
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 configure | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 1c563a70276a..b627efede6cf 100755
--- a/configure
+++ b/configure
@@ -6083,7 +6083,9 @@ fi
 # Probe for guest agent support/options
 
 if [ "$guest_agent" != "no" ]; then
-  if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" -o "$mingw32" = "yes" ] ; then
+  if [ "$softmmu" = no -a "$want_tools" = no ] ; then
+      guest_agent=no
+  elif [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" -o "$mingw32" = "yes" ] ; then
       tools="qemu-ga $tools"
       guest_agent=yes
   elif [ "$guest_agent" != yes ]; then
-- 
2.20.1

  parent reply	other threads:[~2019-04-01 14:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 14:12 [Qemu-devel] [PATCH v3 0/5] build: cleanup in Makefile.objs Laurent Vivier
2019-04-01 14:12 ` [Qemu-devel] [PATCH v3 1/5] trace: only include trace-event-subdirs when they are needed Laurent Vivier
2019-04-01 14:12 ` [Qemu-devel] [PATCH v3 2/5] build: replace GENERATED_FILES by generated-files-y Laurent Vivier
2019-04-01 14:12 ` Laurent Vivier [this message]
2019-04-01 14:50   ` [Qemu-devel] [PATCH v3 3/5] configure: qemu-ga is only needed with softmmu targets Thomas Huth
2019-04-01 14:12 ` [Qemu-devel] [PATCH v3 4/5] build: chardev is only needed for " Laurent Vivier
2019-04-01 14:12 ` [Qemu-devel] [PATCH v3 5/5] build: don't build hardware objects with linux-user Laurent Vivier
2019-04-02  8:08 ` [Qemu-devel] [PATCH v3 0/5] build: cleanup in Makefile.objs Paolo Bonzini
2019-05-13 15:17   ` Laurent Vivier
2019-05-13 16:17     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190401141222.30034-4-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).