* [Qemu-devel] [PATCH] qapi/migration.json: Clean up for COLOStatus
@ 2019-04-02 8:55 Zhang Chen
2019-04-02 11:33 ` Markus Armbruster
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Chen @ 2019-04-02 8:55 UTC (permalink / raw)
To: Zhang Chen, Dr. David Alan Gilbert, Juan Quintela,
Markus Armbruster, Eric Blake, qemu-dev
Cc: Zhang Chen
From: Zhang Chen <chen.zhang@intel.com>
Address Markus's comments change the 'last_mode' to 'last-mode'.
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
---
qapi/migration.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index cfde29acf8..9217886c80 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1380,7 +1380,7 @@
# @mode: COLO running mode. If COLO is running, this field will return
# 'primary' or 'secondary'.
#
-# @last_mode: COLO last running mode. If COLO is running, this field
+# @last-mode: COLO last running mode. If COLO is running, this field
# will return same like mode field, after failover we can
# use this field to get last colo mode. (since 4.1)
#
@@ -1389,7 +1389,7 @@
# Since: 3.1
##
{ 'struct': 'COLOStatus',
- 'data': { 'mode': 'COLOMode', 'last_mode': 'COLOMode',
+ 'data': { 'mode': 'COLOMode', 'last-mode': 'COLOMode',
'reason': 'COLOExitReason' } }
##
--
2.17.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qapi/migration.json: Clean up for COLOStatus
2019-04-02 8:55 [Qemu-devel] [PATCH] qapi/migration.json: Clean up for COLOStatus Zhang Chen
@ 2019-04-02 11:33 ` Markus Armbruster
0 siblings, 0 replies; 2+ messages in thread
From: Markus Armbruster @ 2019-04-02 11:33 UTC (permalink / raw)
To: Zhang Chen
Cc: Zhang Chen, Dr. David Alan Gilbert, Juan Quintela,
Markus Armbruster, Eric Blake, qemu-dev
Zhang Chen <chen.zhang@intel.com > writes:
> From: Zhang Chen <chen.zhang@intel.com>
>
> Address Markus's comments change the 'last_mode' to 'last-mode'.
>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> ---
> qapi/migration.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index cfde29acf8..9217886c80 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1380,7 +1380,7 @@
> # @mode: COLO running mode. If COLO is running, this field will return
> # 'primary' or 'secondary'.
> #
> -# @last_mode: COLO last running mode. If COLO is running, this field
> +# @last-mode: COLO last running mode. If COLO is running, this field
> # will return same like mode field, after failover we can
> # use this field to get last colo mode. (since 4.1)
> #
> @@ -1389,7 +1389,7 @@
> # Since: 3.1
> ##
> { 'struct': 'COLOStatus',
> - 'data': { 'mode': 'COLOMode', 'last_mode': 'COLOMode',
> + 'data': { 'mode': 'COLOMode', 'last-mode': 'COLOMode',
> 'reason': 'COLOExitReason' } }
>
> ##
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Queued for 4.0 with the commit message tweaked to just
qapi/migration.json: Rename COLOStatus last_mode to last-mode
Hope that's okay. Thank you!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-02 11:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-02 8:55 [Qemu-devel] [PATCH] qapi/migration.json: Clean up for COLOStatus Zhang Chen
2019-04-02 11:33 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).