From: Kevin Wolf <kwolf@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH v2 for-4.0] tests/qemu-iotests/235: Allow fallback to tcg
Date: Tue, 2 Apr 2019 12:06:31 +0200 [thread overview]
Message-ID: <20190402100631.GC5352@localhost.localdomain> (raw)
In-Reply-To: <1553678622-17295-1-git-send-email-thuth@redhat.com>
Am 27.03.2019 um 10:23 hat Thomas Huth geschrieben:
> iotest 235 currently only works with KVM - this is bad for systems where
> it is not available, e.g. CI pipelines. The test also works when using
> "tcg" as accelerator, so we can simply add that to the list of accelerators,
> too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: Do not remove the test from the "quick" group, since there was no
> real consensus about that change. We should maybe introduce a "ci"
> group instead later where this test here won't get added (since it
> currently does not work with accel=qtest)
Thanks, applied to the block branch.
I think the real solution would be to do some debugging and make the
test work even with qtest. But for 4.0, your patch is fine.
Kevin
parent reply other threads:[~2019-04-02 10:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1553678622-17295-1-git-send-email-thuth@redhat.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402100631.GC5352@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).