From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 1/8] vl: Fix error location of positional arguments
Date: Tue, 2 Apr 2019 15:01:05 +0200 [thread overview]
Message-ID: <20190402130112.15142-2-armbru@redhat.com> (raw)
In-Reply-To: <20190402130112.15142-1-armbru@redhat.com>
We blame badness in positional arguments on the last option argument:
$ qemu-system-x86_64 -vnc :1 bad.img
qemu-system-x86_64: -vnc :1: Could not open 'foo': No such file or directory
I believe we've done this ever since we reported locations. Fix it to
qemu-system-x86_64: bad.img: Could not open 'bad.img': No such file or directory
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190318183312.4684-1-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
---
vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vl.c b/vl.c
index d61d5604e5..24572de0bd 100644
--- a/vl.c
+++ b/vl.c
@@ -3119,6 +3119,7 @@ int main(int argc, char **argv, char **envp)
if (optind >= argc)
break;
if (argv[optind][0] != '-') {
+ loc_set_cmdline(argv, optind, 1);
drive_add(IF_DEFAULT, 0, argv[optind++], HD_OPTS);
} else {
const QEMUOption *popt;
--
2.17.2
next prev parent reply other threads:[~2019-04-02 13:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 13:01 [Qemu-devel] [PULL 0/8] Miscellaneous patches for 2019-04-02 Markus Armbruster
2019-04-02 13:01 ` Markus Armbruster [this message]
2019-04-02 13:01 ` [Qemu-devel] [PULL 2/8] qapi/migration.json: Fix ColoStatus member last_mode's version Markus Armbruster
2019-04-02 13:01 ` [Qemu-devel] [PULL 3/8] qapi/migration.json: Rename COLOStatus last_mode to last-mode Markus Armbruster
2019-04-02 13:01 ` [Qemu-devel] [PULL 4/8] Revert "vl: Fix to create migration object before block backends again" Markus Armbruster
2019-04-02 13:01 ` [Qemu-devel] [PULL 5/8] Revert "migration: move only_migratable to MigrationState" Markus Armbruster
2019-04-02 13:01 ` [Qemu-devel] [PULL 6/8] migration: Support adding migration blockers earlier Markus Armbruster
2019-04-02 13:01 ` [Qemu-devel] [PULL 7/8] vl: Document dependencies hiding in global and compat props Markus Armbruster
2019-04-02 13:01 ` [Qemu-devel] [PULL 8/8] accel: Unbreak accelerator fallback Markus Armbruster
2019-04-02 13:56 ` [Qemu-devel] [PULL 0/8] Miscellaneous patches for 2019-04-02 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402130112.15142-2-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).