From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hByAj-0006u5-4k for qemu-devel@nongnu.org; Thu, 04 Apr 2019 04:56:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hByAh-0004gF-7E for qemu-devel@nongnu.org; Thu, 04 Apr 2019 04:56:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37940) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hByAf-0004d2-8b for qemu-devel@nongnu.org; Thu, 04 Apr 2019 04:56:30 -0400 Date: Thu, 4 Apr 2019 09:56:21 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20190404085621.GD10471@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20190403124948.GA14129@ls3530.dellerweb.de> <20190403161729.GW25150@redhat.com> <43102ef9-2f96-2863-00aa-b6f2906c2f4f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <43102ef9-2f96-2863-00aa-b6f2906c2f4f@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] configure: Relax check for libseccomp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Peter Maydell , Helge Deller , Richard Henderson , QEMU Developers On Thu, Apr 04, 2019 at 08:59:14AM +0200, Thomas Huth wrote: > On 04/04/2019 03.53, Peter Maydell wrote: > > On Wed, 3 Apr 2019 at 23:27, Daniel P. Berrang=C3=A9 wrote: > >> > >> On Wed, Apr 03, 2019 at 02:49:48PM +0200, Helge Deller wrote: > >>> diff --git a/configure b/configure > >>> index 1c563a7027..8632267049 100755 > >>> --- a/configure > >>> +++ b/configure > >>> @@ -2389,7 +2389,6 @@ if test "$seccomp" !=3D "no" ; then > >>> libseccomp_minver=3D"2.3.0" > >>> ;; > >>> *) > >>> - libseccomp_minver=3D"" > >>> ;; > >>> esac > >> > >> This makes sense to me. From a QEMU source POV we are able to build = with > >> libseccomp >=3D 2.2.0, which our default libseccomp_minver=3D env ex= presses > >> a few lines earlier. > >> > >> If libseccomp isn't supported on a platform, then I think we should = just > >> assume that libseccomp won't be present in the OS install we are bui= lding > >> against. I don't think QEMU needs to second-guess whether or not it = is > >> supported on the given architecture. > >=20 > > If we want to do this then we should handle all the archs which > > don't need to special case the seccomp version identically, ie > > remove the x86/mips case which with this patch would be the > > same as the default case. > >=20 > >> In fact I'd go as far as to say we > >> could probably just remove all this per-arch checking and just have = a > >> generic >=3D 2.2.0 check, and just rely on fact libseccomp won't exi= st > >> on a s390/ppc/etc host if the distro had version < 2.3.0 > >=20 > > The arm case at least is present because libseccomp 2.2.0 was > > being built but didn't actually work for us. See commit ae6e8ef11e6cb= 43ec83. >=20 > Looking at https://repology.org/project/libseccomp/versions it seems > like all major distro versions that we want to support feature at least > version 2.3.0 ... so I think we can simplify the check here for all > architectures and only test for a version >=3D 2.3.0. That sounds good to me. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|