From: Wei Yang <richardw.yang@linux.intel.com> To: qemu-devel@nongnu.org Cc: ehabkost@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com, armbru@redhat.com Subject: [Qemu-devel] [PATCH v2 3/4] vl: Clean up after previous commit Date: Fri, 5 Apr 2019 14:41:20 +0800 [thread overview] Message-ID: <20190405064121.23662-4-richardw.yang@linux.intel.com> (raw) In-Reply-To: <20190405064121.23662-1-richardw.yang@linux.intel.com> From: Markus Armbruster <armbru@redhat.com> Since the previous commit, find_machine() and find_default_machine() don't have to deallocate on return. This permits further simplifications. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Wei Yang <richardw.yang@linux.intel.com> --- vl.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/vl.c b/vl.c index cf08d96ce4..99f9cb2533 100644 --- a/vl.c +++ b/vl.c @@ -1421,40 +1421,31 @@ MachineState *current_machine; static MachineClass *find_machine(const char *name, GSList *machines) { GSList *el; - MachineClass *mc = NULL; for (el = machines; el; el = el->next) { - MachineClass *temp = el->data; + MachineClass *mc = el->data; - if (!strcmp(temp->name, name)) { - mc = temp; - break; - } - if (temp->alias && - !strcmp(temp->alias, name)) { - mc = temp; - break; + if (!strcmp(mc->name, name) || !g_strcmp0(mc->alias, name)) { + return mc; } } - return mc; + return NULL; } static MachineClass *find_default_machine(GSList *machines) { GSList *el; - MachineClass *mc = NULL; for (el = machines; el; el = el->next) { - MachineClass *temp = el->data; + MachineClass *mc = el->data; - if (temp->is_default) { - mc = temp; - break; + if (mc->is_default) { + return mc; } } - return mc; + return NULL; } MachineInfoList *qmp_query_machines(Error **errp) -- 2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: Wei Yang <richardw.yang@linux.intel.com> To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, ehabkost@redhat.com, armbru@redhat.com Subject: [Qemu-devel] [PATCH v2 3/4] vl: Clean up after previous commit Date: Fri, 5 Apr 2019 14:41:20 +0800 [thread overview] Message-ID: <20190405064121.23662-4-richardw.yang@linux.intel.com> (raw) Message-ID: <20190405064120.w5eryYNfZPfxW03WuWpxlwpRiTpjmh298WpYALc7ugE@z> (raw) In-Reply-To: <20190405064121.23662-1-richardw.yang@linux.intel.com> From: Markus Armbruster <armbru@redhat.com> Since the previous commit, find_machine() and find_default_machine() don't have to deallocate on return. This permits further simplifications. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Wei Yang <richardw.yang@linux.intel.com> --- vl.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/vl.c b/vl.c index cf08d96ce4..99f9cb2533 100644 --- a/vl.c +++ b/vl.c @@ -1421,40 +1421,31 @@ MachineState *current_machine; static MachineClass *find_machine(const char *name, GSList *machines) { GSList *el; - MachineClass *mc = NULL; for (el = machines; el; el = el->next) { - MachineClass *temp = el->data; + MachineClass *mc = el->data; - if (!strcmp(temp->name, name)) { - mc = temp; - break; - } - if (temp->alias && - !strcmp(temp->alias, name)) { - mc = temp; - break; + if (!strcmp(mc->name, name) || !g_strcmp0(mc->alias, name)) { + return mc; } } - return mc; + return NULL; } static MachineClass *find_default_machine(GSList *machines) { GSList *el; - MachineClass *mc = NULL; for (el = machines; el; el = el->next) { - MachineClass *temp = el->data; + MachineClass *mc = el->data; - if (temp->is_default) { - mc = temp; - break; + if (mc->is_default) { + return mc; } } - return mc; + return NULL; } MachineInfoList *qmp_query_machines(Error **errp) -- 2.19.1
next prev parent reply other threads:[~2019-04-05 6:42 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-05 6:41 [Qemu-devel] [PATCH v2 0/4] cleanup select_machine Wei Yang 2019-04-05 6:41 ` Wei Yang 2019-04-05 6:41 ` [Qemu-devel] [PATCH v2 1/4] vl.c: make find_default_machine() local Wei Yang 2019-04-05 6:41 ` Wei Yang 2019-04-08 8:59 ` Markus Armbruster 2019-04-08 8:59 ` Markus Armbruster 2019-04-05 6:41 ` [Qemu-devel] [PATCH v2 2/4] vl.c: allocate TYPE_MACHINE list once during bootup Wei Yang 2019-04-05 6:41 ` Wei Yang 2019-04-05 6:41 ` Wei Yang [this message] 2019-04-05 6:41 ` [Qemu-devel] [PATCH v2 3/4] vl: Clean up after previous commit Wei Yang 2019-04-05 6:41 ` [Qemu-devel] [PATCH v2 4/4] vl: Simplify machine_parse() Wei Yang 2019-04-05 6:41 ` Wei Yang 2019-04-12 20:42 ` [Qemu-devel] [PATCH v2 0/4] cleanup select_machine Eduardo Habkost 2019-04-12 20:42 ` Eduardo Habkost
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190405064121.23662-4-richardw.yang@linux.intel.com \ --to=richardw.yang@linux.intel.com \ --cc=armbru@redhat.com \ --cc=ehabkost@redhat.com \ --cc=marcel.apfelbaum@gmail.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).