From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org,
qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash
Date: Fri, 5 Apr 2019 17:11:59 +0100 [thread overview]
Message-ID: <20190405161158.GA3275@work-vm> (raw)
In-Reply-To: <20190405125140.GB4597@linux.fritz.box>
* Kevin Wolf (kwolf@redhat.com) wrote:
> Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben:
> > drive_new() returns null without setting an error when it provided
> > help. add_init_drive() assumes null means failure, and crashes trying
> > to report a null error.
> >
> > Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25
> > Cc: qemu-stable@nongnu.org
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> We should probably have a test case for this.
Perhaps just adding:
drive_add 0 format=help
to the hmp_cmds list in tests/test-hmp.c ?
Dave
> Kevin
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, mreitz@redhat.com,
Markus Armbruster <armbru@redhat.com>,
qemu-block@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash
Date: Fri, 5 Apr 2019 17:11:59 +0100 [thread overview]
Message-ID: <20190405161158.GA3275@work-vm> (raw)
Message-ID: <20190405161159.eDIPnNjrHoBQHo6ou5GIA3_wiLvFwKyTeF5_Kxy9bGc@z> (raw)
In-Reply-To: <20190405125140.GB4597@linux.fritz.box>
* Kevin Wolf (kwolf@redhat.com) wrote:
> Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben:
> > drive_new() returns null without setting an error when it provided
> > help. add_init_drive() assumes null means failure, and crashes trying
> > to report a null error.
> >
> > Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25
> > Cc: qemu-stable@nongnu.org
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> We should probably have a test case for this.
Perhaps just adding:
drive_add 0 format=help
to the hmp_cmds list in tests/test-hmp.c ?
Dave
> Kevin
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-04-05 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 11:45 [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash Markus Armbruster
2019-04-05 11:45 ` Markus Armbruster
2019-04-05 12:51 ` Kevin Wolf
2019-04-05 12:51 ` Kevin Wolf
2019-04-05 16:11 ` Dr. David Alan Gilbert [this message]
2019-04-05 16:11 ` Dr. David Alan Gilbert
2019-04-05 16:24 ` Kevin Wolf
2019-04-05 16:24 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405161158.GA3275@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).