From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:51608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCRkw-0004Cq-OP for qemu-devel@nongnu.org; Fri, 05 Apr 2019 12:31:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCRkv-00016K-C3 for qemu-devel@nongnu.org; Fri, 05 Apr 2019 12:31:54 -0400 Date: Fri, 5 Apr 2019 18:24:27 +0200 From: Kevin Wolf Message-ID: <20190405162427.GC4597@linux.fritz.box> References: <20190405114513.3141-1-armbru@redhat.com> <20190405125140.GB4597@linux.fritz.box> <20190405161158.GA3275@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190405161158.GA3275@work-vm> Subject: Re: [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: Markus Armbruster , qemu-stable@nongnu.org, qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com Am 05.04.2019 um 18:11 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kwolf@redhat.com) wrote: > > Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben: > > > drive_new() returns null without setting an error when it provided > > > help. add_init_drive() assumes null means failure, and crashes trying > > > to report a null error. > > > > > > Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25 > > > Cc: qemu-stable@nongnu.org > > > Signed-off-by: Markus Armbruster > > > > We should probably have a test case for this. > > Perhaps just adding: > > drive_add 0 format=help > > to the hmp_cmds list in tests/test-hmp.c ? This would catch the crash, but not check the output. I think I'd prefer a qemu-iotests case where the output is checked. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6828AC282CE for ; Fri, 5 Apr 2019 16:33:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D75B2146F for ; Fri, 5 Apr 2019 16:33:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D75B2146F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:44449 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCRmS-0004zB-DH for qemu-devel@archiver.kernel.org; Fri, 05 Apr 2019 12:33:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCRkw-0004Cq-OP for qemu-devel@nongnu.org; Fri, 05 Apr 2019 12:31:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCRkv-00016K-C3 for qemu-devel@nongnu.org; Fri, 05 Apr 2019 12:31:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45764) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hCRkY-00087x-AY; Fri, 05 Apr 2019 12:31:48 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 87C0A89C45; Fri, 5 Apr 2019 16:24:30 +0000 (UTC) Received: from linux.fritz.box (ovpn-117-134.ams2.redhat.com [10.36.117.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 292CE60BFB; Fri, 5 Apr 2019 16:24:29 +0000 (UTC) Date: Fri, 5 Apr 2019 18:24:27 +0200 From: Kevin Wolf To: "Dr. David Alan Gilbert" Message-ID: <20190405162427.GC4597@linux.fritz.box> References: <20190405114513.3141-1-armbru@redhat.com> <20190405125140.GB4597@linux.fritz.box> <20190405161158.GA3275@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190405161158.GA3275@work-vm> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 05 Apr 2019 16:24:30 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, mreitz@redhat.com, Markus Armbruster , qemu-block@nongnu.org, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190405162427.tCRTXSWkLGAoJ5Ed_UBi-RnX7yYD3JTgYXIyXd6_NoE@z> Am 05.04.2019 um 18:11 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kwolf@redhat.com) wrote: > > Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben: > > > drive_new() returns null without setting an error when it provided > > > help. add_init_drive() assumes null means failure, and crashes trying > > > to report a null error. > > > > > > Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25 > > > Cc: qemu-stable@nongnu.org > > > Signed-off-by: Markus Armbruster > > > > We should probably have a test case for this. > > Perhaps just adding: > > drive_add 0 format=help > > to the hmp_cmds list in tests/test-hmp.c ? This would catch the crash, but not check the output. I think I'd prefer a qemu-iotests case where the output is checked. Kevin