[Qemu-devel] [PATCH 4/4] Header cleanups: Removed unwanted includes from cpu-common.h

[Qemu-devel] [PATCH 4/4] Header cleanups: Removed unwanted includes from cpu-common.h

[Aruna Jayasena]

Removed unwanted includes from cpu-common.h
This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks

Signed-off-by: Aruna Jayasena <aruna.15@cse.mrt.ac.lk>
---
 include/exec/cpu-common.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
index cef8b88a2a..a3594f3f50 100644
--- a/include/exec/cpu-common.h
+++ b/include/exec/cpu-common.h
@@ -7,8 +7,6 @@
 #include "exec/hwaddr.h"
 #endif
 
-#include "qemu/bswap.h"
-#include "qemu/queue.h"
 #include "qemu/fprintf-fn.h"
 
 /**
-- 
2.17.1

[Qemu-devel] [PATCH 4/4] Header cleanups: Removed unwanted includes from cpu-common.h

[Aruna Jayasena]

Removed unwanted includes from cpu-common.h
This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks

Signed-off-by: Aruna Jayasena <aruna.15@cse.mrt.ac.lk>
---
 include/exec/cpu-common.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
index cef8b88a2a..a3594f3f50 100644
--- a/include/exec/cpu-common.h
+++ b/include/exec/cpu-common.h
@@ -7,8 +7,6 @@
 #include "exec/hwaddr.h"
 #endif
 
-#include "qemu/bswap.h"
-#include "qemu/queue.h"
 #include "qemu/fprintf-fn.h"
 
 /**
-- 
2.17.1

Re: [Qemu-devel] [PATCH 4/4] Header cleanups: Removed unwanted includes from cpu-common.h

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1977 bytes --]

On Sat, Apr 06, 2019 at 09:34:22AM +0530, Aruna Jayasena wrote:
> Removed unwanted includes from cpu-common.h
> This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks
> 
> Signed-off-by: Aruna Jayasena <aruna.15@cse.mrt.ac.lk>
> ---
>  include/exec/cpu-common.h | 2 --
>  1 file changed, 2 deletions(-)

Hi Aruna,
I'd like to review and apply your patches.  It's a little difficult
to understand the structure since there are several email threads with
subject lines ("PATCH 4/4") that imply a relationship, but they were
sent on different dates.

The usual structure of the first patch submission is:

  [PATCH 0/4] qemu-common.h: clean up qemu-common.h
  +--- [PATCH 1/4] qemu-common.h: drop unused includes in util/
  +--- [PATCH 2/4] ...
  +--- [PATCH 3/4] ...
  +--- [PATCH 4/4] ...

Here PATCH 0 is a cover letter that describes the purpose of this patch
series.  The actual patches (1, 2, 3, and 4) are part of the email
thread started by the cover letter.  This relationship allows tools to
treat the emails as a single patch series and it makes it easier for
human reviewers to review your patches in their inbox.

If you send a new revision of the patch series to address code review
feedback:

  [PATCH v2 0/4] qemu-common.h: clean up qemu-common.h
  +--- [PATCH v2 1/4] qemu-common.h: drop unused includes in util/
  +--- [PATCH v2 2/4] ...
  +--- [PATCH v2 3/4] ...
  +--- [PATCH v2 4/4] ...

The "v2" revision number indicates that this series obsoletes the first
patch submission.

Please resend your patches and follow this structure.  You can use
git-send-email --thread --no-chain-reply-to master.. to send the patch
series.  Normally --thread and --no-chain-reply-to are defaults and you
don't have to specify them explicitly.

If you need help, feel free to ping me on IRC.  You may find it useful
to send the email to yourself as a test first before sending to
qemu-devel@nongnu.org.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PATCH 4/4] Header cleanups: Removed unwanted includes from cpu-common.h

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1977 bytes --]

On Sat, Apr 06, 2019 at 09:34:22AM +0530, Aruna Jayasena wrote:
> Removed unwanted includes from cpu-common.h
> This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks
> 
> Signed-off-by: Aruna Jayasena <aruna.15@cse.mrt.ac.lk>
> ---
>  include/exec/cpu-common.h | 2 --
>  1 file changed, 2 deletions(-)

Hi Aruna,
I'd like to review and apply your patches.  It's a little difficult
to understand the structure since there are several email threads with
subject lines ("PATCH 4/4") that imply a relationship, but they were
sent on different dates.

The usual structure of the first patch submission is:

  [PATCH 0/4] qemu-common.h: clean up qemu-common.h
  +--- [PATCH 1/4] qemu-common.h: drop unused includes in util/
  +--- [PATCH 2/4] ...
  +--- [PATCH 3/4] ...
  +--- [PATCH 4/4] ...

Here PATCH 0 is a cover letter that describes the purpose of this patch
series.  The actual patches (1, 2, 3, and 4) are part of the email
thread started by the cover letter.  This relationship allows tools to
treat the emails as a single patch series and it makes it easier for
human reviewers to review your patches in their inbox.

If you send a new revision of the patch series to address code review
feedback:

  [PATCH v2 0/4] qemu-common.h: clean up qemu-common.h
  +--- [PATCH v2 1/4] qemu-common.h: drop unused includes in util/
  +--- [PATCH v2 2/4] ...
  +--- [PATCH v2 3/4] ...
  +--- [PATCH v2 4/4] ...

The "v2" revision number indicates that this series obsoletes the first
patch submission.

Please resend your patches and follow this structure.  You can use
git-send-email --thread --no-chain-reply-to master.. to send the patch
series.  Normally --thread and --no-chain-reply-to are defaults and you
don't have to specify them explicitly.

If you need help, feel free to ping me on IRC.  You may find it useful
to send the email to yourself as a test first before sending to
qemu-devel@nongnu.org.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]