From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDPlY-00088t-Nw for qemu-devel@nongnu.org; Mon, 08 Apr 2019 04:36:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDPlX-0003cT-N6 for qemu-devel@nongnu.org; Mon, 08 Apr 2019 04:36:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33666) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDPlX-0003cA-EM for qemu-devel@nongnu.org; Mon, 08 Apr 2019 04:36:31 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ACD9030B932B for ; Mon, 8 Apr 2019 08:36:30 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 639DC5C297 for ; Mon, 8 Apr 2019 08:36:29 +0000 (UTC) From: Markus Armbruster Date: Mon, 8 Apr 2019 10:36:12 +0200 Message-Id: <20190408083627.7479-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 00/15] Clean up use of error_printf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This series cleans up two kinds of error_printf() misuse: * Errors and warnings should be reported with error_report() and warn_report(). * Help output should be go to stdout, not stderr. This is obviously for 4.1. If nobody objects, I'll take the whole series through my tree. Markus Armbruster (15): qemu-img: Use error_vreport() in error_exit() block/ssh: Do not report read/write/flush errors to the user char-pty: Drop "char device redirected to" message loader-fit: Wean off error_printf() mips/boston: Report errors with error_report(), not error_printf() pci: Report fatal errors with error_report(), not error_printf() hpet: Report warnings with warn_report(), not error_printf() vfio: Report warnings with warn_report(), not error_printf() s390x/kvm: Report warnings with warn_report(), not error_printf() vl: Make -machine $TYPE,help and -accel help print to stdout monitor error: Make printf()-like functions return a value qemu-print: New qemu_printf(), qemu_vprintf() etc. blockdev: Make -drive format=3Dhelp print to stdout char: Make -chardev help print to stdout monitor: Simplify how -device/device_add print help MAINTAINERS | 2 ++ block/ssh.c | 36 +++++++------------ block/trace-events | 3 ++ blockdev.c | 9 ++--- chardev/char-pty.c | 2 -- chardev/char.c | 3 +- hw/core/loader-fit.c | 62 +++++++++++++++++++-------------- hw/mips/boston.c | 6 ++-- hw/pci/pci.c | 2 +- hw/timer/hpet.c | 2 +- hw/vfio/pci.c | 19 ++++++---- include/monitor/monitor.h | 7 ++-- include/qemu/error-report.h | 8 ++--- include/qemu/qemu-print.h | 19 ++++++++++ monitor.c | 69 ++++++++++++++++++------------------- qdev-monitor.c | 36 ++++++++----------- qemu-img.c | 6 ++-- stubs/error-printf.c | 10 +++--- stubs/monitor.c | 5 +++ target/s390x/kvm.c | 2 +- util/Makefile.objs | 1 + util/qemu-error.c | 12 ++++--- util/qemu-print.c | 42 ++++++++++++++++++++++ vl.c | 10 +++--- 24 files changed, 219 insertions(+), 154 deletions(-) create mode 100644 include/qemu/qemu-print.h create mode 100644 util/qemu-print.c --=20 2.17.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50D8FC282CE for ; Mon, 8 Apr 2019 08:38:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2196C20880 for ; Mon, 8 Apr 2019 08:38:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2196C20880 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:49344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDPnK-0000vX-7b for qemu-devel@archiver.kernel.org; Mon, 08 Apr 2019 04:38:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDPlY-00088t-Nw for qemu-devel@nongnu.org; Mon, 08 Apr 2019 04:36:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDPlX-0003cT-N6 for qemu-devel@nongnu.org; Mon, 08 Apr 2019 04:36:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33666) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDPlX-0003cA-EM for qemu-devel@nongnu.org; Mon, 08 Apr 2019 04:36:31 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ACD9030B932B for ; Mon, 8 Apr 2019 08:36:30 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 639DC5C297 for ; Mon, 8 Apr 2019 08:36:29 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C98F71138648; Mon, 8 Apr 2019 10:36:27 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Mon, 8 Apr 2019 10:36:12 +0200 Message-Id: <20190408083627.7479-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Mon, 08 Apr 2019 08:36:30 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 00/15] Clean up use of error_printf() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190408083612.G9yH8h-BRDRUx0wkgMo_C9djMh9Loh3KVTIvahTIYIw@z> This series cleans up two kinds of error_printf() misuse: * Errors and warnings should be reported with error_report() and warn_report(). * Help output should be go to stdout, not stderr. This is obviously for 4.1. If nobody objects, I'll take the whole series through my tree. Markus Armbruster (15): qemu-img: Use error_vreport() in error_exit() block/ssh: Do not report read/write/flush errors to the user char-pty: Drop "char device redirected to" message loader-fit: Wean off error_printf() mips/boston: Report errors with error_report(), not error_printf() pci: Report fatal errors with error_report(), not error_printf() hpet: Report warnings with warn_report(), not error_printf() vfio: Report warnings with warn_report(), not error_printf() s390x/kvm: Report warnings with warn_report(), not error_printf() vl: Make -machine $TYPE,help and -accel help print to stdout monitor error: Make printf()-like functions return a value qemu-print: New qemu_printf(), qemu_vprintf() etc. blockdev: Make -drive format=3Dhelp print to stdout char: Make -chardev help print to stdout monitor: Simplify how -device/device_add print help MAINTAINERS | 2 ++ block/ssh.c | 36 +++++++------------ block/trace-events | 3 ++ blockdev.c | 9 ++--- chardev/char-pty.c | 2 -- chardev/char.c | 3 +- hw/core/loader-fit.c | 62 +++++++++++++++++++-------------- hw/mips/boston.c | 6 ++-- hw/pci/pci.c | 2 +- hw/timer/hpet.c | 2 +- hw/vfio/pci.c | 19 ++++++---- include/monitor/monitor.h | 7 ++-- include/qemu/error-report.h | 8 ++--- include/qemu/qemu-print.h | 19 ++++++++++ monitor.c | 69 ++++++++++++++++++------------------- qdev-monitor.c | 36 ++++++++----------- qemu-img.c | 6 ++-- stubs/error-printf.c | 10 +++--- stubs/monitor.c | 5 +++ target/s390x/kvm.c | 2 +- util/Makefile.objs | 1 + util/qemu-error.c | 12 ++++--- util/qemu-print.c | 42 ++++++++++++++++++++++ vl.c | 10 +++--- 24 files changed, 219 insertions(+), 154 deletions(-) create mode 100644 include/qemu/qemu-print.h create mode 100644 util/qemu-print.c --=20 2.17.2