qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 14/15] char: Make -chardev help print to stdout
Date: Mon,  8 Apr 2019 10:36:26 +0200	[thread overview]
Message-ID: <20190408083627.7479-15-armbru@redhat.com> (raw)
In-Reply-To: <20190408083627.7479-1-armbru@redhat.com>

Command line help explicitly requested by the user should be printed
to stdout, not stderr.  We do elsewhere.  Adjust -chardev to match:
use qemu_printf() instead of error_printf().  Plain printf() would be
wrong because we need to print to the current monitor for chardev-add
help".

Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 chardev/char.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/chardev/char.c b/chardev/char.c
index 514cd6b0c3..54724a56b1 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -28,6 +28,7 @@
 #include "sysemu/sysemu.h"
 #include "qemu/config-file.h"
 #include "qemu/error-report.h"
+#include "qemu/qemu-print.h"
 #include "chardev/char.h"
 #include "qapi/error.h"
 #include "qapi/qapi-commands-char.h"
@@ -651,7 +652,7 @@ Chardev *qemu_chr_new_from_opts(QemuOpts *opts, GMainContext *context,
 
         chardev_name_foreach(help_string_append, str);
 
-        error_printf("Available chardev backend types: %s\n", str->str);
+        qemu_printf("Available chardev backend types: %s\n", str->str);
         g_string_free(str, true);
         return NULL;
     }
-- 
2.17.2

  parent reply	other threads:[~2019-04-08  8:36 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08  8:36 [Qemu-devel] [PATCH 00/15] Clean up use of error_printf() Markus Armbruster
2019-04-08  8:36 ` Markus Armbruster
2019-04-08  8:36 ` [Qemu-devel] [PATCH 01/15] qemu-img: Use error_vreport() in error_exit() Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08 18:37   ` Eric Blake
2019-04-08 18:37     ` Eric Blake
2019-04-08  8:36 ` [Qemu-devel] [PATCH 02/15] block/ssh: Do not report read/write/flush errors to the user Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08 17:22   ` [Qemu-devel] Whither qemu's ssh driver? (was: Re: [PATCH 02/15] block/ssh: Do not report read/write/flush errors to the user) Richard W.M. Jones
2019-04-08 17:22     ` Richard W.M. Jones
2019-04-08 18:07     ` [Qemu-devel] Whither qemu's ssh driver? Markus Armbruster
2019-04-08 18:07       ` Markus Armbruster
2019-04-08 18:13       ` Richard W.M. Jones
2019-04-08 18:13         ` Richard W.M. Jones
2019-04-08 18:33     ` [Qemu-devel] Whither qemu's ssh driver? (was: Re: [PATCH 02/15] block/ssh: Do not report read/write/flush errors to the user) Max Reitz
2019-04-08 18:33       ` Max Reitz
2019-04-09  6:05       ` [Qemu-devel] Whither qemu's ssh driver? Markus Armbruster
2019-04-09  6:05         ` Markus Armbruster
2019-04-08 19:13   ` [Qemu-devel] [PATCH 02/15] block/ssh: Do not report read/write/flush errors to the user Eric Blake
2019-04-08 19:13     ` Eric Blake
2019-04-09  6:09     ` Markus Armbruster
2019-04-09  6:09       ` Markus Armbruster
2019-04-08  8:36 ` [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to" message Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08  9:20   ` Marc-André Lureau
2019-04-08  9:20     ` Marc-André Lureau
2019-04-08 12:31     ` Markus Armbruster
2019-04-08 12:31       ` Markus Armbruster
2019-04-09 10:40       ` Philippe Mathieu-Daudé
2019-04-09 10:40         ` Philippe Mathieu-Daudé
2019-04-09 11:25         ` Marc-André Lureau
2019-04-09 11:25           ` Marc-André Lureau
2019-04-11 11:47           ` Daniel P. Berrangé
2019-04-11 11:47             ` Daniel P. Berrangé
2019-04-08  8:36 ` [Qemu-devel] [PATCH 04/15] loader-fit: Wean off error_printf() Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08 10:49   ` Philippe Mathieu-Daudé
2019-04-08 10:49     ` Philippe Mathieu-Daudé
2019-04-08  8:36 ` [Qemu-devel] [PATCH 05/15] mips/boston: Report errors with error_report(), not error_printf() Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08 10:53   ` Philippe Mathieu-Daudé
2019-04-08 10:53     ` Philippe Mathieu-Daudé
2019-04-08  8:36 ` [Qemu-devel] [PATCH 06/15] pci: Report fatal " Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08  8:41   ` Marcel Apfelbaum
2019-04-08  8:41     ` Marcel Apfelbaum
2019-04-08  8:36 ` [Qemu-devel] [PATCH 07/15] hpet: Report warnings with warn_report(), " Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08  8:36 ` [Qemu-devel] [PATCH 08/15] vfio: " Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08  8:36 ` [Qemu-devel] [PATCH 09/15] s390x/kvm: " Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08  8:39   ` Thomas Huth
2019-04-08  8:39     ` Thomas Huth
2019-04-08  9:04     ` Cornelia Huck
2019-04-08  9:04       ` Cornelia Huck
2019-04-08 12:32       ` Markus Armbruster
2019-04-08 12:32         ` Markus Armbruster
2019-04-08  8:36 ` [Qemu-devel] [PATCH 10/15] vl: Make -machine $TYPE, help and -accel help print to stdout Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08  8:44   ` Marcel Apfelbaum
2019-04-08  8:44     ` Marcel Apfelbaum
2019-04-08 12:33     ` Markus Armbruster
2019-04-08 12:33       ` Markus Armbruster
2019-04-08  8:36 ` [Qemu-devel] [PATCH 11/15] monitor error: Make printf()-like functions return a value Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08 13:18   ` Markus Armbruster
2019-04-08 13:18     ` Markus Armbruster
2019-04-08 16:23     ` Dr. David Alan Gilbert
2019-04-08 16:23       ` Dr. David Alan Gilbert
2019-04-08  8:36 ` [Qemu-devel] [PATCH 12/15] qemu-print: New qemu_printf(), qemu_vprintf() etc Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08 11:00   ` Philippe Mathieu-Daudé
2019-04-08 11:00     ` Philippe Mathieu-Daudé
2019-04-09 18:00   ` Dr. David Alan Gilbert
2019-04-09 18:00     ` Dr. David Alan Gilbert
2019-04-10  5:08     ` Markus Armbruster
2019-04-10  5:08       ` Markus Armbruster
2019-04-08  8:36 ` [Qemu-devel] [PATCH 13/15] blockdev: Make -drive format=help print to stdout Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-08 11:01   ` Philippe Mathieu-Daudé
2019-04-08 11:01     ` Philippe Mathieu-Daudé
2019-04-08  8:36 ` Markus Armbruster [this message]
2019-04-08  8:36   ` [Qemu-devel] [PATCH 14/15] char: Make -chardev help " Markus Armbruster
2019-04-08  9:10   ` Marc-André Lureau
2019-04-08  9:10     ` Marc-André Lureau
2019-04-08 11:02   ` Philippe Mathieu-Daudé
2019-04-08 11:02     ` Philippe Mathieu-Daudé
2019-04-08 19:04   ` Eric Blake
2019-04-08 19:04     ` Eric Blake
2019-04-09  6:10     ` Markus Armbruster
2019-04-09  6:10       ` Markus Armbruster
2019-04-08  8:36 ` [Qemu-devel] [PATCH 15/15] monitor: Simplify how -device/device_add print help Markus Armbruster
2019-04-08  8:36   ` Markus Armbruster
2019-04-09 18:41   ` Dr. David Alan Gilbert
2019-04-09 18:41     ` Dr. David Alan Gilbert
2019-04-08 10:51 ` [Qemu-devel] [PATCH 00/15] Clean up use of error_printf() no-reply
2019-04-08 10:51   ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190408083627.7479-15-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).