From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Jafar Abdi <cafer.abdi@gmail.com>,
dgilbert@redhat.com
Subject: [Qemu-devel] [PULL 1/3] tests/libqos: fix usage of bool in pci-pc.c
Date: Mon, 8 Apr 2019 13:09:18 +0200 [thread overview]
Message-ID: <20190408110920.30119-2-thuth@redhat.com> (raw)
In-Reply-To: <20190408110920.30119-1-thuth@redhat.com>
From: Jafar Abdi <cafer.abdi@gmail.com>
Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
FALSE and TRUE (with capital letters) are the constants defined by glib for
being used with the "gboolean" type of glib. But some parts of the code also use
TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).
Signed-off-by: Jafar Abdi <cafer.abdi@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1553351197-14581-3-git-send-email-cafer.abdi@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/libqos/pci-pc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqos/pci-pc.c b/tests/libqos/pci-pc.c
index 4ab16facf2..407d8aff78 100644
--- a/tests/libqos/pci-pc.c
+++ b/tests/libqos/pci-pc.c
@@ -125,7 +125,7 @@ void qpci_init_pc(QPCIBusPC *qpci, QTestState *qts, QGuestAllocator *alloc)
assert(qts);
/* tests can use pci-bus */
- qpci->bus.has_buggy_msi = FALSE;
+ qpci->bus.has_buggy_msi = false;
qpci->bus.pio_readb = qpci_pc_pio_readb;
qpci->bus.pio_readw = qpci_pc_pio_readw;
--
2.21.0
next prev parent reply other threads:[~2019-04-08 11:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 11:09 [Qemu-devel] [PULL 0/3] Fixes for libqos Thomas Huth
2019-04-08 11:09 ` Thomas Huth
2019-04-08 11:09 ` Thomas Huth [this message]
2019-04-08 11:09 ` [Qemu-devel] [PULL 1/3] tests/libqos: fix usage of bool in pci-pc.c Thomas Huth
2019-04-08 11:09 ` [Qemu-devel] [PULL 2/3] tests/libqos: fix usage of bool in pci-spapr.c Thomas Huth
2019-04-08 11:09 ` Thomas Huth
2019-04-08 11:09 ` [Qemu-devel] [PULL 3/3] test qgraph.c: Fix segs due to out of scope default Thomas Huth
2019-04-08 11:09 ` Thomas Huth
2019-04-08 16:50 ` [Qemu-devel] [PULL 0/3] Fixes for libqos Peter Maydell
2019-04-08 16:50 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408110920.30119-2-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=cafer.abdi@gmail.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).