From: Igor Mammedov <imammedo@redhat.com>
To: Like Xu <like.xu@linux.intel.com>
Cc: qemu-trivial@nongnu.org, like.xu@intel.com,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties
Date: Mon, 8 Apr 2019 15:26:14 +0200 [thread overview]
Message-ID: <20190408152614.0bdf3cfd@redhat.com> (raw)
In-Reply-To: <7b902f2b-64b9-9c73-eeb0-1be33f1f2b07@linux.intel.com>
On Thu, 4 Apr 2019 11:26:09 +0800
Like Xu <like.xu@linux.intel.com> wrote:
> On 2019/3/29 18:21, Igor Mammedov wrote:
> > On Fri, 29 Mar 2019 16:48:36 +0800
> > Like Xu <like.xu@linux.intel.com> wrote:
> >
> >> This patch series make existing cores/threads/sockets into machine
> >> properties and get rid of global variables they use currently.
> > Thanks for looking into it!
> > Its long overdue and rather desired conversion (albeit naive one,
> > but this series is a good starting point). I'll go over your patches
> > next week with comments and concrete suggestions how to implement
> > particular things.
>
> Hi Igor, any comments and suggestions on smp machine properties
> in this patch considering we may add die topology for PCMachine as an
> extension?
I've looked at several patches and that it for this series.
The most comments apply to the patches I've not reviewed as well.
> >
> >> Like Xu (9):
> >> cpu/topology: add struct CpuTopology to MachineState
> >> cpu/topology: add general support for machine properties
> >> cpu/topology: add uncommon arch support for smp machine properties
> >> cpu/topology: add ARM support for smp machine properties
> >> cpu/topology: add i386 support for smp machine properties
> >> cpu/topology: add PPC support for smp machine properties
> >> cpu/topology: add riscv support for smp machine properties
> >> cpu/topology: add s390x support for smp machine properties
> >> cpu/topology: replace smp global variables with machine propertie
> >>
> >> accel/kvm/kvm-all.c | 3 +++
> >> backends/hostmem.c | 4 ++++
> >> cpus.c | 4 ++++
> >> exec.c | 2 ++
> >> gdbstub.c | 7 ++++++-
> >> hw/alpha/dp264.c | 1 +
> >> hw/arm/fsl-imx6.c | 5 +++++
> >> hw/arm/fsl-imx6ul.c | 5 +++++
> >> hw/arm/fsl-imx7.c | 5 +++++
> >> hw/arm/highbank.c | 1 +
> >> hw/arm/mcimx6ul-evk.c | 1 +
> >> hw/arm/mcimx7d-sabre.c | 3 +++
> >> hw/arm/raspi.c | 2 ++
> >> hw/arm/realview.c | 1 +
> >> hw/arm/sabrelite.c | 1 +
> >> hw/arm/vexpress.c | 3 +++
> >> hw/arm/virt.c | 7 +++++++
> >> hw/arm/xlnx-zynqmp.c | 7 +++++++
> >> hw/cpu/core.c | 3 +++
> >> hw/hppa/machine.c | 4 ++++
> >> hw/i386/acpi-build.c | 3 +++
> >> hw/i386/kvmvapic.c | 5 +++++
> >> hw/i386/pc.c | 12 +++++++++++
> >> hw/mips/boston.c | 1 +
> >> hw/mips/mips_malta.c | 9 +++++++++
> >> hw/openrisc/openrisc_sim.c | 1 +
> >> hw/ppc/e500.c | 3 +++
> >> hw/ppc/mac_newworld.c | 2 ++
> >> hw/ppc/mac_oldworld.c | 2 ++
> >> hw/ppc/pnv.c | 3 +++
> >> hw/ppc/prep.c | 2 ++
> >> hw/ppc/spapr.c | 29 ++++++++++++++++++++++++++
> >> hw/ppc/spapr_rtas.c | 3 +++
> >> hw/riscv/sifive_e.c | 4 ++++
> >> hw/riscv/sifive_plic.c | 3 +++
> >> hw/riscv/sifive_u.c | 4 ++++
> >> hw/riscv/spike.c | 2 ++
> >> hw/riscv/virt.c | 1 +
> >> hw/s390x/s390-virtio-ccw.c | 2 ++
> >> hw/s390x/sclp.c | 1 +
> >> hw/smbios/smbios.c | 11 ++++++++++
> >> hw/sparc/sun4m.c | 2 ++
> >> hw/sparc64/sun4u.c | 2 ++
> >> hw/xtensa/sim.c | 1 +
> >> hw/xtensa/xtfpga.c | 1 +
> >> include/hw/arm/virt.h | 2 +-
> >> include/hw/boards.h | 8 ++++++++
> >> include/sysemu/sysemu.h | 2 +-
> >> migration/postcopy-ram.c | 7 +++++++
> >> numa.c | 1 +
> >> target/arm/cpu.c | 7 +++++++
> >> target/i386/cpu.c | 4 ++++
> >> target/openrisc/sys_helper.c | 5 +++++
> >> target/s390x/cpu.c | 3 +++
> >> target/s390x/excp_helper.c | 6 ++++++
> >> tcg/tcg.c | 15 ++++++++++++++
> >> vl.c | 48 ++++++++++++++++++++++++--------------------
> >> 57 files changed, 261 insertions(+), 25 deletions(-)
> >>
> >
> >
> >
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Igor Mammedov <imammedo@redhat.com>
To: Like Xu <like.xu@linux.intel.com>
Cc: qemu-trivial@nongnu.org, like.xu@intel.com,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties
Date: Mon, 8 Apr 2019 15:26:14 +0200 [thread overview]
Message-ID: <20190408152614.0bdf3cfd@redhat.com> (raw)
Message-ID: <20190408132614.XMIz4XZJEkbw6_KcBkpNgcsMWebwaAWeBQpzaUjDTMo@z> (raw)
In-Reply-To: <7b902f2b-64b9-9c73-eeb0-1be33f1f2b07@linux.intel.com>
On Thu, 4 Apr 2019 11:26:09 +0800
Like Xu <like.xu@linux.intel.com> wrote:
> On 2019/3/29 18:21, Igor Mammedov wrote:
> > On Fri, 29 Mar 2019 16:48:36 +0800
> > Like Xu <like.xu@linux.intel.com> wrote:
> >
> >> This patch series make existing cores/threads/sockets into machine
> >> properties and get rid of global variables they use currently.
> > Thanks for looking into it!
> > Its long overdue and rather desired conversion (albeit naive one,
> > but this series is a good starting point). I'll go over your patches
> > next week with comments and concrete suggestions how to implement
> > particular things.
>
> Hi Igor, any comments and suggestions on smp machine properties
> in this patch considering we may add die topology for PCMachine as an
> extension?
I've looked at several patches and that it for this series.
The most comments apply to the patches I've not reviewed as well.
> >
> >> Like Xu (9):
> >> cpu/topology: add struct CpuTopology to MachineState
> >> cpu/topology: add general support for machine properties
> >> cpu/topology: add uncommon arch support for smp machine properties
> >> cpu/topology: add ARM support for smp machine properties
> >> cpu/topology: add i386 support for smp machine properties
> >> cpu/topology: add PPC support for smp machine properties
> >> cpu/topology: add riscv support for smp machine properties
> >> cpu/topology: add s390x support for smp machine properties
> >> cpu/topology: replace smp global variables with machine propertie
> >>
> >> accel/kvm/kvm-all.c | 3 +++
> >> backends/hostmem.c | 4 ++++
> >> cpus.c | 4 ++++
> >> exec.c | 2 ++
> >> gdbstub.c | 7 ++++++-
> >> hw/alpha/dp264.c | 1 +
> >> hw/arm/fsl-imx6.c | 5 +++++
> >> hw/arm/fsl-imx6ul.c | 5 +++++
> >> hw/arm/fsl-imx7.c | 5 +++++
> >> hw/arm/highbank.c | 1 +
> >> hw/arm/mcimx6ul-evk.c | 1 +
> >> hw/arm/mcimx7d-sabre.c | 3 +++
> >> hw/arm/raspi.c | 2 ++
> >> hw/arm/realview.c | 1 +
> >> hw/arm/sabrelite.c | 1 +
> >> hw/arm/vexpress.c | 3 +++
> >> hw/arm/virt.c | 7 +++++++
> >> hw/arm/xlnx-zynqmp.c | 7 +++++++
> >> hw/cpu/core.c | 3 +++
> >> hw/hppa/machine.c | 4 ++++
> >> hw/i386/acpi-build.c | 3 +++
> >> hw/i386/kvmvapic.c | 5 +++++
> >> hw/i386/pc.c | 12 +++++++++++
> >> hw/mips/boston.c | 1 +
> >> hw/mips/mips_malta.c | 9 +++++++++
> >> hw/openrisc/openrisc_sim.c | 1 +
> >> hw/ppc/e500.c | 3 +++
> >> hw/ppc/mac_newworld.c | 2 ++
> >> hw/ppc/mac_oldworld.c | 2 ++
> >> hw/ppc/pnv.c | 3 +++
> >> hw/ppc/prep.c | 2 ++
> >> hw/ppc/spapr.c | 29 ++++++++++++++++++++++++++
> >> hw/ppc/spapr_rtas.c | 3 +++
> >> hw/riscv/sifive_e.c | 4 ++++
> >> hw/riscv/sifive_plic.c | 3 +++
> >> hw/riscv/sifive_u.c | 4 ++++
> >> hw/riscv/spike.c | 2 ++
> >> hw/riscv/virt.c | 1 +
> >> hw/s390x/s390-virtio-ccw.c | 2 ++
> >> hw/s390x/sclp.c | 1 +
> >> hw/smbios/smbios.c | 11 ++++++++++
> >> hw/sparc/sun4m.c | 2 ++
> >> hw/sparc64/sun4u.c | 2 ++
> >> hw/xtensa/sim.c | 1 +
> >> hw/xtensa/xtfpga.c | 1 +
> >> include/hw/arm/virt.h | 2 +-
> >> include/hw/boards.h | 8 ++++++++
> >> include/sysemu/sysemu.h | 2 +-
> >> migration/postcopy-ram.c | 7 +++++++
> >> numa.c | 1 +
> >> target/arm/cpu.c | 7 +++++++
> >> target/i386/cpu.c | 4 ++++
> >> target/openrisc/sys_helper.c | 5 +++++
> >> target/s390x/cpu.c | 3 +++
> >> target/s390x/excp_helper.c | 6 ++++++
> >> tcg/tcg.c | 15 ++++++++++++++
> >> vl.c | 48 ++++++++++++++++++++++++--------------------
> >> 57 files changed, 261 insertions(+), 25 deletions(-)
> >>
> >
> >
> >
>
>
next prev parent reply other threads:[~2019-04-08 13:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1553849325-44201-1-git-send-email-like.xu@linux.intel.com>
[not found] ` <20190329112152.0c7ad147@redhat.com>
2019-04-04 3:26 ` [Qemu-devel] [PATCH 0/9] refactor cpu topo into machine properties Like Xu
2019-04-08 13:26 ` Igor Mammedov [this message]
2019-04-08 13:26 ` Igor Mammedov
2019-04-08 14:38 ` Like Xu
2019-04-08 14:38 ` Like Xu
[not found] ` <1553849325-44201-2-git-send-email-like.xu@linux.intel.com>
2019-04-04 11:37 ` [Qemu-devel] [PATCH 1/9] cpu/topology: add struct CpuTopology to MachineState Igor Mammedov
[not found] ` <1553849325-44201-3-git-send-email-like.xu@linux.intel.com>
2019-04-04 14:25 ` [Qemu-devel] [PATCH 2/9] cpu/topology: add general support for machine properties Igor Mammedov
2019-04-04 16:21 ` Dr. David Alan Gilbert
2019-04-30 7:30 ` Like Xu
2019-04-30 7:30 ` Like Xu
2019-05-02 15:09 ` Igor Mammedov
2019-05-02 15:09 ` Igor Mammedov
2019-05-03 1:08 ` Eduardo Habkost
2019-05-03 1:08 ` Eduardo Habkost
2019-05-03 1:01 ` Eduardo Habkost
2019-05-03 1:01 ` Eduardo Habkost
[not found] ` <1553849325-44201-4-git-send-email-like.xu@linux.intel.com>
2019-04-08 12:54 ` [Qemu-devel] [PATCH 3/9] cpu/topology: add uncommon arch support for smp " Igor Mammedov
2019-04-08 12:54 ` Igor Mammedov
2019-04-16 8:47 ` Like Xu
2019-04-16 8:47 ` Like Xu
2019-04-16 12:00 ` Igor Mammedov
2019-04-16 12:00 ` Igor Mammedov
[not found] ` <1553849325-44201-5-git-send-email-like.xu@linux.intel.com>
[not found] ` <87h8bmuj2d.fsf@zen.linaroharston>
[not found] ` <2546bf3e-2009-5a76-bc63-0ad73d333a78@linux.intel.com>
2019-04-01 23:38 ` [Qemu-devel] [PATCH 4/9] cpu/topology: add ARM " Eduardo Habkost
2019-04-02 2:35 ` Like Xu
2019-04-02 4:45 ` Peter Maydell
2019-04-02 5:20 ` Like Xu
2019-04-02 5:27 ` Peter Maydell
2019-04-08 13:11 ` Igor Mammedov
2019-04-08 13:11 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408152614.0bdf3cfd@redhat.com \
--to=imammedo@redhat.com \
--cc=ehabkost@redhat.com \
--cc=like.xu@intel.com \
--cc=like.xu@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).