From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, mreitz@redhat.com, qemu-block@nongnu.org,
dgilbert@redhat.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] hmp: Fix drive_add ... format=help crash
Date: Mon, 8 Apr 2019 17:44:09 +0200 [thread overview]
Message-ID: <20190408154409.GD11997@linux.fritz.box> (raw)
In-Reply-To: <20190408153003.20596-1-armbru@redhat.com>
Am 08.04.2019 um 17:30 hat Markus Armbruster geschrieben:
> drive_new() returns null without setting an error when it provided
> help. add_init_drive() assumes null means failure, and crashes trying
> to report a null error.
>
> Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Thanks, applied to the block branch.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: dgilbert@redhat.com, qemu-stable@nongnu.org,
qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] hmp: Fix drive_add ... format=help crash
Date: Mon, 8 Apr 2019 17:44:09 +0200 [thread overview]
Message-ID: <20190408154409.GD11997@linux.fritz.box> (raw)
Message-ID: <20190408154409.5h-Pf7hQuCOExlo1-Qy9NHAzZNwVBPsHpqAPgL6OkhQ@z> (raw)
In-Reply-To: <20190408153003.20596-1-armbru@redhat.com>
Am 08.04.2019 um 17:30 hat Markus Armbruster geschrieben:
> drive_new() returns null without setting an error when it provided
> help. add_init_drive() assumes null means failure, and crashes trying
> to report a null error.
>
> Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Thanks, applied to the block branch.
Kevin
next prev parent reply other threads:[~2019-04-08 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 15:30 [Qemu-devel] [PATCH v2] hmp: Fix drive_add ... format=help crash Markus Armbruster
2019-04-08 15:30 ` Markus Armbruster
2019-04-08 15:35 ` Dr. David Alan Gilbert
2019-04-08 15:35 ` Dr. David Alan Gilbert
2019-04-08 15:44 ` Kevin Wolf [this message]
2019-04-08 15:44 ` Kevin Wolf
2019-04-08 16:09 ` Philippe Mathieu-Daudé
2019-04-08 16:09 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408154409.GD11997@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).