From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
"open list:Network Block Dev..." <qemu-block@nongnu.org>
Subject: [Qemu-devel] [PULL 4/4] nbd/client: Fix error message for server with unusable sizing
Date: Mon, 8 Apr 2019 14:02:33 -0500 [thread overview]
Message-ID: <20190408190233.10321-5-eblake@redhat.com> (raw)
In-Reply-To: <20190408190233.10321-1-eblake@redhat.com>
Add a missing space to the error message used when giving up on a
server that insists on an alignment which renders the last few bytes
of the export unreadable.
Fixes: 3add3ab78
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190404145226.32649-1-eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
nbd/client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nbd/client.c b/nbd/client.c
index 427980bdd22..4de30630c73 100644
--- a/nbd/client.c
+++ b/nbd/client.c
@@ -428,7 +428,7 @@ static int nbd_opt_info_or_go(QIOChannel *ioc, uint32_t opt,
}
if (info->min_block &&
!QEMU_IS_ALIGNED(info->size, info->min_block)) {
- error_setg(errp, "export size %" PRIu64 "is not multiple of "
+ error_setg(errp, "export size %" PRIu64 " is not multiple of "
"minimum block size %" PRIu32, info->size,
info->min_block);
nbd_send_opt_abort(ioc);
--
2.20.1
next prev parent reply other threads:[~2019-04-08 19:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 19:02 [Qemu-devel] [PULL 0/4] NBD patches for 4.0-rc3 Eric Blake
2019-04-08 19:02 ` Eric Blake
2019-04-08 19:02 ` [Qemu-devel] [PULL 1/4] nbd/server: Fix blockstatus trace Eric Blake
2019-04-08 19:02 ` Eric Blake
2019-04-08 19:02 ` [Qemu-devel] [PULL 2/4] nbd/server: Trace client noncompliance on unaligned requests Eric Blake
2019-04-08 19:02 ` Eric Blake
2019-04-08 19:02 ` [Qemu-devel] [PULL 3/4] nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources Eric Blake
2019-04-08 19:02 ` Eric Blake
2019-04-08 19:02 ` Eric Blake [this message]
2019-04-08 19:02 ` [Qemu-devel] [PULL 4/4] nbd/client: Fix error message for server with unusable sizing Eric Blake
2019-04-09 9:02 ` [Qemu-devel] [PULL 0/4] NBD patches for 4.0-rc3 Peter Maydell
2019-04-09 9:02 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408190233.10321-5-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).