From: Laurent Vivier <laurent@vivier.eu> To: qemu-devel@nongnu.org Cc: "Laurent Vivier" <laurent@vivier.eu>, "Riku Voipio" <riku.voipio@iki.fi>, "Daniel P. Berrangé" <berrange@redhat.com>, "Richard Henderson" <richard.henderson@linaro.org> Subject: [Qemu-devel] [PULL 1/2] linux-user: assume __NR_gettid always exists Date: Mon, 8 Apr 2019 21:37:10 +0200 [thread overview] Message-ID: <20190408193711.32680-2-laurent@vivier.eu> (raw) In-Reply-To: <20190408193711.32680-1-laurent@vivier.eu> From: Daniel P. Berrangé <berrange@redhat.com> The gettid syscall was introduced in Linux 2.4.11. This is old enough that we can assume it always exists and thus not bother with the conditional backcompat logic. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Laurent Vivier <laurent@vivier.eu> Message-Id: <20190320161842.13908-2-berrange@redhat.com> Signed-off-by: Laurent Vivier <laurent@vivier.eu> --- linux-user/syscall.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 208fd1813d6a..11729f382cf4 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -249,15 +249,7 @@ static type name (type1 arg1,type2 arg2,type3 arg3,type4 arg4,type5 arg5, \ #define TARGET_NR__llseek TARGET_NR_llseek #endif -#ifdef __NR_gettid _syscall0(int, gettid) -#else -/* This is a replacement for the host gettid() and must return a host - errno. */ -static int gettid(void) { - return -ENOSYS; -} -#endif /* For the 64-bit guest on 32-bit host case we must emulate * getdents using getdents64, because otherwise the host -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Vivier <laurent@vivier.eu> To: qemu-devel@nongnu.org Cc: Richard Henderson <richard.henderson@linaro.org>, Riku Voipio <riku.voipio@iki.fi>, Laurent Vivier <laurent@vivier.eu> Subject: [Qemu-devel] [PULL 1/2] linux-user: assume __NR_gettid always exists Date: Mon, 8 Apr 2019 21:37:10 +0200 [thread overview] Message-ID: <20190408193711.32680-2-laurent@vivier.eu> (raw) Message-ID: <20190408193710.reP70uQomsyTv_ojjZp5DvlSe5WAHJvxuQDaMPvkym0@z> (raw) In-Reply-To: <20190408193711.32680-1-laurent@vivier.eu> From: Daniel P. Berrangé <berrange@redhat.com> The gettid syscall was introduced in Linux 2.4.11. This is old enough that we can assume it always exists and thus not bother with the conditional backcompat logic. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Laurent Vivier <laurent@vivier.eu> Message-Id: <20190320161842.13908-2-berrange@redhat.com> Signed-off-by: Laurent Vivier <laurent@vivier.eu> --- linux-user/syscall.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 208fd1813d6a..11729f382cf4 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -249,15 +249,7 @@ static type name (type1 arg1,type2 arg2,type3 arg3,type4 arg4,type5 arg5, \ #define TARGET_NR__llseek TARGET_NR_llseek #endif -#ifdef __NR_gettid _syscall0(int, gettid) -#else -/* This is a replacement for the host gettid() and must return a host - errno. */ -static int gettid(void) { - return -ENOSYS; -} -#endif /* For the 64-bit guest on 32-bit host case we must emulate * getdents using getdents64, because otherwise the host -- 2.20.1
next prev parent reply other threads:[~2019-04-08 19:37 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-08 19:37 [Qemu-devel] [PULL 0/2] Linux user for 4.0 patches Laurent Vivier 2019-04-08 19:37 ` Laurent Vivier 2019-04-08 19:37 ` Laurent Vivier [this message] 2019-04-08 19:37 ` [Qemu-devel] [PULL 1/2] linux-user: assume __NR_gettid always exists Laurent Vivier 2019-04-08 19:37 ` [Qemu-devel] [PULL 2/2] linux-user: rename gettid() to sys_gettid() to avoid clash with glibc Laurent Vivier 2019-04-08 19:37 ` Laurent Vivier 2019-04-09 11:58 ` [Qemu-devel] [PULL 0/2] Linux user for 4.0 patches Peter Maydell 2019-04-09 11:58 ` Peter Maydell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190408193711.32680-2-laurent@vivier.eu \ --to=laurent@vivier.eu \ --cc=berrange@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=riku.voipio@iki.fi \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).