qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gary R Hook <ghook@redhat.com>
To: rhvirt-patches@redhat.com
Cc: ghook@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [RHEL-8.1 virt 2/2] target/i386: sev: Do not pin the ram device memory region
Date: Tue,  9 Apr 2019 20:08:03 -0400	[thread overview]
Message-ID: <20190410000803.1744-3-ghook@redhat.com> (raw)
In-Reply-To: <20190410000803.1744-1-ghook@redhat.com>

BZ: 1667249
Branch: rhel-8.1.0
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1667249
Upstream Status: 4.0.0-rc1
Build Info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=20980582
Conflicts: None

commit cedc0ad539afbbb669dba9e73dfad2915bc1c25b
Author: Singh, Brijesh <brijesh.singh@amd.com>
Date:   Mon Feb 4 22:23:40 2019 +0000

    target/i386: sev: Do not pin the ram device memory region

    The RAM device presents a memory region that should be handled
    as an IO region and should not be pinned.

    In the case of the vfio-pci, RAM device represents a MMIO BAR
    and the memory region is not backed by pages hence
    KVM_MEMORY_ENCRYPT_REG_REGION fails to lock the memory range.

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1667249
    Cc: Alex Williamson <alex.williamson@redhat.com>
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
    Message-Id: <20190204222322.26766-3-brijesh.singh@amd.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Cc: Paolo Bonzini <pbonzini@redhat.com> 
Cc: Richard Henderson <rth@twiddle.net> 
Cc: Eduardo Habkost <ehabkost@redhat.com> 
Cc: qemu-devel@nongnu.org 
---
 target/i386/sev.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/target/i386/sev.c b/target/i386/sev.c
index 2395171acf..b8009b001a 100644
--- a/target/i386/sev.c
+++ b/target/i386/sev.c
@@ -130,6 +130,17 @@ sev_ram_block_added(RAMBlockNotifier *n, void *host, size_t size)
 {
     int r;
     struct kvm_enc_region range;
+    ram_addr_t offset;
+    MemoryRegion *mr;
+
+    /*
+     * The RAM device presents a memory region that should be treated
+     * as IO region and should not be pinned.
+     */
+    mr = memory_region_from_host(host, &offset);
+    if (mr && memory_region_is_ram_device(mr)) {
+	return;
+    }
 
     range.addr = (__u64)(unsigned long)host;
     range.size = size;
-- 
2.18.1

WARNING: multiple messages have this Message-ID (diff)
From: Gary R Hook <ghook@redhat.com>
To: rhvirt-patches@redhat.com
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	ghook@redhat.com, Eduardo Habkost <ehabkost@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [RHEL-8.1 virt 2/2] target/i386: sev: Do not pin the ram device memory region
Date: Tue,  9 Apr 2019 20:08:03 -0400	[thread overview]
Message-ID: <20190410000803.1744-3-ghook@redhat.com> (raw)
Message-ID: <20190410000803.kXxkMIVMHDYOVa0TqVEQcxaaMJujrVLZGMHm7vtCOZc@z> (raw)
In-Reply-To: <20190410000803.1744-1-ghook@redhat.com>

BZ: 1667249
Branch: rhel-8.1.0
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1667249
Upstream Status: 4.0.0-rc1
Build Info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=20980582
Conflicts: None

commit cedc0ad539afbbb669dba9e73dfad2915bc1c25b
Author: Singh, Brijesh <brijesh.singh@amd.com>
Date:   Mon Feb 4 22:23:40 2019 +0000

    target/i386: sev: Do not pin the ram device memory region

    The RAM device presents a memory region that should be handled
    as an IO region and should not be pinned.

    In the case of the vfio-pci, RAM device represents a MMIO BAR
    and the memory region is not backed by pages hence
    KVM_MEMORY_ENCRYPT_REG_REGION fails to lock the memory range.

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1667249
    Cc: Alex Williamson <alex.williamson@redhat.com>
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
    Message-Id: <20190204222322.26766-3-brijesh.singh@amd.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Cc: Paolo Bonzini <pbonzini@redhat.com> 
Cc: Richard Henderson <rth@twiddle.net> 
Cc: Eduardo Habkost <ehabkost@redhat.com> 
Cc: qemu-devel@nongnu.org 
---
 target/i386/sev.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/target/i386/sev.c b/target/i386/sev.c
index 2395171acf..b8009b001a 100644
--- a/target/i386/sev.c
+++ b/target/i386/sev.c
@@ -130,6 +130,17 @@ sev_ram_block_added(RAMBlockNotifier *n, void *host, size_t size)
 {
     int r;
     struct kvm_enc_region range;
+    ram_addr_t offset;
+    MemoryRegion *mr;
+
+    /*
+     * The RAM device presents a memory region that should be treated
+     * as IO region and should not be pinned.
+     */
+    mr = memory_region_from_host(host, &offset);
+    if (mr && memory_region_is_ram_device(mr)) {
+	return;
+    }
 
     range.addr = (__u64)(unsigned long)host;
     range.size = size;
-- 
2.18.1



  parent reply	other threads:[~2019-04-10  0:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10  0:08 [Qemu-devel] [RHEL-8.1 virt 0/2] Enable SEV VM to boot with assigned PCI device Gary R Hook
2019-04-10  0:08 ` Gary R Hook
2019-04-10  0:08 ` [Qemu-devel] [RHEL-8.1 virt 1/2] memory: Fix the memory region type assignment order Gary R Hook
2019-04-10  0:08   ` Gary R Hook
2019-04-22 21:26   ` Eduardo Habkost
2019-04-22 21:26     ` Eduardo Habkost
2019-04-10  0:08 ` Gary R Hook [this message]
2019-04-10  0:08   ` [Qemu-devel] [RHEL-8.1 virt 2/2] target/i386: sev: Do not pin the ram device memory region Gary R Hook
2019-04-22 21:29   ` Eduardo Habkost
2019-04-22 21:29     ` Eduardo Habkost
2019-11-06 20:04   ` Gary R Hook
2019-04-26  8:10 ` [Qemu-devel] [RHEL-8.1 virt 0/2] Enable SEV VM to boot with assigned PCI device Paolo Bonzini
2019-04-26  8:10   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190410000803.1744-3-ghook@redhat.com \
    --to=ghook@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rhvirt-patches@redhat.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).