* [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers
@ 2019-04-09 23:19 Cole Robinson
2019-04-09 23:19 ` Cole Robinson
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Cole Robinson @ 2019-04-09 23:19 UTC (permalink / raw)
To: qemu-devel; +Cc: dgilbert, quintela, Paolo Bonzini, Cole Robinson
The only caller that checks the error code is looking for != 0,
so returning false is incorrect.
Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
migration/savevm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 34bcad3807..a3dae4cf02 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2544,7 +2544,7 @@ int save_snapshot(const char *name, Error **errp)
AioContext *aio_context;
if (migration_is_blocked(errp)) {
- return false;
+ return ret;
}
if (!replay_can_snapshot()) {
--
2.21.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers
2019-04-09 23:19 [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers Cole Robinson
@ 2019-04-09 23:19 ` Cole Robinson
2019-04-10 8:34 ` Dr. David Alan Gilbert
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Cole Robinson @ 2019-04-09 23:19 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Cole Robinson, dgilbert, quintela
The only caller that checks the error code is looking for != 0,
so returning false is incorrect.
Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
migration/savevm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 34bcad3807..a3dae4cf02 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2544,7 +2544,7 @@ int save_snapshot(const char *name, Error **errp)
AioContext *aio_context;
if (migration_is_blocked(errp)) {
- return false;
+ return ret;
}
if (!replay_can_snapshot()) {
--
2.21.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers
2019-04-09 23:19 [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers Cole Robinson
2019-04-09 23:19 ` Cole Robinson
@ 2019-04-10 8:34 ` Dr. David Alan Gilbert
2019-04-10 8:34 ` Dr. David Alan Gilbert
2019-04-10 9:06 ` Juan Quintela
2019-05-14 14:01 ` Dr. David Alan Gilbert
3 siblings, 1 reply; 7+ messages in thread
From: Dr. David Alan Gilbert @ 2019-04-10 8:34 UTC (permalink / raw)
To: Cole Robinson; +Cc: qemu-devel, quintela, Paolo Bonzini
* Cole Robinson (crobinso@redhat.com) wrote:
> The only caller that checks the error code is looking for != 0,
> so returning false is incorrect.
>
> Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
Thanks, this was in 3.1.0 so isn't a 4.0 regression, so it'll have
to wait for 4.1.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/savevm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 34bcad3807..a3dae4cf02 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -2544,7 +2544,7 @@ int save_snapshot(const char *name, Error **errp)
> AioContext *aio_context;
>
> if (migration_is_blocked(errp)) {
> - return false;
> + return ret;
> }
>
> if (!replay_can_snapshot()) {
> --
> 2.21.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers
2019-04-10 8:34 ` Dr. David Alan Gilbert
@ 2019-04-10 8:34 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 7+ messages in thread
From: Dr. David Alan Gilbert @ 2019-04-10 8:34 UTC (permalink / raw)
To: Cole Robinson; +Cc: Paolo Bonzini, qemu-devel, quintela
* Cole Robinson (crobinso@redhat.com) wrote:
> The only caller that checks the error code is looking for != 0,
> so returning false is incorrect.
>
> Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
Thanks, this was in 3.1.0 so isn't a 4.0 regression, so it'll have
to wait for 4.1.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/savevm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 34bcad3807..a3dae4cf02 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -2544,7 +2544,7 @@ int save_snapshot(const char *name, Error **errp)
> AioContext *aio_context;
>
> if (migration_is_blocked(errp)) {
> - return false;
> + return ret;
> }
>
> if (!replay_can_snapshot()) {
> --
> 2.21.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers
2019-04-09 23:19 [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers Cole Robinson
2019-04-09 23:19 ` Cole Robinson
2019-04-10 8:34 ` Dr. David Alan Gilbert
@ 2019-04-10 9:06 ` Juan Quintela
2019-04-10 9:06 ` Juan Quintela
2019-05-14 14:01 ` Dr. David Alan Gilbert
3 siblings, 1 reply; 7+ messages in thread
From: Juan Quintela @ 2019-04-10 9:06 UTC (permalink / raw)
To: Cole Robinson; +Cc: qemu-devel, dgilbert, Paolo Bonzini
Cole Robinson <crobinso@redhat.com> wrote:
> The only caller that checks the error code is looking for != 0,
> so returning false is incorrect.
>
> Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers
2019-04-10 9:06 ` Juan Quintela
@ 2019-04-10 9:06 ` Juan Quintela
0 siblings, 0 replies; 7+ messages in thread
From: Juan Quintela @ 2019-04-10 9:06 UTC (permalink / raw)
To: Cole Robinson; +Cc: Paolo Bonzini, qemu-devel, dgilbert
Cole Robinson <crobinso@redhat.com> wrote:
> The only caller that checks the error code is looking for != 0,
> so returning false is incorrect.
>
> Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers
2019-04-09 23:19 [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers Cole Robinson
` (2 preceding siblings ...)
2019-04-10 9:06 ` Juan Quintela
@ 2019-05-14 14:01 ` Dr. David Alan Gilbert
3 siblings, 0 replies; 7+ messages in thread
From: Dr. David Alan Gilbert @ 2019-05-14 14:01 UTC (permalink / raw)
To: Cole Robinson; +Cc: Paolo Bonzini, qemu-devel, quintela
* Cole Robinson (crobinso@redhat.com) wrote:
> The only caller that checks the error code is looking for != 0,
> so returning false is incorrect.
>
> Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
Queued
> ---
> migration/savevm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 34bcad3807..a3dae4cf02 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -2544,7 +2544,7 @@ int save_snapshot(const char *name, Error **errp)
> AioContext *aio_context;
>
> if (migration_is_blocked(errp)) {
> - return false;
> + return ret;
> }
>
> if (!replay_can_snapshot()) {
> --
> 2.21.0
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-05-14 14:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-09 23:19 [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers Cole Robinson
2019-04-09 23:19 ` Cole Robinson
2019-04-10 8:34 ` Dr. David Alan Gilbert
2019-04-10 8:34 ` Dr. David Alan Gilbert
2019-04-10 9:06 ` Juan Quintela
2019-04-10 9:06 ` Juan Quintela
2019-05-14 14:01 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).