From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEYBP-0004d2-Ty for qemu-devel@nongnu.org; Thu, 11 Apr 2019 07:47:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEYBO-0004Fy-K9 for qemu-devel@nongnu.org; Thu, 11 Apr 2019 07:47:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50372) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEYBO-0004FT-CC for qemu-devel@nongnu.org; Thu, 11 Apr 2019 07:47:54 -0400 Date: Thu, 11 Apr 2019 12:47:44 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20190411114744.GM3641@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20190408083627.7479-1-armbru@redhat.com> <20190408083627.7479-4-armbru@redhat.com> <87bm1gr83k.fsf@dusky.pond.sub.org> <1f1ab942-49e9-0714-c6bc-65c7a0c4fa27@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to" message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Paolo Bonzini , Markus Armbruster , qemu-devel On Tue, Apr 09, 2019 at 01:25:43PM +0200, Marc-Andr=C3=A9 Lureau wrote: > Hi >=20 > On Tue, Apr 9, 2019 at 12:40 PM Philippe Mathieu-Daud=C3=A9 > wrote: > > > > On 4/8/19 2:31 PM, Markus Armbruster wrote: > > > Marc-Andr=C3=A9 Lureau writes: > > > > > >> Hi > > >> > > >> On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster wrote: > > >>> > > >>> char_pty_open() prints a "char device redirected to PTY_NAME (lab= el > > >>> LABEL)" message to the current monitor or else to stderr. No oth= er > > >>> ChardevClass::open() prints anything on success. Drop the messag= e. > > >>> > > >>> Cc: "Marc-Andr=C3=A9 Lureau" > > >>> Cc: Paolo Bonzini > > >>> Signed-off-by: Markus Armbruster > > >>> --- > > >>> chardev/char-pty.c | 2 -- > > >>> 1 file changed, 2 deletions(-) > > >>> > > >> > > >> I guess that was printed for convenience. > > >> > > >> Allocated pty can be read from "info chardev", so I suppose we can > > >> make qemu more silent. Fine with me: > > >> > > >> Reviewed-by: Marc-Andr=C3=A9 Lureau > > > > > > Thanks! > > > > > > If we should decide the message is still useful enough to be worth > > > keeping, I could direct it to stdout instead of dropping it. > > > > I prefer this, if Marc-Andr=C3=A9 is still OK. >=20 > I don't mind, but I wonder if we really have users that care. Power > users can easily get the associated pty from a monitor query. IMHO if people want predictable filenames for chardevs without needing to lookup the name via the monitor, then UNIX sockets fill that need. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :| From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18A40C10F13 for ; Thu, 11 Apr 2019 11:49:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4C842133D for ; Thu, 11 Apr 2019 11:48:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4C842133D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:47241 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEYCR-00055Y-7G for qemu-devel@archiver.kernel.org; Thu, 11 Apr 2019 07:48:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEYBP-0004d2-Ty for qemu-devel@nongnu.org; Thu, 11 Apr 2019 07:47:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEYBO-0004Fy-K9 for qemu-devel@nongnu.org; Thu, 11 Apr 2019 07:47:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50372) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEYBO-0004FT-CC for qemu-devel@nongnu.org; Thu, 11 Apr 2019 07:47:54 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6A9B0368E7; Thu, 11 Apr 2019 11:47:52 +0000 (UTC) Received: from redhat.com (ovpn-112-57.ams2.redhat.com [10.36.112.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 118FF1001E67; Thu, 11 Apr 2019 11:47:47 +0000 (UTC) Date: Thu, 11 Apr 2019 12:47:44 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <20190411114744.GM3641@redhat.com> References: <20190408083627.7479-1-armbru@redhat.com> <20190408083627.7479-4-armbru@redhat.com> <87bm1gr83k.fsf@dusky.pond.sub.org> <1f1ab942-49e9-0714-c6bc-65c7a0c4fa27@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 11 Apr 2019 11:47:52 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to" message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Markus Armbruster , qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190411114744.t5-HRmzzlIZdgxswGo4SZ8SCPwOmPvu1FquXEZWeDSQ@z> On Tue, Apr 09, 2019 at 01:25:43PM +0200, Marc-Andr=C3=A9 Lureau wrote: > Hi >=20 > On Tue, Apr 9, 2019 at 12:40 PM Philippe Mathieu-Daud=C3=A9 > wrote: > > > > On 4/8/19 2:31 PM, Markus Armbruster wrote: > > > Marc-Andr=C3=A9 Lureau writes: > > > > > >> Hi > > >> > > >> On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster wrote: > > >>> > > >>> char_pty_open() prints a "char device redirected to PTY_NAME (lab= el > > >>> LABEL)" message to the current monitor or else to stderr. No oth= er > > >>> ChardevClass::open() prints anything on success. Drop the messag= e. > > >>> > > >>> Cc: "Marc-Andr=C3=A9 Lureau" > > >>> Cc: Paolo Bonzini > > >>> Signed-off-by: Markus Armbruster > > >>> --- > > >>> chardev/char-pty.c | 2 -- > > >>> 1 file changed, 2 deletions(-) > > >>> > > >> > > >> I guess that was printed for convenience. > > >> > > >> Allocated pty can be read from "info chardev", so I suppose we can > > >> make qemu more silent. Fine with me: > > >> > > >> Reviewed-by: Marc-Andr=C3=A9 Lureau > > > > > > Thanks! > > > > > > If we should decide the message is still useful enough to be worth > > > keeping, I could direct it to stdout instead of dropping it. > > > > I prefer this, if Marc-Andr=C3=A9 is still OK. >=20 > I don't mind, but I wonder if we really have users that care. Power > users can easily get the associated pty from a monitor query. IMHO if people want predictable filenames for chardevs without needing to lookup the name via the monitor, then UNIX sockets fill that need. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|