From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com
Subject: [Qemu-devel] [PATCH 13/17] qemu-print: New qemu_fprintf(), qemu_vfprintf()
Date: Thu, 11 Apr 2019 17:25:16 +0200 [thread overview]
Message-ID: <20190411152520.10061-14-armbru@redhat.com> (raw)
In-Reply-To: <20190411152520.10061-1-armbru@redhat.com>
Code that doesn't want to know about current monitor vs. stdout
vs. stderr takes an fprintf_function callback and a FILE * argument to
pass to it. Actual arguments are either fprintf() and stdout or
stderr, or monitor_fprintf() and the current monitor cast to FILE *.
monitor_fprintf() casts it right back, and is otherwise identical to
monitor_printf(). The type-punning is ugly.
New qemu_fprintf() and qemu_vprintf() address this need without type
punning: they are like fprintf() and vfprintf(), except they print to
the current monitor when passed a null FILE *. The next commits will
put them to use.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
include/qemu/qemu-print.h | 4 ++++
util/qemu-print.c | 27 +++++++++++++++++++++++++++
2 files changed, 31 insertions(+)
diff --git a/include/qemu/qemu-print.h b/include/qemu/qemu-print.h
index 8fed32bf42..40b596262f 100644
--- a/include/qemu/qemu-print.h
+++ b/include/qemu/qemu-print.h
@@ -16,4 +16,8 @@
int qemu_vprintf(const char *fmt, va_list ap) GCC_FMT_ATTR(1, 0);
int qemu_printf(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
+int qemu_vfprintf(FILE *stream, const char *fmt, va_list ap)
+ GCC_FMT_ATTR(2, 0);
+int qemu_fprintf(FILE *stream, const char *fmt, ...) GCC_FMT_ATTR(2, 3);
+
#endif
diff --git a/util/qemu-print.c b/util/qemu-print.c
index 86f9417af8..e79d6b8396 100644
--- a/util/qemu-print.c
+++ b/util/qemu-print.c
@@ -40,3 +40,30 @@ int qemu_printf(const char *fmt, ...)
va_end(ap);
return ret;
}
+
+/*
+ * Print like vfprintf()
+ * Print to @stream if non-null, else to current monitor.
+ */
+int qemu_vfprintf(FILE *stream, const char *fmt, va_list ap)
+{
+ if (!stream) {
+ return monitor_vprintf(cur_mon, fmt, ap);
+ }
+ return vfprintf(stream, fmt, ap);
+}
+
+/*
+ * Print like fprintf().
+ * Print to @stream if non-null, else to current monitor.
+ */
+int qemu_fprintf(FILE *stream, const char *fmt, ...)
+{
+ va_list ap;
+ int ret;
+
+ va_start(ap, fmt);
+ ret = qemu_vfprintf(stream, fmt, ap);
+ va_end(ap);
+ return ret;
+}
--
2.17.2
next prev parent reply other threads:[~2019-04-11 15:25 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 15:25 [Qemu-devel] [PATCH 00/17] Clean up and simplify around fprintf_function Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-11 15:25 ` [Qemu-devel] [PATCH 01/17] include: Include fprintf-fn.h only where needed Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-12 16:53 ` Dr. David Alan Gilbert
2019-04-12 16:53 ` Dr. David Alan Gilbert
2019-04-11 15:25 ` [Qemu-devel] [PATCH 02/17] trace: Simplify how st_print_trace_file_status() prints Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-12 16:55 ` Dr. David Alan Gilbert
2019-04-12 16:55 ` Dr. David Alan Gilbert
2019-04-11 15:25 ` [Qemu-devel] [PATCH 03/17] tcg: Simplify how dump_opcount_info() prints Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-12 16:58 ` Dr. David Alan Gilbert
2019-04-12 16:58 ` Dr. David Alan Gilbert
2019-04-11 15:25 ` [Qemu-devel] [PATCH 04/17] tcg: Simplify how dump_exec_info() prints Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-12 17:09 ` Dr. David Alan Gilbert
2019-04-12 17:09 ` Dr. David Alan Gilbert
2019-04-11 15:25 ` [Qemu-devel] [PATCH 05/17] tcg: Simplify how dump_drift_info() prints Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-12 17:18 ` Dr. David Alan Gilbert
2019-04-12 17:18 ` Dr. David Alan Gilbert
2019-04-11 15:25 ` [Qemu-devel] [PATCH 06/17] qsp: Simplify how qsp_report() prints Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-12 17:25 ` Dr. David Alan Gilbert
2019-04-12 17:25 ` Dr. David Alan Gilbert
2019-04-11 15:25 ` [Qemu-devel] [PATCH 07/17] block/qapi: Clean up how we print to monitor or stdout Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-12 17:59 ` Dr. David Alan Gilbert
2019-04-12 17:59 ` Dr. David Alan Gilbert
2019-04-11 15:25 ` [Qemu-devel] [PATCH 08/17] memory: Clean up how mtree_info() prints Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-12 17:44 ` Dr. David Alan Gilbert
2019-04-12 17:44 ` Dr. David Alan Gilbert
2019-04-12 18:25 ` Markus Armbruster
2019-04-12 18:25 ` Markus Armbruster
2019-04-11 15:25 ` [Qemu-devel] [PATCH 09/17] target: Simplify how the TARGET_cpu_list() print Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-15 15:43 ` Dr. David Alan Gilbert
2019-04-15 15:43 ` Dr. David Alan Gilbert
2019-04-16 6:14 ` Markus Armbruster
2019-04-16 6:14 ` Markus Armbruster
2019-04-16 8:20 ` Dr. David Alan Gilbert
2019-04-16 8:20 ` Dr. David Alan Gilbert
2019-04-11 15:25 ` [Qemu-devel] [PATCH 10/17] target: Clean up how the dump_mmu() print Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-15 15:53 ` Dr. David Alan Gilbert
2019-04-15 15:53 ` Dr. David Alan Gilbert
2019-04-16 6:23 ` Markus Armbruster
2019-04-16 6:23 ` Markus Armbruster
2019-04-11 15:25 ` [Qemu-devel] [PATCH 11/17] target/i386: Simplify how x86_cpu_dump_local_apic_state() prints Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-12 17:49 ` Dr. David Alan Gilbert
2019-04-12 17:49 ` Dr. David Alan Gilbert
2019-04-11 15:25 ` [Qemu-devel] [PATCH 12/17] qom/cpu: Simplify how CPUClass::dump_statistics() prints Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-12 17:50 ` Dr. David Alan Gilbert
2019-04-12 17:50 ` Dr. David Alan Gilbert
2019-04-11 15:25 ` Markus Armbruster [this message]
2019-04-11 15:25 ` [Qemu-devel] [PATCH 13/17] qemu-print: New qemu_fprintf(), qemu_vfprintf() Markus Armbruster
2019-04-12 17:53 ` Dr. David Alan Gilbert
2019-04-12 17:53 ` Dr. David Alan Gilbert
2019-04-11 15:25 ` [Qemu-devel] [PATCH 14/17] qom/cpu: Simplify how CPUClass:cpu_dump_state() prints Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-15 16:47 ` Dr. David Alan Gilbert
2019-04-15 16:47 ` Dr. David Alan Gilbert
2019-04-16 6:32 ` Markus Armbruster
2019-04-16 6:32 ` Markus Armbruster
2019-04-11 15:25 ` [Qemu-devel] [PATCH 15/17] monitor: Clean up how monitor_disas() funnels output to monitor Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-12 18:01 ` Dr. David Alan Gilbert
2019-04-12 18:01 ` Dr. David Alan Gilbert
2019-04-11 15:25 ` [Qemu-devel] [PATCH 16/17] disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-11 15:25 ` [Qemu-devel] [PATCH 17/17] include: Move fprintf_function to disas/ Markus Armbruster
2019-04-11 15:25 ` Markus Armbruster
2019-04-12 18:39 ` Dr. David Alan Gilbert
2019-04-12 18:39 ` Dr. David Alan Gilbert
2019-04-13 4:59 ` Markus Armbruster
2019-04-13 4:59 ` Markus Armbruster
2019-04-11 15:49 ` [Qemu-devel] [PATCH 00/17] Clean up and simplify around fprintf_function no-reply
2019-04-11 15:49 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411152520.10061-14-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).