From: Eduardo Otubo <otubo@redhat.com> To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, deller@gmx.de, berrange@redhat.com, philmd@redhat.com Subject: [Qemu-devel] [PULL 1/1] configure: Relax check for libseccomp Date: Fri, 12 Apr 2019 13:37:30 +0200 [thread overview] Message-ID: <20190412113730.28828-2-otubo@redhat.com> (raw) In-Reply-To: <20190412113730.28828-1-otubo@redhat.com> From: Helge Deller <deller@gmx.de> All major distributions do support libseccomp version >= 2.3.0, so there is no need to special-case on various architectures any longer. Signed-off-by: Helge Deller <deller@gmx.de> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Acked-by: Eduardo Otubo <otubo@redhat.com> --- configure | 28 ++++------------------------ 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/configure b/configure index 1c563a7027..fcc56aa979 100755 --- a/configure +++ b/configure @@ -2377,36 +2377,16 @@ fi ########################################## # libseccomp check -libseccomp_minver="2.2.0" if test "$seccomp" != "no" ; then - case "$cpu" in - i386|x86_64|mips) - ;; - arm|aarch64) - libseccomp_minver="2.2.3" - ;; - ppc|ppc64|s390x) - libseccomp_minver="2.3.0" - ;; - *) - libseccomp_minver="" - ;; - esac - - if test "$libseccomp_minver" != "" && - $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then + libseccomp_minver="2.3.0" + if $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then seccomp_cflags="$($pkg_config --cflags libseccomp)" seccomp_libs="$($pkg_config --libs libseccomp)" seccomp="yes" else if test "$seccomp" = "yes" ; then - if test "$libseccomp_minver" != "" ; then - feature_not_found "libseccomp" \ - "Install libseccomp devel >= $libseccomp_minver" - else - feature_not_found "libseccomp" \ - "libseccomp is not supported for host cpu $cpu" - fi + feature_not_found "libseccomp" \ + "Install libseccomp devel >= $libseccomp_minver" fi seccomp="no" fi -- 2.17.2
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Otubo <otubo@redhat.com> To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, deller@gmx.de, philmd@redhat.com Subject: [Qemu-devel] [PULL 1/1] configure: Relax check for libseccomp Date: Fri, 12 Apr 2019 13:37:30 +0200 [thread overview] Message-ID: <20190412113730.28828-2-otubo@redhat.com> (raw) Message-ID: <20190412113730.pFHxwSK__Ifo1ji5L2-c-NsbV1XjMo5lB__cQ2g5vTM@z> (raw) In-Reply-To: <20190412113730.28828-1-otubo@redhat.com> From: Helge Deller <deller@gmx.de> All major distributions do support libseccomp version >= 2.3.0, so there is no need to special-case on various architectures any longer. Signed-off-by: Helge Deller <deller@gmx.de> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Acked-by: Eduardo Otubo <otubo@redhat.com> --- configure | 28 ++++------------------------ 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/configure b/configure index 1c563a7027..fcc56aa979 100755 --- a/configure +++ b/configure @@ -2377,36 +2377,16 @@ fi ########################################## # libseccomp check -libseccomp_minver="2.2.0" if test "$seccomp" != "no" ; then - case "$cpu" in - i386|x86_64|mips) - ;; - arm|aarch64) - libseccomp_minver="2.2.3" - ;; - ppc|ppc64|s390x) - libseccomp_minver="2.3.0" - ;; - *) - libseccomp_minver="" - ;; - esac - - if test "$libseccomp_minver" != "" && - $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then + libseccomp_minver="2.3.0" + if $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then seccomp_cflags="$($pkg_config --cflags libseccomp)" seccomp_libs="$($pkg_config --libs libseccomp)" seccomp="yes" else if test "$seccomp" = "yes" ; then - if test "$libseccomp_minver" != "" ; then - feature_not_found "libseccomp" \ - "Install libseccomp devel >= $libseccomp_minver" - else - feature_not_found "libseccomp" \ - "libseccomp is not supported for host cpu $cpu" - fi + feature_not_found "libseccomp" \ + "Install libseccomp devel >= $libseccomp_minver" fi seccomp="no" fi -- 2.17.2
next prev parent reply other threads:[~2019-04-12 11:37 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-12 11:37 [Qemu-devel] [PULL 0/1] seccomp branch queue Eduardo Otubo 2019-04-12 11:37 ` Eduardo Otubo 2019-04-12 11:37 ` Eduardo Otubo [this message] 2019-04-12 11:37 ` [Qemu-devel] [PULL 1/1] configure: Relax check for libseccomp Eduardo Otubo 2019-04-12 11:43 ` Daniel P. Berrangé 2019-04-12 11:43 ` Daniel P. Berrangé 2019-04-12 12:52 ` Eduardo Otubo 2019-04-12 12:52 ` Eduardo Otubo 2019-04-12 11:52 ` [Qemu-devel] [PULL 0/1] seccomp branch queue Peter Maydell 2019-04-12 11:52 ` Peter Maydell 2019-04-12 12:53 ` Eduardo Otubo 2019-04-12 12:53 ` Eduardo Otubo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190412113730.28828-2-otubo@redhat.com \ --to=otubo@redhat.com \ --cc=berrange@redhat.com \ --cc=deller@gmx.de \ --cc=peter.maydell@linaro.org \ --cc=philmd@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).