[Qemu-devel] [PULL 0/1] seccomp branch queue

[Qemu-devel] [PULL 0/1] seccomp branch queue

[Eduardo Otubo]

The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949:

  Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100)

are available in the Git repository at:

  https://github.com/otubo/qemu.git tags/pull-seccomp-20190412

for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c:

  configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200)

----------------------------------------------------------------
pull-seccomp-20190412

----------------------------------------------------------------
Helge Deller (1):
      configure: Relax check for libseccomp

 configure | 28 ++++------------------------
 1 file changed, 4 insertions(+), 24 deletions(-)

-- 
2.17.2

[Qemu-devel] [PULL 0/1] seccomp branch queue

[Eduardo Otubo]

The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949:

  Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100)

are available in the Git repository at:

  https://github.com/otubo/qemu.git tags/pull-seccomp-20190412

for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c:

  configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200)

----------------------------------------------------------------
pull-seccomp-20190412

----------------------------------------------------------------
Helge Deller (1):
      configure: Relax check for libseccomp

 configure | 28 ++++------------------------
 1 file changed, 4 insertions(+), 24 deletions(-)

-- 
2.17.2

[Qemu-devel] [PULL 1/1] configure: Relax check for libseccomp

[Eduardo Otubo]

From: Helge Deller <deller@gmx.de>

All major distributions do support libseccomp version >= 2.3.0, so there
is no need to special-case on various architectures any longer.

Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Eduardo Otubo <otubo@redhat.com>
---
 configure | 28 ++++------------------------
 1 file changed, 4 insertions(+), 24 deletions(-)

diff --git a/configure b/configure
index 1c563a7027..fcc56aa979 100755
--- a/configure
+++ b/configure
@@ -2377,36 +2377,16 @@ fi
 ##########################################
 # libseccomp check
 
-libseccomp_minver="2.2.0"
 if test "$seccomp" != "no" ; then
-    case "$cpu" in
-    i386|x86_64|mips)
-        ;;
-    arm|aarch64)
-        libseccomp_minver="2.2.3"
-        ;;
-    ppc|ppc64|s390x)
-        libseccomp_minver="2.3.0"
-        ;;
-    *)
-        libseccomp_minver=""
-        ;;
-    esac
-
-    if test "$libseccomp_minver" != "" &&
-       $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then
+    libseccomp_minver="2.3.0"
+    if $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then
         seccomp_cflags="$($pkg_config --cflags libseccomp)"
         seccomp_libs="$($pkg_config --libs libseccomp)"
         seccomp="yes"
     else
         if test "$seccomp" = "yes" ; then
-            if test "$libseccomp_minver" != "" ; then
-                feature_not_found "libseccomp" \
-                    "Install libseccomp devel >= $libseccomp_minver"
-            else
-                feature_not_found "libseccomp" \
-                    "libseccomp is not supported for host cpu $cpu"
-            fi
+            feature_not_found "libseccomp" \
+                 "Install libseccomp devel >= $libseccomp_minver"
         fi
         seccomp="no"
     fi
-- 
2.17.2

[Qemu-devel] [PULL 1/1] configure: Relax check for libseccomp

[Eduardo Otubo]

From: Helge Deller <deller@gmx.de>

All major distributions do support libseccomp version >= 2.3.0, so there
is no need to special-case on various architectures any longer.

Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Eduardo Otubo <otubo@redhat.com>
---
 configure | 28 ++++------------------------
 1 file changed, 4 insertions(+), 24 deletions(-)

diff --git a/configure b/configure
index 1c563a7027..fcc56aa979 100755
--- a/configure
+++ b/configure
@@ -2377,36 +2377,16 @@ fi
 ##########################################
 # libseccomp check
 
-libseccomp_minver="2.2.0"
 if test "$seccomp" != "no" ; then
-    case "$cpu" in
-    i386|x86_64|mips)
-        ;;
-    arm|aarch64)
-        libseccomp_minver="2.2.3"
-        ;;
-    ppc|ppc64|s390x)
-        libseccomp_minver="2.3.0"
-        ;;
-    *)
-        libseccomp_minver=""
-        ;;
-    esac
-
-    if test "$libseccomp_minver" != "" &&
-       $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then
+    libseccomp_minver="2.3.0"
+    if $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then
         seccomp_cflags="$($pkg_config --cflags libseccomp)"
         seccomp_libs="$($pkg_config --libs libseccomp)"
         seccomp="yes"
     else
         if test "$seccomp" = "yes" ; then
-            if test "$libseccomp_minver" != "" ; then
-                feature_not_found "libseccomp" \
-                    "Install libseccomp devel >= $libseccomp_minver"
-            else
-                feature_not_found "libseccomp" \
-                    "libseccomp is not supported for host cpu $cpu"
-            fi
+            feature_not_found "libseccomp" \
+                 "Install libseccomp devel >= $libseccomp_minver"
         fi
         seccomp="no"
     fi
-- 
2.17.2

Re: [Qemu-devel] [PULL 1/1] configure: Relax check for libseccomp

[Daniel P. Berrangé]

On Fri, Apr 12, 2019 at 01:37:30PM +0200, Eduardo Otubo wrote:
> From: Helge Deller <deller@gmx.de>
> 
> All major distributions do support libseccomp version >= 2.3.0, so there
> is no need to special-case on various architectures any longer.
> 
> Signed-off-by: Helge Deller <deller@gmx.de>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Acked-by: Eduardo Otubo <otubo@redhat.com>

When sending pull requests the subsystem maintainer *must*
add their Signed-off-by as this is what has legal meaning
with respect to the developer certificate of origin.

Acked-by is something that is used to give a different
subsystem maintainer permission to merge a patch that
would normally be your responsibility.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PULL 1/1] configure: Relax check for libseccomp

[Daniel P. Berrangé]

On Fri, Apr 12, 2019 at 01:37:30PM +0200, Eduardo Otubo wrote:
> From: Helge Deller <deller@gmx.de>
> 
> All major distributions do support libseccomp version >= 2.3.0, so there
> is no need to special-case on various architectures any longer.
> 
> Signed-off-by: Helge Deller <deller@gmx.de>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Acked-by: Eduardo Otubo <otubo@redhat.com>

When sending pull requests the subsystem maintainer *must*
add their Signed-off-by as this is what has legal meaning
with respect to the developer certificate of origin.

Acked-by is something that is used to give a different
subsystem maintainer permission to merge a patch that
would normally be your responsibility.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

[Peter Maydell]

On Fri, 12 Apr 2019 at 12:37, Eduardo Otubo <otubo@redhat.com> wrote:
>
> The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949:
>
>   Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/otubo/qemu.git tags/pull-seccomp-20190412
>
> for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c:
>
>   configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200)
>
> ----------------------------------------------------------------
> pull-seccomp-20190412
>
> ----------------------------------------------------------------
> Helge Deller (1):
>       configure: Relax check for libseccomp

Is this really release critical? If you're sending pull
requests for rc3/rc4 it is extremely helpful if you can
give the justification for why they need to go into this
release. (As it happens we're going to need an rc4, but
I want to keep the set of changes in it to a minimum.)

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

[Peter Maydell]

On Fri, 12 Apr 2019 at 12:37, Eduardo Otubo <otubo@redhat.com> wrote:
>
> The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949:
>
>   Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/otubo/qemu.git tags/pull-seccomp-20190412
>
> for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c:
>
>   configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200)
>
> ----------------------------------------------------------------
> pull-seccomp-20190412
>
> ----------------------------------------------------------------
> Helge Deller (1):
>       configure: Relax check for libseccomp

Is this really release critical? If you're sending pull
requests for rc3/rc4 it is extremely helpful if you can
give the justification for why they need to go into this
release. (As it happens we're going to need an rc4, but
I want to keep the set of changes in it to a minimum.)

thanks
-- PMM

Re: [Qemu-devel] [PULL 1/1] configure: Relax check for libseccomp

[Eduardo Otubo]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On 12/04/2019 - 12:43:07, Daniel P. Berrange wrote:
> On Fri, Apr 12, 2019 at 01:37:30PM +0200, Eduardo Otubo wrote:
> > From: Helge Deller <deller@gmx.de>
> > 
> > All major distributions do support libseccomp version >= 2.3.0, so there
> > is no need to special-case on various architectures any longer.
> > 
> > Signed-off-by: Helge Deller <deller@gmx.de>
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Acked-by: Eduardo Otubo <otubo@redhat.com>
> 
> When sending pull requests the subsystem maintainer *must*
> add their Signed-off-by as this is what has legal meaning
> with respect to the developer certificate of origin.
> 
> Acked-by is something that is used to give a different
> subsystem maintainer permission to merge a patch that
> would normally be your responsibility.
> 
> 

I think this issue was already raised by Peter on my last pull-request. My
appologies, I fixed the last pull request my didn't fix my script :/

Will send again after the release.
Thanks for pointing that out.

-- 
Eduardo Otubo

Red Hat GmbH,http://www.de.redhat.com/, Sitz: Grasbrunn,
Handelsregister: Amtsgericht München, HRB 153243,
Geschäftsführer: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PULL 1/1] configure: Relax check for libseccomp

[Eduardo Otubo]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On 12/04/2019 - 12:43:07, Daniel P. Berrange wrote:
> On Fri, Apr 12, 2019 at 01:37:30PM +0200, Eduardo Otubo wrote:
> > From: Helge Deller <deller@gmx.de>
> > 
> > All major distributions do support libseccomp version >= 2.3.0, so there
> > is no need to special-case on various architectures any longer.
> > 
> > Signed-off-by: Helge Deller <deller@gmx.de>
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Acked-by: Eduardo Otubo <otubo@redhat.com>
> 
> When sending pull requests the subsystem maintainer *must*
> add their Signed-off-by as this is what has legal meaning
> with respect to the developer certificate of origin.
> 
> Acked-by is something that is used to give a different
> subsystem maintainer permission to merge a patch that
> would normally be your responsibility.
> 
> 

I think this issue was already raised by Peter on my last pull-request. My
appologies, I fixed the last pull request my didn't fix my script :/

Will send again after the release.
Thanks for pointing that out.

-- 
Eduardo Otubo

Red Hat GmbH,http://www.de.redhat.com/, Sitz: Grasbrunn,
Handelsregister: Amtsgericht München, HRB 153243,
Geschäftsführer: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

[Eduardo Otubo]

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

On 12/04/2019 - 12:52:48, Peter Maydell wrote:
> On Fri, 12 Apr 2019 at 12:37, Eduardo Otubo <otubo@redhat.com> wrote:
> >
> > The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949:
> >
> >   Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/otubo/qemu.git tags/pull-seccomp-20190412
> >
> > for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c:
> >
> >   configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200)
> >
> > ----------------------------------------------------------------
> > pull-seccomp-20190412
> >
> > ----------------------------------------------------------------
> > Helge Deller (1):
> >       configure: Relax check for libseccomp
> 
> Is this really release critical? If you're sending pull
> requests for rc3/rc4 it is extremely helpful if you can
> give the justification for why they need to go into this
> release. (As it happens we're going to need an rc4, but
> I want to keep the set of changes in it to a minimum.)
> 

This is not critical. I'll send again after the current release.

-- 
Eduardo Otubo

Red Hat GmbH,http://www.de.redhat.com/, Sitz: Grasbrunn,
Handelsregister: Amtsgericht München, HRB 153243,
Geschäftsführer: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

[Eduardo Otubo]

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

On 12/04/2019 - 12:52:48, Peter Maydell wrote:
> On Fri, 12 Apr 2019 at 12:37, Eduardo Otubo <otubo@redhat.com> wrote:
> >
> > The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949:
> >
> >   Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/otubo/qemu.git tags/pull-seccomp-20190412
> >
> > for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c:
> >
> >   configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200)
> >
> > ----------------------------------------------------------------
> > pull-seccomp-20190412
> >
> > ----------------------------------------------------------------
> > Helge Deller (1):
> >       configure: Relax check for libseccomp
> 
> Is this really release critical? If you're sending pull
> requests for rc3/rc4 it is extremely helpful if you can
> give the justification for why they need to go into this
> release. (As it happens we're going to need an rc4, but
> I want to keep the set of changes in it to a minimum.)
> 

This is not critical. I'll send again after the current release.

-- 
Eduardo Otubo

Red Hat GmbH,http://www.de.redhat.com/, Sitz: Grasbrunn,
Handelsregister: Amtsgericht München, HRB 153243,
Geschäftsführer: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]