qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Otubo <otubo@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, deller@gmx.de,
	philmd@redhat.com
Subject: Re: [Qemu-devel] [PULL 1/1] configure: Relax check for libseccomp
Date: Fri, 12 Apr 2019 14:52:52 +0200	[thread overview]
Message-ID: <20190412125252.GB13589@vader> (raw)
In-Reply-To: <20190412114307.GK25308@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On 12/04/2019 - 12:43:07, Daniel P. Berrange wrote:
> On Fri, Apr 12, 2019 at 01:37:30PM +0200, Eduardo Otubo wrote:
> > From: Helge Deller <deller@gmx.de>
> > 
> > All major distributions do support libseccomp version >= 2.3.0, so there
> > is no need to special-case on various architectures any longer.
> > 
> > Signed-off-by: Helge Deller <deller@gmx.de>
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Acked-by: Eduardo Otubo <otubo@redhat.com>
> 
> When sending pull requests the subsystem maintainer *must*
> add their Signed-off-by as this is what has legal meaning
> with respect to the developer certificate of origin.
> 
> Acked-by is something that is used to give a different
> subsystem maintainer permission to merge a patch that
> would normally be your responsibility.
> 
> 

I think this issue was already raised by Peter on my last pull-request. My
appologies, I fixed the last pull request my didn't fix my script :/

Will send again after the release.
Thanks for pointing that out.

-- 
Eduardo Otubo

Red Hat GmbH,http://www.de.redhat.com/, Sitz: Grasbrunn,
Handelsregister: Amtsgericht München, HRB 153243,
Geschäftsführer: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Otubo <otubo@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: peter.maydell@linaro.org, deller@gmx.de, philmd@redhat.com,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 1/1] configure: Relax check for libseccomp
Date: Fri, 12 Apr 2019 14:52:52 +0200	[thread overview]
Message-ID: <20190412125252.GB13589@vader> (raw)
Message-ID: <20190412125252.91PEzb57CTNSBzAJ2yUZCHCDxPMi_s5OxflKfFVg53I@z> (raw)
In-Reply-To: <20190412114307.GK25308@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On 12/04/2019 - 12:43:07, Daniel P. Berrange wrote:
> On Fri, Apr 12, 2019 at 01:37:30PM +0200, Eduardo Otubo wrote:
> > From: Helge Deller <deller@gmx.de>
> > 
> > All major distributions do support libseccomp version >= 2.3.0, so there
> > is no need to special-case on various architectures any longer.
> > 
> > Signed-off-by: Helge Deller <deller@gmx.de>
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Acked-by: Eduardo Otubo <otubo@redhat.com>
> 
> When sending pull requests the subsystem maintainer *must*
> add their Signed-off-by as this is what has legal meaning
> with respect to the developer certificate of origin.
> 
> Acked-by is something that is used to give a different
> subsystem maintainer permission to merge a patch that
> would normally be your responsibility.
> 
> 

I think this issue was already raised by Peter on my last pull-request. My
appologies, I fixed the last pull request my didn't fix my script :/

Will send again after the release.
Thanks for pointing that out.

-- 
Eduardo Otubo

Red Hat GmbH,http://www.de.redhat.com/, Sitz: Grasbrunn,
Handelsregister: Amtsgericht München, HRB 153243,
Geschäftsführer: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  parent reply	other threads:[~2019-04-12 12:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12 11:37 [Qemu-devel] [PULL 0/1] seccomp branch queue Eduardo Otubo
2019-04-12 11:37 ` Eduardo Otubo
2019-04-12 11:37 ` [Qemu-devel] [PULL 1/1] configure: Relax check for libseccomp Eduardo Otubo
2019-04-12 11:37   ` Eduardo Otubo
2019-04-12 11:43   ` Daniel P. Berrangé
2019-04-12 11:43     ` Daniel P. Berrangé
2019-04-12 12:52     ` Eduardo Otubo [this message]
2019-04-12 12:52       ` Eduardo Otubo
2019-04-12 11:52 ` [Qemu-devel] [PULL 0/1] seccomp branch queue Peter Maydell
2019-04-12 11:52   ` Peter Maydell
2019-04-12 12:53   ` Eduardo Otubo
2019-04-12 12:53     ` Eduardo Otubo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190412125252.GB13589@vader \
    --to=otubo@redhat.com \
    --cc=berrange@redhat.com \
    --cc=deller@gmx.de \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).