From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Cc: qemu-arm@nongnu.org, "Andrzej Zaborowski" <balrogg@gmail.com>,
"Jan Kiszka" <jan.kiszka@web.de>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH v3 02/12] hw/arm/nseries: Use TYPE_TMP105 instead of hardcoded string
Date: Fri, 12 Apr 2019 18:54:06 +0200 [thread overview]
Message-ID: <20190412165416.7977-3-philmd@redhat.com> (raw)
In-Reply-To: <20190412165416.7977-1-philmd@redhat.com>
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/arm/nseries.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index 906b7ca22d4..2b710c3d49f 100644
--- a/hw/arm/nseries.c
+++ b/hw/arm/nseries.c
@@ -31,6 +31,7 @@
#include "hw/boards.h"
#include "hw/i2c/i2c.h"
#include "hw/devices.h"
+#include "hw/misc/tmp105.h"
#include "hw/block/flash.h"
#include "hw/hw.h"
#include "hw/bt.h"
@@ -218,7 +219,7 @@ static void n8x0_i2c_setup(struct n800_s *s)
qemu_register_powerdown_notifier(&n8x0_system_powerdown_notifier);
/* Attach a TMP105 PM chip (A0 wired to ground) */
- dev = i2c_create_slave(i2c, "tmp105", N8X0_TMP105_ADDR);
+ dev = i2c_create_slave(i2c, TYPE_TMP105, N8X0_TMP105_ADDR);
qdev_connect_gpio_out(dev, 0, tmp_irq);
}
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-arm@nongnu.org, "Jan Kiszka" <jan.kiszka@web.de>
Subject: [Qemu-devel] [PATCH v3 02/12] hw/arm/nseries: Use TYPE_TMP105 instead of hardcoded string
Date: Fri, 12 Apr 2019 18:54:06 +0200 [thread overview]
Message-ID: <20190412165416.7977-3-philmd@redhat.com> (raw)
Message-ID: <20190412165406.ukh6ytmjxYS6wbajl0J5XI2OOjTjdYMYORJZE7aC8Ks@z> (raw)
In-Reply-To: <20190412165416.7977-1-philmd@redhat.com>
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/arm/nseries.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index 906b7ca22d4..2b710c3d49f 100644
--- a/hw/arm/nseries.c
+++ b/hw/arm/nseries.c
@@ -31,6 +31,7 @@
#include "hw/boards.h"
#include "hw/i2c/i2c.h"
#include "hw/devices.h"
+#include "hw/misc/tmp105.h"
#include "hw/block/flash.h"
#include "hw/hw.h"
#include "hw/bt.h"
@@ -218,7 +219,7 @@ static void n8x0_i2c_setup(struct n800_s *s)
qemu_register_powerdown_notifier(&n8x0_system_powerdown_notifier);
/* Attach a TMP105 PM chip (A0 wired to ground) */
- dev = i2c_create_slave(i2c, "tmp105", N8X0_TMP105_ADDR);
+ dev = i2c_create_slave(i2c, TYPE_TMP105, N8X0_TMP105_ADDR);
qdev_connect_gpio_out(dev, 0, tmp_irq);
}
--
2.20.1
next prev parent reply other threads:[~2019-04-12 16:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 16:54 [Qemu-devel] [PATCH v3 00/12] hw: Remove "hw/devices.h" Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé
2019-04-12 16:54 ` [Qemu-devel] [PATCH v3 01/12] hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded string Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé [this message]
2019-04-12 16:54 ` [Qemu-devel] [PATCH v3 02/12] hw/arm/nseries: Use TYPE_TMP105 " Philippe Mathieu-Daudé
2019-04-12 16:54 ` [Qemu-devel] [PATCH v3 03/12] hw/display/tc6393xb: Remove unused functions Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé
2019-04-12 16:54 ` [Qemu-devel] [PATCH v3 04/12] hw/devices: Move TC6393XB declarations into a new header Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé
2019-04-12 16:54 ` [Qemu-devel] [PATCH v3 05/12] hw/devices: Move Blizzard " Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé
2019-04-12 16:54 ` [Qemu-devel] [PATCH v3 06/12] hw/devices: Move CBus " Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé
2019-04-12 16:54 ` [Qemu-devel] [PATCH v3 07/12] hw/devices: Move Gamepad " Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé
2019-04-12 16:54 ` [Qemu-devel] [PATCH v3 08/12] hw/devices: Move TI touchscreen " Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé
2019-04-12 16:54 ` [Qemu-devel] [PATCH v3 09/12] hw/devices: Move LAN9118 " Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé
2019-04-12 16:54 ` [Qemu-devel] [PATCH v3 10/12] hw/net/ne2000-isa: Add guards to the header Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé
2019-04-12 16:54 ` [Qemu-devel] [PATCH v3 11/12] hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded string Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé
2019-04-12 16:54 ` [Qemu-devel] [PATCH v3 12/12] hw/devices: Move SMSC 91C111 declaration into a new header Philippe Mathieu-Daudé
2019-04-12 16:54 ` Philippe Mathieu-Daudé
2019-04-29 16:51 ` [Qemu-devel] [Qemu-arm] [PATCH v3 00/12] hw: Remove "hw/devices.h" Peter Maydell
2019-04-29 16:51 ` Peter Maydell
2019-04-29 18:19 ` Philippe Mathieu-Daudé
2019-04-29 18:19 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412165416.7977-3-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=balrogg@gmail.com \
--cc=i.mitsyanko@gmail.com \
--cc=jan.kiszka@web.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).