From: Eduardo Habkost <ehabkost@redhat.com>
To: Like Xu <like.xu@linux.intel.com>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
like.xu@intel.com, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/2] vl.c: refactor current_machine as non-global variable
Date: Tue, 16 Apr 2019 18:16:06 -0300 [thread overview]
Message-ID: <20190416211606.GA2272@habkost.net> (raw)
In-Reply-To: <1555315185-16414-2-git-send-email-like.xu@linux.intel.com>
On Mon, Apr 15, 2019 at 03:59:44PM +0800, Like Xu wrote:
> This patch makes the remaining dozen or so uses of the global
> current_machine outside vl.c use qdev_get_machine() instead,
> and then make current_machine local to vl.c instead of global.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Like Xu <like.xu@linux.intel.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Like Xu <like.xu@linux.intel.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
qemu-trivial@nongnu.org, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, like.xu@intel.com,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/2] vl.c: refactor current_machine as non-global variable
Date: Tue, 16 Apr 2019 18:16:06 -0300 [thread overview]
Message-ID: <20190416211606.GA2272@habkost.net> (raw)
Message-ID: <20190416211606.G2Z7XfAzQl7sStmVVLneOVpdbFt65P2owpnWw-Q_Yms@z> (raw)
In-Reply-To: <1555315185-16414-2-git-send-email-like.xu@linux.intel.com>
On Mon, Apr 15, 2019 at 03:59:44PM +0800, Like Xu wrote:
> This patch makes the remaining dozen or so uses of the global
> current_machine outside vl.c use qdev_get_machine() instead,
> and then make current_machine local to vl.c instead of global.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Like Xu <like.xu@linux.intel.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
next prev parent reply other threads:[~2019-04-16 21:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 7:59 [Qemu-devel] [PATCH v3 0/2] vl.c: make current_machine as non-global variable Like Xu
2019-04-15 7:59 ` Like Xu
2019-04-15 7:59 ` [Qemu-devel] [PATCH v3 1/2] vl.c: refactor " Like Xu
2019-04-15 7:59 ` Like Xu
2019-04-16 21:16 ` Eduardo Habkost [this message]
2019-04-16 21:16 ` Eduardo Habkost
2019-04-17 5:26 ` Markus Armbruster
2019-04-17 5:26 ` Markus Armbruster
2019-04-17 17:05 ` Eduardo Habkost
2019-04-17 17:05 ` Eduardo Habkost
2019-04-15 7:59 ` [Qemu-devel] [PATCH v3 2/2] core/qdev: refactor qdev_get_machine() with type assertion Like Xu
2019-04-15 7:59 ` Like Xu
2019-04-16 21:20 ` Eduardo Habkost
2019-04-16 21:20 ` Eduardo Habkost
2019-04-17 5:14 ` Markus Armbruster
2019-04-17 5:14 ` Markus Armbruster
2019-04-17 17:10 ` Eduardo Habkost
2019-04-17 17:10 ` Eduardo Habkost
2019-04-23 7:59 ` Like Xu
2019-04-23 7:59 ` Like Xu
2019-04-24 17:21 ` Eduardo Habkost
2019-04-24 17:21 ` Eduardo Habkost
2019-04-25 3:12 ` Like Xu
2019-04-25 3:12 ` Like Xu
2019-04-25 17:48 ` Eduardo Habkost
2019-04-25 17:48 ` Eduardo Habkost
2019-05-06 11:17 ` Markus Armbruster
2019-05-06 11:15 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416211606.GA2272@habkost.net \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=like.xu@intel.com \
--cc=like.xu@linux.intel.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).