From: Eduardo Habkost <ehabkost@redhat.com> To: qemu-devel@nongnu.org Cc: Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <rth@twiddle.net>, Igor Mammedov <imammedo@redhat.com>, Palmer Dabbelt <palmer@sifive.com>, Alistair Francis <Alistair.Francis@wdc.com>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-riscv@nongnu.org Subject: [Qemu-devel] [PATCH 2/7] riscv: Don't split CPU model string Date: Fri, 19 Apr 2019 03:14:24 -0300 [thread overview] Message-ID: <20190419061429.17695-3-ehabkost@redhat.com> (raw) In-Reply-To: <20190419061429.17695-1-ehabkost@redhat.com> CPUClass::class_by_name is called after the CPU model name and options were already split, there's no need to split the string again. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- Cc: Palmer Dabbelt <palmer@sifive.com> Cc: Alistair Francis <Alistair.Francis@wdc.com> Cc: Sagar Karandikar <sagark@eecs.berkeley.edu> Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de> Cc: qemu-riscv@nongnu.org --- target/riscv/cpu.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index d61bce6d55..5e97a83c80 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -179,12 +179,9 @@ static ObjectClass *riscv_cpu_class_by_name(const char *cpu_model) { ObjectClass *oc; char *typename; - char **cpuname; - cpuname = g_strsplit(cpu_model, ",", 1); - typename = g_strdup_printf(RISCV_CPU_TYPE_NAME("%s"), cpuname[0]); + typename = g_strdup_printf(RISCV_CPU_TYPE_NAME("%s"), cpu_model); oc = object_class_by_name(typename); - g_strfreev(cpuname); g_free(typename); if (!oc || !object_class_dynamic_cast(oc, TYPE_RISCV_CPU) || object_class_is_abstract(oc)) { -- 2.18.0.rc1.1.g3f1ff2140
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com> To: qemu-devel@nongnu.org Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-riscv@nongnu.org, Sagar Karandikar <sagark@eecs.berkeley.edu>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Palmer Dabbelt <palmer@sifive.com>, Alistair Francis <Alistair.Francis@wdc.com>, Igor Mammedov <imammedo@redhat.com>, Richard Henderson <rth@twiddle.net> Subject: [Qemu-devel] [PATCH 2/7] riscv: Don't split CPU model string Date: Fri, 19 Apr 2019 03:14:24 -0300 [thread overview] Message-ID: <20190419061429.17695-3-ehabkost@redhat.com> (raw) Message-ID: <20190419061424._GSrFF95BEJ29Cw1IKNaQaKrwvur12KQNgQfUHqAxBQ@z> (raw) In-Reply-To: <20190419061429.17695-1-ehabkost@redhat.com> CPUClass::class_by_name is called after the CPU model name and options were already split, there's no need to split the string again. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- Cc: Palmer Dabbelt <palmer@sifive.com> Cc: Alistair Francis <Alistair.Francis@wdc.com> Cc: Sagar Karandikar <sagark@eecs.berkeley.edu> Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de> Cc: qemu-riscv@nongnu.org --- target/riscv/cpu.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index d61bce6d55..5e97a83c80 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -179,12 +179,9 @@ static ObjectClass *riscv_cpu_class_by_name(const char *cpu_model) { ObjectClass *oc; char *typename; - char **cpuname; - cpuname = g_strsplit(cpu_model, ",", 1); - typename = g_strdup_printf(RISCV_CPU_TYPE_NAME("%s"), cpuname[0]); + typename = g_strdup_printf(RISCV_CPU_TYPE_NAME("%s"), cpu_model); oc = object_class_by_name(typename); - g_strfreev(cpuname); g_free(typename); if (!oc || !object_class_dynamic_cast(oc, TYPE_RISCV_CPU) || object_class_is_abstract(oc)) { -- 2.18.0.rc1.1.g3f1ff2140
next prev parent reply other threads:[~2019-04-19 6:14 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-19 6:14 [Qemu-devel] [PATCH 0/7] Delete 16 *_cpu_class_by_name() functions Eduardo Habkost 2019-04-19 6:14 ` Eduardo Habkost 2019-04-19 6:14 ` [Qemu-devel] [PATCH 1/7] cpu: Change return type of cpu_class_by_name() to CPUClass Eduardo Habkost 2019-04-19 6:14 ` Eduardo Habkost 2019-04-19 6:14 ` Eduardo Habkost [this message] 2019-04-19 6:14 ` [Qemu-devel] [PATCH 2/7] riscv: Don't split CPU model string Eduardo Habkost 2019-04-19 21:00 ` Alistair Francis 2019-04-19 21:00 ` Alistair Francis 2019-04-19 6:14 ` [Qemu-devel] [PATCH 3/7] arm: " Eduardo Habkost 2019-04-19 6:14 ` Eduardo Habkost 2019-04-19 6:14 ` [Qemu-devel] [PATCH 4/7] arm: Remove special case for "any" CPU model Eduardo Habkost 2019-04-19 6:14 ` Eduardo Habkost 2019-04-19 6:14 ` [Qemu-devel] [PATCH 5/7] cpu: Let architectures set CPU class name format Eduardo Habkost 2019-04-19 6:14 ` Eduardo Habkost 2019-05-06 11:42 ` Markus Armbruster 2019-05-08 5:52 ` Markus Armbruster 2019-04-19 6:14 ` [Qemu-devel] [PATCH 6/7] cpu: Set class name format for some architectures Eduardo Habkost 2019-04-19 6:14 ` Eduardo Habkost 2019-04-19 20:59 ` Alistair Francis 2019-04-19 20:59 ` Alistair Francis 2019-04-19 6:14 ` [Qemu-devel] [PATCH 7/7] cpu: Set fixed class name on " Eduardo Habkost 2019-04-19 6:14 ` Eduardo Habkost 2019-05-06 11:53 ` [Qemu-devel] [PATCH 0/7] Delete 16 *_cpu_class_by_name() functions Markus Armbruster 2019-05-06 19:53 ` Eduardo Habkost 2019-05-08 8:34 ` Markus Armbruster 2019-05-08 19:46 ` Eduardo Habkost 2019-05-09 5:55 ` Markus Armbruster 2019-05-09 15:46 ` Igor Mammedov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190419061429.17695-3-ehabkost@redhat.com \ --to=ehabkost@redhat.com \ --cc=Alistair.Francis@wdc.com \ --cc=imammedo@redhat.com \ --cc=kbastian@mail.uni-paderborn.de \ --cc=palmer@sifive.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu-riscv@nongnu.org \ --cc=rth@twiddle.net \ --cc=sagark@eecs.berkeley.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).