From: Li Qiang <liq3ea@163.com>
To: jslaby@suse.cz, pbonzini@redhat.com
Cc: qemu-devel@nongnu.org, liq3ea@gmail.com, Li Qiang <liq3ea@163.com>
Subject: [Qemu-devel] [PATCH v2 2/3] edu: mmio: set 'max_access_size' to 8
Date: Sat, 20 Apr 2019 08:59:48 -0700 [thread overview]
Message-ID: <20190420155949.130968-3-liq3ea@163.com> (raw)
In-Reply-To: <20190420155949.130968-1-liq3ea@163.com>
The edu spec said, the MMIO area can be accessed by 8 bytes.
However currently the 'max_access_size' is not so the MMIO
access dispatch can only access 4 bytes one time. This patch
fixes this to respect the spec.
Notice: here the 'min_access_size' is not a must, I set this
for completement.
Signed-off-by: Li Qiang <liq3ea@163.com>
---
hw/misc/edu.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 91af452c9e..65fc32b928 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -289,6 +289,15 @@ static const MemoryRegionOps edu_mmio_ops = {
.read = edu_mmio_read,
.write = edu_mmio_write,
.endianness = DEVICE_NATIVE_ENDIAN,
+ .valid = {
+ .min_access_size = 4,
+ .max_access_size = 8,
+ },
+ .impl = {
+ .min_access_size = 4,
+ .max_access_size = 8,
+ },
+
};
/*
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Li Qiang <liq3ea@163.com>
To: jslaby@suse.cz, pbonzini@redhat.com
Cc: Li Qiang <liq3ea@163.com>, liq3ea@gmail.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 2/3] edu: mmio: set 'max_access_size' to 8
Date: Sat, 20 Apr 2019 08:59:48 -0700 [thread overview]
Message-ID: <20190420155949.130968-3-liq3ea@163.com> (raw)
Message-ID: <20190420155948.3OtUHVSFEuXlnN-JiDTowdrHKsEWAaEJUbjR1RtZOUg@z> (raw)
In-Reply-To: <20190420155949.130968-1-liq3ea@163.com>
The edu spec said, the MMIO area can be accessed by 8 bytes.
However currently the 'max_access_size' is not so the MMIO
access dispatch can only access 4 bytes one time. This patch
fixes this to respect the spec.
Notice: here the 'min_access_size' is not a must, I set this
for completement.
Signed-off-by: Li Qiang <liq3ea@163.com>
---
hw/misc/edu.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 91af452c9e..65fc32b928 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -289,6 +289,15 @@ static const MemoryRegionOps edu_mmio_ops = {
.read = edu_mmio_read,
.write = edu_mmio_write,
.endianness = DEVICE_NATIVE_ENDIAN,
+ .valid = {
+ .min_access_size = 4,
+ .max_access_size = 8,
+ },
+ .impl = {
+ .min_access_size = 4,
+ .max_access_size = 8,
+ },
+
};
/*
--
2.17.1
next prev parent reply other threads:[~2019-04-20 16:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 15:59 [Qemu-devel] [PATCH v2 0/3] hw: edu: some fixes Li Qiang
2019-04-20 15:59 ` Li Qiang
2019-04-20 15:59 ` [Qemu-devel] [PATCH v2 1/3] tests: fw_cfg: add splash time test case Li Qiang
2019-04-20 15:59 ` Li Qiang
2019-04-20 15:59 ` Li Qiang [this message]
2019-04-20 15:59 ` [Qemu-devel] [PATCH v2 2/3] edu: mmio: set 'max_access_size' to 8 Li Qiang
2019-04-20 15:59 ` [Qemu-devel] [PATCH v2 3/3] edu: mmio: allow mmio read dispatch accept 8 bytes Li Qiang
2019-04-20 15:59 ` Li Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190420155949.130968-3-liq3ea@163.com \
--to=liq3ea@163.com \
--cc=jslaby@suse.cz \
--cc=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).