From: Li Qiang <liq3ea@163.com>
To: jslaby@suse.cz, pbonzini@redhat.com
Cc: qemu-devel@nongnu.org, liq3ea@gmail.com, Li Qiang <liq3ea@163.com>
Subject: [Qemu-devel] [PATCH v2 2/3] edu: mmio: allow mmio read dispatch accept 8 bytes
Date: Sat, 20 Apr 2019 09:14:45 -0700 [thread overview]
Message-ID: <20190420161446.2274-3-liq3ea@163.com> (raw)
In-Reply-To: <20190420161446.2274-1-liq3ea@163.com>
The edu spec said when address >= 0x80, the MMIO area can
be accessed by 8 bytes.
Signed-off-by: Li Qiang <liq3ea@163.com>
---
hw/misc/edu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 65fc32b928..4018dddcb8 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -189,6 +189,10 @@ static uint64_t edu_mmio_read(void *opaque, hwaddr addr, unsigned size)
return val;
}
+ if (addr >= 0x80 && size != 4 && size != 8) {
+ return val;
+ }
+
switch (addr) {
case 0x00:
val = 0x010000edu;
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Li Qiang <liq3ea@163.com>
To: jslaby@suse.cz, pbonzini@redhat.com
Cc: Li Qiang <liq3ea@163.com>, liq3ea@gmail.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 2/3] edu: mmio: allow mmio read dispatch accept 8 bytes
Date: Sat, 20 Apr 2019 09:14:45 -0700 [thread overview]
Message-ID: <20190420161446.2274-3-liq3ea@163.com> (raw)
Message-ID: <20190420161445.I_6NLxWgyQQWrhhNfE9ubmdHKd7pg0EXWudIx8yLSWs@z> (raw)
In-Reply-To: <20190420161446.2274-1-liq3ea@163.com>
The edu spec said when address >= 0x80, the MMIO area can
be accessed by 8 bytes.
Signed-off-by: Li Qiang <liq3ea@163.com>
---
hw/misc/edu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 65fc32b928..4018dddcb8 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -189,6 +189,10 @@ static uint64_t edu_mmio_read(void *opaque, hwaddr addr, unsigned size)
return val;
}
+ if (addr >= 0x80 && size != 4 && size != 8) {
+ return val;
+ }
+
switch (addr) {
case 0x00:
val = 0x010000edu;
--
2.17.1
next prev parent reply other threads:[~2019-04-20 16:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 16:14 [Qemu-devel] [PATCH v2 0/3] hw: edu: some fixes Li Qiang
2019-04-20 16:14 ` Li Qiang
2019-04-20 16:14 ` [Qemu-devel] [PATCH v2 1/3] edu: mmio: set 'max_access_size' to 8 Li Qiang
2019-04-20 16:14 ` Li Qiang
2019-04-21 10:28 ` Philippe Mathieu-Daudé
2019-04-21 10:28 ` Philippe Mathieu-Daudé
2019-04-22 1:17 ` Li Qiang
2019-04-22 1:17 ` Li Qiang
2019-04-22 16:27 ` Philippe Mathieu-Daudé
2019-04-22 16:27 ` Philippe Mathieu-Daudé
2019-04-23 3:50 ` Li Qiang
2019-04-23 3:50 ` Li Qiang
2019-04-20 16:14 ` Li Qiang [this message]
2019-04-20 16:14 ` [Qemu-devel] [PATCH v2 2/3] edu: mmio: allow mmio read dispatch accept 8 bytes Li Qiang
2019-04-21 10:44 ` Philippe Mathieu-Daudé
2019-04-21 10:44 ` Philippe Mathieu-Daudé
2019-04-22 1:22 ` Li Qiang
2019-04-22 1:22 ` Li Qiang
2019-04-20 16:14 ` [Qemu-devel] [PATCH v2 3/3] edu: uses uint64_t in dma operation Li Qiang
2019-04-20 16:14 ` Li Qiang
2019-04-21 10:32 ` Philippe Mathieu-Daudé
2019-04-21 10:32 ` Philippe Mathieu-Daudé
2019-04-22 1:21 ` Li Qiang
2019-04-22 1:21 ` Li Qiang
2019-04-22 16:29 ` Philippe Mathieu-Daudé
2019-04-22 16:29 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190420161446.2274-3-liq3ea@163.com \
--to=liq3ea@163.com \
--cc=jslaby@suse.cz \
--cc=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).