From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/3] char-socket: Fix race condition
Date: Tue, 23 Apr 2019 17:55:01 +0100 [thread overview]
Message-ID: <20190423165501.GA27867@redhat.com> (raw)
In-Reply-To: <cover.1550842915.git.berto@igalia.com>
ping - paolo/marc-andré - unless I'm missing something, it looks like
this chardev series slipped through the cracks and missed 4.0
On Fri, Feb 22, 2019 at 03:46:23PM +0200, Alberto Garcia wrote:
> This fixes a race condition in which the tcp_chr_read() ioc handler
> can close a connection that is being written to from another thread.
>
> Note: vhost-user-test still fails if QTEST_VHOST_USER_FIXME is set.
>
> Berto
>
> RFC: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01510.html
>
> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01834.html
> - Fixes memory leaks and adds a qemu_idle_add() function
>
> v2: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06137.html
> - Rebased on top of the current master (fc3dbb90f2eb069801bfb4cfe9cbc)
> - Patches 1 and 2: Remove the changes in char-pty.c, they're not
> needed after the rebase.
> - Patch 3: Fix conflicts after the rebase.
>
> v3:
> - Patch 3: Add tcp_chr_disconnect_locked() [Daniel]
>
> Alberto Garcia (3):
> main-loop: Fix GSource leak in qio_task_thread_worker()
> main-loop: Add qemu_idle_add()
> char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()
>
> chardev/char-socket.c | 25 +++++++++++++++++++++----
> include/qemu/main-loop.h | 12 ++++++++++++
> io/task.c | 9 +++------
> util/main-loop.c | 9 +++++++++
> 4 files changed, 45 insertions(+), 10 deletions(-)
>
> --
> 2.11.0
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/3] char-socket: Fix race condition
Date: Tue, 23 Apr 2019 17:55:01 +0100 [thread overview]
Message-ID: <20190423165501.GA27867@redhat.com> (raw)
Message-ID: <20190423165501.EPrAwbQtAdx7EZ06pMPP5bnEsl8eb951XBUfzqZhBq0@z> (raw)
In-Reply-To: <cover.1550842915.git.berto@igalia.com>
ping - paolo/marc-andré - unless I'm missing something, it looks like
this chardev series slipped through the cracks and missed 4.0
On Fri, Feb 22, 2019 at 03:46:23PM +0200, Alberto Garcia wrote:
> This fixes a race condition in which the tcp_chr_read() ioc handler
> can close a connection that is being written to from another thread.
>
> Note: vhost-user-test still fails if QTEST_VHOST_USER_FIXME is set.
>
> Berto
>
> RFC: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01510.html
>
> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01834.html
> - Fixes memory leaks and adds a qemu_idle_add() function
>
> v2: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06137.html
> - Rebased on top of the current master (fc3dbb90f2eb069801bfb4cfe9cbc)
> - Patches 1 and 2: Remove the changes in char-pty.c, they're not
> needed after the rebase.
> - Patch 3: Fix conflicts after the rebase.
>
> v3:
> - Patch 3: Add tcp_chr_disconnect_locked() [Daniel]
>
> Alberto Garcia (3):
> main-loop: Fix GSource leak in qio_task_thread_worker()
> main-loop: Add qemu_idle_add()
> char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()
>
> chardev/char-socket.c | 25 +++++++++++++++++++++----
> include/qemu/main-loop.h | 12 ++++++++++++
> io/task.c | 9 +++------
> util/main-loop.c | 9 +++++++++
> 4 files changed, 45 insertions(+), 10 deletions(-)
>
> --
> 2.11.0
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-04-23 16:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 13:46 [Qemu-devel] [PATCH v3 0/3] char-socket: Fix race condition Alberto Garcia
2019-02-22 13:46 ` [Qemu-devel] [PATCH v3 1/3] main-loop: Fix GSource leak in qio_task_thread_worker() Alberto Garcia
2019-02-22 13:46 ` [Qemu-devel] [PATCH v3 2/3] main-loop: Add qemu_idle_add() Alberto Garcia
2019-02-22 13:46 ` [Qemu-devel] [PATCH v3 3/3] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout() Alberto Garcia
2019-02-22 13:51 ` Daniel P. Berrangé
2019-07-16 9:56 ` Max Reitz
2019-03-05 15:52 ` [Qemu-devel] [PATCH v3 0/3] char-socket: Fix race condition Alberto Garcia
2019-03-05 15:55 ` Marc-André Lureau
2019-03-06 10:58 ` Paolo Bonzini
2019-04-23 16:55 ` Daniel P. Berrangé [this message]
2019-04-23 16:55 ` Daniel P. Berrangé
2019-04-26 7:51 ` Paolo Bonzini
2019-04-26 7:51 ` Paolo Bonzini
2019-06-05 19:36 ` Max Reitz
2019-07-03 17:51 ` Max Reitz
2019-07-04 9:59 ` Paolo Bonzini
2019-07-16 12:55 ` Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423165501.GA27867@redhat.com \
--to=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).