From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:54377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIyhR-00061k-AM for qemu-devel@nongnu.org; Tue, 23 Apr 2019 12:55:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIyhQ-0000Bd-5M for qemu-devel@nongnu.org; Tue, 23 Apr 2019 12:55:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32116) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hIyhP-0000AX-Ts for qemu-devel@nongnu.org; Tue, 23 Apr 2019 12:55:16 -0400 Date: Tue, 23 Apr 2019 17:55:01 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20190423165501.GA27867@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 0/3] char-socket: Fix race condition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-devel@nongnu.org, Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau ping - paolo/marc-andr=C3=A9 - unless I'm missing something, it looks lik= e this chardev series slipped through the cracks and missed 4.0 On Fri, Feb 22, 2019 at 03:46:23PM +0200, Alberto Garcia wrote: > This fixes a race condition in which the tcp_chr_read() ioc handler > can close a connection that is being written to from another thread. >=20 > Note: vhost-user-test still fails if QTEST_VHOST_USER_FIXME is set. >=20 > Berto >=20 > RFC: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01510.htm= l >=20 > v1: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01834.html > - Fixes memory leaks and adds a qemu_idle_add() function >=20 > v2: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06137.html > - Rebased on top of the current master (fc3dbb90f2eb069801bfb4cfe9cbc) > - Patches 1 and 2: Remove the changes in char-pty.c, they're not > needed after the rebase. > - Patch 3: Fix conflicts after the rebase. >=20 > v3: > - Patch 3: Add tcp_chr_disconnect_locked() [Daniel] >=20 > Alberto Garcia (3): > main-loop: Fix GSource leak in qio_task_thread_worker() > main-loop: Add qemu_idle_add() > char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout() >=20 > chardev/char-socket.c | 25 +++++++++++++++++++++---- > include/qemu/main-loop.h | 12 ++++++++++++ > io/task.c | 9 +++------ > util/main-loop.c | 9 +++++++++ > 4 files changed, 45 insertions(+), 10 deletions(-) >=20 > --=20 > 2.11.0 >=20 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :| From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F939C10F03 for ; Tue, 23 Apr 2019 16:56:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E36D2214AE for ; Tue, 23 Apr 2019 16:56:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E36D2214AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:56773 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIyiF-0006Qi-OA for qemu-devel@archiver.kernel.org; Tue, 23 Apr 2019 12:56:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIyhR-00061k-AM for qemu-devel@nongnu.org; Tue, 23 Apr 2019 12:55:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIyhQ-0000Bd-5M for qemu-devel@nongnu.org; Tue, 23 Apr 2019 12:55:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32116) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hIyhP-0000AX-Ts for qemu-devel@nongnu.org; Tue, 23 Apr 2019 12:55:16 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B3258C079C44; Tue, 23 Apr 2019 16:55:09 +0000 (UTC) Received: from redhat.com (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86AB05D721; Tue, 23 Apr 2019 16:55:04 +0000 (UTC) Date: Tue, 23 Apr 2019 17:55:01 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Alberto Garcia Message-ID: <20190423165501.GA27867@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 23 Apr 2019 16:55:09 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v3 0/3] char-socket: Fix race condition X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Paolo Bonzini , qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190423165501.EPrAwbQtAdx7EZ06pMPP5bnEsl8eb951XBUfzqZhBq0@z> ping - paolo/marc-andr=C3=A9 - unless I'm missing something, it looks lik= e this chardev series slipped through the cracks and missed 4.0 On Fri, Feb 22, 2019 at 03:46:23PM +0200, Alberto Garcia wrote: > This fixes a race condition in which the tcp_chr_read() ioc handler > can close a connection that is being written to from another thread. >=20 > Note: vhost-user-test still fails if QTEST_VHOST_USER_FIXME is set. >=20 > Berto >=20 > RFC: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01510.htm= l >=20 > v1: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01834.html > - Fixes memory leaks and adds a qemu_idle_add() function >=20 > v2: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06137.html > - Rebased on top of the current master (fc3dbb90f2eb069801bfb4cfe9cbc) > - Patches 1 and 2: Remove the changes in char-pty.c, they're not > needed after the rebase. > - Patch 3: Fix conflicts after the rebase. >=20 > v3: > - Patch 3: Add tcp_chr_disconnect_locked() [Daniel] >=20 > Alberto Garcia (3): > main-loop: Fix GSource leak in qio_task_thread_worker() > main-loop: Add qemu_idle_add() > char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout() >=20 > chardev/char-socket.c | 25 +++++++++++++++++++++---- > include/qemu/main-loop.h | 12 ++++++++++++ > io/task.c | 9 +++------ > util/main-loop.c | 9 +++++++++ > 4 files changed, 45 insertions(+), 10 deletions(-) >=20 > --=20 > 2.11.0 >=20 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|