From: "Daniel P. Berrangé" <berrange@redhat.com> To: Thomas Huth <thuth@redhat.com> Cc: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org, mprivozn@redhat.com, Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP Date: Wed, 24 Apr 2019 09:31:13 +0100 [thread overview] Message-ID: <20190424083113.GE28615@redhat.com> (raw) In-Reply-To: <2b1d825f-8bd3-ba25-3e1b-8415aeec8ce6@redhat.com> On Wed, Apr 24, 2019 at 09:56:53AM +0200, Thomas Huth wrote: > On 23/04/2019 23.22, Eduardo Habkost wrote: > > This series adds machine type deprecation information to the > > output of the `query-machines` QMP command. With this, libvirt > > and management software will be able to show this information to > > users and/or suggest changes to VM configuration to avoid > > deprecated machine types. > > > > Eduardo Habkost (3): > > qapi: SupportStatusInfo struct > > machine: Use SupportStatusInfo for deprecation info > > qmp: Add deprecation information to query-machines > > > > qapi/common.json | 24 ++++++++++++++++++++++++ > > qapi/misc.json | 5 ++++- > > include/hw/boards.h | 7 ++++--- > > hw/i386/pc_piix.c | 4 +++- > > hw/ppc/prep.c | 4 +++- > > vl.c | 19 +++++++++++++++---- > > tests/acceptance/query_machines.py | 27 +++++++++++++++++++++++++++ > > 7 files changed, 80 insertions(+), 10 deletions(-) > > create mode 100644 tests/acceptance/query_machines.py > > Good idea, but some questions come to my mind: > > - What about devices? IIRC Gerd wrote a patch series last year that does > something similar for devices... It would be good to synchronize the > work, so that we do not have two completely interfaces between devices > and machines here in the end... Might as well add CPU models to that too as there's plenty of awful CPUs no one should use with KVM. The tricky thing is they are fine / sensible with TCG still. > > - Is deprecation as a status enough, or do we want to carry more > information here? E.g. is the machine maintained or orphan? Is it > stable or rather experimental? And didn't Gerd have also some > patches for this last year? ... yes, I think it was this series here: > http://lists.gnu.org/archive/html/qemu-ppc/2018-11/msg00039.html > ... actually, I like that idea with QemuSupportState... maybe you > could base your work on that series instead? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrangé" <berrange@redhat.com> To: Thomas Huth <thuth@redhat.com> Cc: mprivozn@redhat.com, Gerd Hoffmann <kraxel@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP Date: Wed, 24 Apr 2019 09:31:13 +0100 [thread overview] Message-ID: <20190424083113.GE28615@redhat.com> (raw) Message-ID: <20190424083113.00qXk8C7gxjYyWvkbn9R3tIvAg-4dNG8V6WNh6iE97s@z> (raw) In-Reply-To: <2b1d825f-8bd3-ba25-3e1b-8415aeec8ce6@redhat.com> On Wed, Apr 24, 2019 at 09:56:53AM +0200, Thomas Huth wrote: > On 23/04/2019 23.22, Eduardo Habkost wrote: > > This series adds machine type deprecation information to the > > output of the `query-machines` QMP command. With this, libvirt > > and management software will be able to show this information to > > users and/or suggest changes to VM configuration to avoid > > deprecated machine types. > > > > Eduardo Habkost (3): > > qapi: SupportStatusInfo struct > > machine: Use SupportStatusInfo for deprecation info > > qmp: Add deprecation information to query-machines > > > > qapi/common.json | 24 ++++++++++++++++++++++++ > > qapi/misc.json | 5 ++++- > > include/hw/boards.h | 7 ++++--- > > hw/i386/pc_piix.c | 4 +++- > > hw/ppc/prep.c | 4 +++- > > vl.c | 19 +++++++++++++++---- > > tests/acceptance/query_machines.py | 27 +++++++++++++++++++++++++++ > > 7 files changed, 80 insertions(+), 10 deletions(-) > > create mode 100644 tests/acceptance/query_machines.py > > Good idea, but some questions come to my mind: > > - What about devices? IIRC Gerd wrote a patch series last year that does > something similar for devices... It would be good to synchronize the > work, so that we do not have two completely interfaces between devices > and machines here in the end... Might as well add CPU models to that too as there's plenty of awful CPUs no one should use with KVM. The tricky thing is they are fine / sensible with TCG still. > > - Is deprecation as a status enough, or do we want to carry more > information here? E.g. is the machine maintained or orphan? Is it > stable or rather experimental? And didn't Gerd have also some > patches for this last year? ... yes, I think it was this series here: > http://lists.gnu.org/archive/html/qemu-ppc/2018-11/msg00039.html > ... actually, I like that idea with QemuSupportState... maybe you > could base your work on that series instead? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-04-24 8:33 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-23 21:22 [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP Eduardo Habkost 2019-04-23 21:22 ` Eduardo Habkost 2019-04-23 21:22 ` [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct Eduardo Habkost 2019-04-23 21:22 ` Eduardo Habkost 2019-04-23 22:23 ` Philippe Mathieu-Daudé 2019-04-23 22:23 ` Philippe Mathieu-Daudé 2019-04-24 18:24 ` Eduardo Habkost 2019-04-24 18:24 ` Eduardo Habkost 2019-04-24 8:26 ` Daniel P. Berrangé 2019-04-24 8:26 ` Daniel P. Berrangé 2019-04-24 18:20 ` Eduardo Habkost 2019-04-24 18:20 ` Eduardo Habkost 2019-04-30 10:10 ` Daniel P. Berrangé 2019-04-30 10:10 ` Daniel P. Berrangé 2019-04-30 12:42 ` Eduardo Habkost 2019-04-30 12:42 ` Eduardo Habkost 2019-04-30 12:47 ` Daniel P. Berrangé 2019-04-30 12:47 ` Daniel P. Berrangé 2019-04-25 14:20 ` Wainer dos Santos Moschetta 2019-04-25 14:20 ` Wainer dos Santos Moschetta 2019-04-25 17:42 ` Eduardo Habkost 2019-04-25 17:42 ` Eduardo Habkost 2019-04-30 10:03 ` Daniel P. Berrangé 2019-04-30 10:03 ` Daniel P. Berrangé 2019-04-23 21:22 ` [Qemu-devel] [PATCH 2/3] machine: Use SupportStatusInfo for deprecation info Eduardo Habkost 2019-04-23 21:22 ` Eduardo Habkost 2019-04-23 22:26 ` Philippe Mathieu-Daudé 2019-04-23 22:26 ` Philippe Mathieu-Daudé 2019-04-24 1:37 ` David Gibson 2019-04-24 1:37 ` David Gibson 2019-04-24 8:23 ` Daniel P. Berrangé 2019-04-24 8:23 ` Daniel P. Berrangé 2019-04-24 18:29 ` Eduardo Habkost 2019-04-24 18:29 ` Eduardo Habkost 2019-04-23 21:22 ` [Qemu-devel] [PATCH 3/3] qmp: Add deprecation information to query-machines Eduardo Habkost 2019-04-23 21:22 ` Eduardo Habkost 2019-04-24 8:28 ` Daniel P. Berrangé 2019-04-24 8:28 ` Daniel P. Berrangé 2019-04-25 14:54 ` Wainer dos Santos Moschetta 2019-04-25 14:54 ` Wainer dos Santos Moschetta 2019-04-25 17:43 ` Eduardo Habkost 2019-04-25 17:43 ` Eduardo Habkost 2019-04-23 21:28 ` [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP no-reply 2019-04-23 21:28 ` no-reply 2019-04-24 7:56 ` Thomas Huth 2019-04-24 7:56 ` Thomas Huth 2019-04-24 8:31 ` Daniel P. Berrangé [this message] 2019-04-24 8:31 ` Daniel P. Berrangé 2019-04-24 18:14 ` Eduardo Habkost 2019-04-24 18:14 ` Eduardo Habkost 2019-04-24 18:10 ` Eduardo Habkost 2019-04-24 18:10 ` Eduardo Habkost 2019-04-25 7:38 ` Thomas Huth 2019-04-25 7:38 ` Thomas Huth 2019-04-30 10:11 ` Daniel P. Berrangé 2019-04-30 10:11 ` Daniel P. Berrangé 2019-04-24 8:23 ` Michal Privoznik 2019-04-24 8:23 ` Michal Privoznik 2019-05-07 5:07 ` Markus Armbruster 2019-05-07 16:18 ` Eduardo Habkost 2019-05-08 9:16 ` Markus Armbruster 2019-05-08 20:28 ` Eduardo Habkost 2019-05-09 8:31 ` Markus Armbruster 2019-05-09 9:14 ` Daniel P. Berrangé 2019-05-09 15:52 ` Eduardo Habkost 2019-05-09 16:08 ` Daniel P. Berrangé 2019-05-09 17:44 ` Eduardo Habkost 2019-05-10 6:28 ` Markus Armbruster 2019-05-10 17:03 ` Eduardo Habkost 2019-05-10 6:19 ` Markus Armbruster 2019-05-10 17:00 ` Eduardo Habkost 2019-05-09 18:19 ` Eduardo Habkost 2019-05-10 9:29 ` Markus Armbruster 2019-05-10 17:17 ` Eduardo Habkost 2019-05-10 17:26 ` Daniel P. Berrangé 2019-05-13 11:49 ` Markus Armbruster
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190424083113.GE28615@redhat.com \ --to=berrange@redhat.com \ --cc=armbru@redhat.com \ --cc=ehabkost@redhat.com \ --cc=kraxel@redhat.com \ --cc=mprivozn@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=thuth@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).